All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Haozhong Zhang <haozhong.zhang@intel.com>,
	libvir-list@redhat.com
Subject: Re: TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)
Date: Wed, 18 Jan 2017 10:43:15 -0200	[thread overview]
Message-ID: <20170118124315.GR3491@thinpad.lan.raisama.net> (raw)
In-Reply-To: <20170118115541.GA13762@amt.cnet>

On Wed, Jan 18, 2017 at 09:55:43AM -0200, Marcelo Tosatti wrote:
> On Tue, Jan 10, 2017 at 05:36:48PM +0100, Paolo Bonzini wrote:
> > 
> > 
> > On 05/01/2017 11:48, Marcelo Tosatti wrote:
> > >> Host A has TSC scaling, host B doesn't have TSC scaling. We want
> > >> to be able to start the VM on host A, and migrate to B. In this
> > >> case, the only possible solution is to use B's frequency when
> > >> starting the VM. The QEMU process doesn't have enough information
> > >> to make that decision.
> > > That is a good point. But again, its a special case and 
> > > should be supported by -cpu xxx,tsc-frequency=zzzz.
> > 
> > I don't think this is a scenario that can work reliably.  The computed
> > TSC frequency may vary by 0.5% or so on every boot (e.g. you may get
> > 2497000 kHz or 2511000 kHz for a 2.5 GHz TSC).  You can start the VM on
> > host A, reboot host B, and then you'll be unable to migrate.
> > 
> > Paolo
> 
> Including an acceptable error in the comparison seems to be
> acceptable to work around that case.

How much error is acceptable when exposing the invtsc flag to the
guest?

-- 
Eduardo

WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Haozhong Zhang <haozhong.zhang@intel.com>,
	libvir-list@redhat.com
Subject: Re: [Qemu-devel] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)
Date: Wed, 18 Jan 2017 10:43:15 -0200	[thread overview]
Message-ID: <20170118124315.GR3491@thinpad.lan.raisama.net> (raw)
In-Reply-To: <20170118115541.GA13762@amt.cnet>

On Wed, Jan 18, 2017 at 09:55:43AM -0200, Marcelo Tosatti wrote:
> On Tue, Jan 10, 2017 at 05:36:48PM +0100, Paolo Bonzini wrote:
> > 
> > 
> > On 05/01/2017 11:48, Marcelo Tosatti wrote:
> > >> Host A has TSC scaling, host B doesn't have TSC scaling. We want
> > >> to be able to start the VM on host A, and migrate to B. In this
> > >> case, the only possible solution is to use B's frequency when
> > >> starting the VM. The QEMU process doesn't have enough information
> > >> to make that decision.
> > > That is a good point. But again, its a special case and 
> > > should be supported by -cpu xxx,tsc-frequency=zzzz.
> > 
> > I don't think this is a scenario that can work reliably.  The computed
> > TSC frequency may vary by 0.5% or so on every boot (e.g. you may get
> > 2497000 kHz or 2511000 kHz for a 2.5 GHz TSC).  You can start the VM on
> > host A, reboot host B, and then you'll be unable to migrate.
> > 
> > Paolo
> 
> Including an acceptable error in the comparison seems to be
> acceptable to work around that case.

How much error is acceptable when exposing the invtsc flag to the
guest?

-- 
Eduardo

  reply	other threads:[~2017-01-18 12:43 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-27 19:21 [PATCH 0/4] Allow migration with invtsc if there's no frequency mismatch Eduardo Habkost
2016-12-27 19:21 ` [Qemu-devel] " Eduardo Habkost
2016-12-27 19:21 ` [PATCH 1/4] kvm: Simplify invtsc check Eduardo Habkost
2016-12-27 19:21   ` [Qemu-devel] " Eduardo Habkost
2016-12-29 18:57   ` Marcelo Tosatti
2016-12-29 18:57     ` [Qemu-devel] " Marcelo Tosatti
2016-12-27 19:21 ` [PATCH 2/4] kvm: Allow invtsc migration if tsc-khz is set explicitly Eduardo Habkost
2016-12-27 19:21   ` [Qemu-devel] " Eduardo Habkost
2017-01-04 11:44   ` Marcelo Tosatti
2017-01-04 11:44     ` [Qemu-devel] " Marcelo Tosatti
2017-01-04 11:57     ` Marcelo Tosatti
2017-01-04 11:57       ` [Qemu-devel] " Marcelo Tosatti
2017-01-04 13:40     ` Eduardo Habkost
2017-01-04 13:40       ` [Qemu-devel] " Eduardo Habkost
2017-01-04 13:45       ` Marcelo Tosatti
2017-01-04 13:45         ` [Qemu-devel] " Marcelo Tosatti
2017-01-04 13:51         ` Eduardo Habkost
2017-01-04 13:51           ` [Qemu-devel] " Eduardo Habkost
2016-12-27 19:21 ` [PATCH 3/4] pc: Add 2.9 machine-types Eduardo Habkost
2016-12-27 19:21   ` [Qemu-devel] " Eduardo Habkost
2016-12-30 13:38   ` Igor Mammedov
2016-12-30 13:38     ` [Qemu-devel] " Igor Mammedov
2017-01-04 14:01   ` Laszlo Ersek
2017-01-04 14:20     ` Eduardo Habkost
2017-01-04 14:20       ` [Qemu-devel] " Eduardo Habkost
2017-01-04 16:40       ` Laszlo Ersek
2017-01-04 16:40         ` [Qemu-devel] " Laszlo Ersek
2017-01-04 17:46         ` Eduardo Habkost
2016-12-27 19:21 ` [PATCH 4/4] kvm: Allow migration with invtsc Eduardo Habkost
2016-12-27 19:21   ` [Qemu-devel] " Eduardo Habkost
2017-01-04 11:56   ` Marcelo Tosatti
2017-01-04 11:56     ` [Qemu-devel] " Marcelo Tosatti
2017-01-04 13:39     ` Eduardo Habkost
2017-01-04 13:39       ` [Qemu-devel] " Eduardo Habkost
2017-01-04 19:59       ` [libvirt] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc) Eduardo Habkost
2017-01-04 19:59         ` [Qemu-devel] " Eduardo Habkost
2017-01-04 22:26         ` Marcelo Tosatti
2017-01-04 22:26           ` [Qemu-devel] " Marcelo Tosatti
2017-01-05  1:36           ` Eduardo Habkost
2017-01-05  1:36             ` [Qemu-devel] " Eduardo Habkost
2017-01-05 10:48             ` Marcelo Tosatti
2017-01-05 10:48               ` [Qemu-devel] " Marcelo Tosatti
2017-01-05 10:50               ` Marcelo Tosatti
2017-01-05 10:50                 ` [Qemu-devel] " Marcelo Tosatti
2017-01-05 12:19               ` Eduardo Habkost
2017-01-05 12:19                 ` [Qemu-devel] " Eduardo Habkost
2017-01-05 12:33                 ` [libvirt] " Daniel P. Berrange
2017-01-05 12:33                   ` [Qemu-devel] " Daniel P. Berrange
2017-01-05 12:48                   ` Eduardo Habkost
2017-01-05 12:48                     ` [Qemu-devel] " Eduardo Habkost
2017-01-05 13:00                     ` Daniel P. Berrange
2017-01-05 13:00                       ` [Qemu-devel] " Daniel P. Berrange
2017-01-05 13:11                       ` Eduardo Habkost
2017-01-05 13:11                         ` [Qemu-devel] " Eduardo Habkost
2017-01-10 16:38                       ` Paolo Bonzini
2017-01-10 16:38                         ` [Qemu-devel] " Paolo Bonzini
2017-01-06 10:31                 ` Marcelo Tosatti
2017-01-06 10:31                   ` [Qemu-devel] " Marcelo Tosatti
2017-01-08 15:49                   ` How to make dest host abort migration safely " Eduardo Habkost
2017-01-08 15:49                     ` [Qemu-devel] " Eduardo Habkost
2017-01-09 10:04                     ` [libvirt] " Dr. David Alan Gilbert
2017-01-09 10:04                       ` [Qemu-devel] " Dr. David Alan Gilbert
2017-01-08 20:28                   ` Exporting kvm_max_guest_tsc_khz to userspace " Eduardo Habkost
2017-01-08 20:28                     ` [Qemu-devel] " Eduardo Habkost
2017-01-09 14:58                     ` Paolo Bonzini
2017-01-09 14:58                       ` [Qemu-devel] " Paolo Bonzini
2017-01-11 13:26                       ` Eduardo Habkost
2017-01-11 13:26                         ` [Qemu-devel] " Eduardo Habkost
2017-01-11 14:06                         ` Paolo Bonzini
2017-01-11 14:06                           ` [Qemu-devel] " Paolo Bonzini
2017-01-10 16:36               ` TSC frequency configuration & invtsc migration " Paolo Bonzini
2017-01-10 16:36                 ` [Qemu-devel] " Paolo Bonzini
2017-01-11 11:58                 ` Eduardo Habkost
2017-01-11 11:58                   ` [Qemu-devel] " Eduardo Habkost
2017-01-18 11:55                 ` Marcelo Tosatti
2017-01-18 11:55                   ` [Qemu-devel] " Marcelo Tosatti
2017-01-18 12:43                   ` Eduardo Habkost [this message]
2017-01-18 12:43                     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118124315.GR3491@thinpad.lan.raisama.net \
    --to=ehabkost@redhat.com \
    --cc=haozhong.zhang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=libvir-list@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.