* [PATCH] rt2800: remove warning on bcn_num != rt2x00dev->intf_beaconing
@ 2017-01-13 14:55 Stanislaw Gruszka
2017-01-19 12:48 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2017-01-13 14:55 UTC (permalink / raw)
To: linux-wireless; +Cc: Helmut Schaa, Daniel Golle
Since rt2800pci update beacon settings asynchronously from
tbtt tasklet, without beacon_skb_mutex protection, number of
currently active beacons entries can be different than
number pointed by rt2x00dev->intf_beaconing. Remove warning
about that inconsistency.
Reported-by: evaxige@qq.com
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 4fb79e0..1abe38f 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -967,8 +967,6 @@ static void rt2800_update_beacons_setup(struct rt2x00_dev *rt2x00dev)
bcn_num++;
}
- WARN_ON_ONCE(bcn_num != rt2x00dev->intf_beaconing);
-
rt2800_register_write(rt2x00dev, BCN_OFFSET0, (u32) reg);
rt2800_register_write(rt2x00dev, BCN_OFFSET1, (u32) (reg >> 32));
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: rt2800: remove warning on bcn_num != rt2x00dev->intf_beaconing
2017-01-13 14:55 [PATCH] rt2800: remove warning on bcn_num != rt2x00dev->intf_beaconing Stanislaw Gruszka
@ 2017-01-19 12:48 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-01-19 12:48 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: linux-wireless, Helmut Schaa, Daniel Golle
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Since rt2800pci update beacon settings asynchronously from
> tbtt tasklet, without beacon_skb_mutex protection, number of
> currently active beacons entries can be different than
> number pointed by rt2x00dev->intf_beaconing. Remove warning
> about that inconsistency.
>
> Reported-by: evaxige@qq.com
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
feecb0cb466b rt2800: remove warning on bcn_num != rt2x00dev->intf_beaconing
--
https://patchwork.kernel.org/patch/9515787/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-19 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-13 14:55 [PATCH] rt2800: remove warning on bcn_num != rt2x00dev->intf_beaconing Stanislaw Gruszka
2017-01-19 12:48 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.