[PATCH] drm/i915: Release temporary load-detect state upon switching

[PATCH] drm/i915: Release temporary load-detect state upon switching

[Chris Wilson]

After we call drm_atomic_commit() on the load-detect state, we can free
our local reference. Upon restore, we only apply and free the previous state.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_display.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index bddadd97db8d..ca3e7116438c 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11276,6 +11276,7 @@ bool intel_get_load_detect_pipe(struct drm_connector *connector,
 	}
 
 	old->restore_state = restore_state;
+	drm_atomic_state_put(state);
 
 	/* let the connector get through one full cycle before testing */
 	intel_wait_for_vblank(dev_priv, intel_crtc->pipe);
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915: Release temporary load-detect state upon switching

[Patchwork]

== Series Details ==

Series: drm/i915: Release temporary load-detect state upon switching
URL   : https://patchwork.freedesktop.org/series/18225/
State : failure

== Summary ==

Series 18225v1 drm/i915: Release temporary load-detect state upon switching
https://patchwork.freedesktop.org/api/1.0/series/18225/revisions/1/mbox/

Test drv_module_reload:
        Subgroup basic-reload:
                dmesg-warn -> PASS       (fi-ivb-3770)
                dmesg-warn -> PASS       (fi-snb-2600)
                dmesg-warn -> PASS       (fi-snb-2520m)
                dmesg-warn -> PASS       (fi-ivb-3520m)
                dmesg-warn -> PASS       (fi-byt-j1900)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-skl-6260u)

fi-bdw-5557u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-bsw-n3050     total:246  pass:207  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-j4205     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-bxt-t5700     total:79   pass:66   dwarn:0   dfail:0   fail:0   skip:12 
fi-byt-j1900     total:246  pass:219  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
fi-hsw-4770r     total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
fi-ivb-3520m     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
fi-ivb-3770      total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
fi-kbl-7500u     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6260u     total:206  pass:194  dwarn:0   dfail:0   fail:0   skip:11 
fi-skl-6700hq    total:246  pass:226  dwarn:0   dfail:0   fail:0   skip:20 
fi-skl-6700k     total:246  pass:222  dwarn:3   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13 
fi-snb-2520m     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-snb-2600      total:246  pass:214  dwarn:0   dfail:0   fail:0   skip:32 

758aa09aa53d8eaa2040b999197639f7c97eddb1 drm-tip: 2017y-01m-19d-11h-12m-46s UTC integration manifest
e6399f7 drm/i915: Release temporary load-detect state upon switching

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3545/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Release temporary load-detect state upon switching

[Ville Syrjälä]

On Thu, Jan 19, 2017 at 11:37:49AM +0000, Chris Wilson wrote:
> After we call drm_atomic_commit() on the load-detect state, we can free
> our local reference. Upon restore, we only apply and free the previous state.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Fixes: ?

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index bddadd97db8d..ca3e7116438c 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11276,6 +11276,7 @@ bool intel_get_load_detect_pipe(struct drm_connector *connector,
>  	}
>  
>  	old->restore_state = restore_state;
> +	drm_atomic_state_put(state);
>  
>  	/* let the connector get through one full cycle before testing */
>  	intel_wait_for_vblank(dev_priv, intel_crtc->pipe);
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Release temporary load-detect state upon switching

[Chris Wilson]

On Thu, Jan 19, 2017 at 03:31:46PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 19, 2017 at 11:37:49AM +0000, Chris Wilson wrote:
> > After we call drm_atomic_commit() on the load-detect state, we can free
> > our local reference. Upon restore, we only apply and free the previous state.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Fixes: ?
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state")
Cc: <drm-intel-fixes@lists.freedesktop.org> # v4.10-rc1+

Rough guess since everything else is.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx