From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Nadav Haklai <nadavh@marvell.com>,
Wilson Ding <dingwei@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Joe Zhou <shjzhou@marvell.com>,
Jon Pannell <jpannell@marvell.com>
Subject: Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341
Date: Fri, 20 Jan 2017 01:12:03 +0100 [thread overview]
Message-ID: <20170120001203.GB31483@lunn.ch> (raw)
In-Reply-To: <87y3y6k7pg.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote:
> Gregory CLEMENT <gregory.clement@free-electrons.com> writes:
>
> > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
> > +{
> > + return chip->info->family == MV88E6XXX_FAMILY_6341;
> > +}
>
> I don't want to see these erronous family checks anymore, but I cannot
> blame you for adding it since not all the code is moved to ops yet ;)
>
> > MV88E6XXX_FAMILY_6165, /* 6123 6161 6165 */
> > MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */
> > MV88E6XXX_FAMILY_6320, /* 6320 6321 */
> > + MV88E6XXX_FAMILY_6341, /* 6141 6341 */
>
> Maybe I missed it, Andrew, can you confirm that 6341 is a proper Marvell
> family of switch chips?
My understand is that it is. Marvell have not added it to DSDT. There
is a new SDK called UMSD, also GPLv2 and BSD. They call this family
Topaz, and the 6390 is Peridot.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Joe Zhou <shjzhou@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jon Pannell <jpannell@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Wilson Ding <dingwei@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341
Date: Fri, 20 Jan 2017 01:12:03 +0100 [thread overview]
Message-ID: <20170120001203.GB31483@lunn.ch> (raw)
In-Reply-To: <87y3y6k7pg.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote:
> Gregory CLEMENT <gregory.clement@free-electrons.com> writes:
>
> > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
> > +{
> > + return chip->info->family == MV88E6XXX_FAMILY_6341;
> > +}
>
> I don't want to see these erronous family checks anymore, but I cannot
> blame you for adding it since not all the code is moved to ops yet ;)
>
> > MV88E6XXX_FAMILY_6165, /* 6123 6161 6165 */
> > MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */
> > MV88E6XXX_FAMILY_6320, /* 6320 6321 */
> > + MV88E6XXX_FAMILY_6341, /* 6141 6341 */
>
> Maybe I missed it, Andrew, can you confirm that 6341 is a proper Marvell
> family of switch chips?
My understand is that it is. Marvell have not added it to DSDT. There
is a new SDK called UMSD, also GPLv2 and BSD. They call this family
Topaz, and the 6390 is Peridot.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341
Date: Fri, 20 Jan 2017 01:12:03 +0100 [thread overview]
Message-ID: <20170120001203.GB31483@lunn.ch> (raw)
In-Reply-To: <87y3y6k7pg.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote:
> Gregory CLEMENT <gregory.clement@free-electrons.com> writes:
>
> > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
> > +{
> > + return chip->info->family == MV88E6XXX_FAMILY_6341;
> > +}
>
> I don't want to see these erronous family checks anymore, but I cannot
> blame you for adding it since not all the code is moved to ops yet ;)
>
> > MV88E6XXX_FAMILY_6165, /* 6123 6161 6165 */
> > MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */
> > MV88E6XXX_FAMILY_6320, /* 6320 6321 */
> > + MV88E6XXX_FAMILY_6341, /* 6141 6341 */
>
> Maybe I missed it, Andrew, can you confirm that 6341 is a proper Marvell
> family of switch chips?
My understand is that it is. Marvell have not added it to DSDT. There
is a new SDK called UMSD, also GPLv2 and BSD. They call this family
Topaz, and the 6390 is Peridot.
Andrew
next prev parent reply other threads:[~2017-01-20 0:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:49 [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Gregory CLEMENT
2017-01-19 21:49 ` Gregory CLEMENT
2017-01-19 21:49 ` [PATCH v5 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Gregory CLEMENT
2017-01-19 21:49 ` Gregory CLEMENT
2017-01-19 22:13 ` Vivien Didelot
2017-01-19 22:13 ` Vivien Didelot
2017-01-19 22:13 ` Vivien Didelot
2017-01-20 0:06 ` Andrew Lunn
2017-01-20 0:06 ` Andrew Lunn
2017-01-20 0:06 ` Andrew Lunn
2017-01-20 1:54 ` Vivien Didelot
2017-01-20 1:54 ` Vivien Didelot
2017-01-19 21:49 ` [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Gregory CLEMENT
2017-01-19 21:49 ` Gregory CLEMENT
2017-01-19 22:26 ` Vivien Didelot
2017-01-19 22:26 ` Vivien Didelot
2017-01-19 22:26 ` Vivien Didelot
2017-01-20 0:12 ` Andrew Lunn [this message]
2017-01-20 0:12 ` Andrew Lunn
2017-01-20 0:12 ` Andrew Lunn
2017-01-20 1:55 ` Vivien Didelot
2017-01-20 1:55 ` Vivien Didelot
2017-01-20 17:21 ` Gregory CLEMENT
2017-01-20 17:21 ` Gregory CLEMENT
2017-01-20 17:21 ` Gregory CLEMENT
2017-01-20 17:30 ` Vivien Didelot
2017-01-20 17:30 ` Vivien Didelot
2017-01-20 23:15 ` Andrew Lunn
2017-01-20 23:15 ` Andrew Lunn
2017-01-19 22:06 ` [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Andrew Lunn
2017-01-19 22:06 ` Andrew Lunn
2017-01-19 22:06 ` Andrew Lunn
2017-01-19 23:41 ` [EXT] " Jon Pannell
2017-01-19 23:41 ` Jon Pannell
2017-01-19 23:41 ` Jon Pannell
2017-01-20 17:08 ` Gregory CLEMENT
2017-01-20 17:08 ` Gregory CLEMENT
2017-01-20 17:43 ` Andrew Lunn
2017-01-20 17:43 ` Andrew Lunn
2017-01-20 22:38 ` Andrew Lunn
2017-01-20 22:38 ` Andrew Lunn
2017-01-19 22:07 ` Vivien Didelot
2017-01-19 22:07 ` Vivien Didelot
2017-01-19 22:33 ` Vivien Didelot
2017-01-19 22:33 ` Vivien Didelot
2017-01-19 22:33 ` Vivien Didelot
2017-01-20 19:17 ` David Miller
2017-01-20 19:17 ` David Miller
2017-01-20 19:17 ` David Miller
2017-01-24 16:47 ` Gregory CLEMENT
2017-01-24 16:47 ` Gregory CLEMENT
2017-01-24 18:08 ` Vivien Didelot
2017-01-24 18:08 ` Vivien Didelot
2017-01-24 19:57 ` Andrew Lunn
2017-01-24 19:57 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120001203.GB31483@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dingwei@marvell.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jpannell@marvell.com \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shjzhou@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.