* [PATCH 0/3] mmc: sdhci-s3c: remove s3c specific header file [not found] <CGME20170120095012epcas5p463695278b6bd5d934c5af9cc26d09f03@epcas5p4.samsung.com> @ 2017-01-20 9:50 ` Jaehoon Chung [not found] ` <CGME20170120095012epcas5p444c0df4b86b9118c2bc5571a3f5c0161@epcas5p4.samsung.com> ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Jaehoon Chung @ 2017-01-20 9:50 UTC (permalink / raw) To: linux-mmc; +Cc: ulf.hansson, adrian.hunter, Jaehoon Chung Remove the s3c specific header file. Ther is no reason to keep the s3c-sdhci-reg header file. It can be located into sdhci-s3c.c. It's more easier to maintain the sdhci-s3c file. Jaehoon Chung (3): mmc: sdhci-s3c: remove the sdhci-s3c-regs header file mmc: sdhci-s3c: remove the unnecessary defined values mmc: sdhci-s3c: use the bitops API for bit operation drivers/mmc/host/sdhci-s3c-regs.h | 87 --------------------------------------- drivers/mmc/host/sdhci-s3c.c | 24 ++++++++++- 2 files changed, 23 insertions(+), 88 deletions(-) delete mode 100644 drivers/mmc/host/sdhci-s3c-regs.h -- 2.10.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20170120095012epcas5p444c0df4b86b9118c2bc5571a3f5c0161@epcas5p4.samsung.com>]
* [PATCH 1/3] mmc: sdhci-s3c: remove the sdhci-s3c-regs header file [not found] ` <CGME20170120095012epcas5p444c0df4b86b9118c2bc5571a3f5c0161@epcas5p4.samsung.com> @ 2017-01-20 9:50 ` Jaehoon Chung 0 siblings, 0 replies; 8+ messages in thread From: Jaehoon Chung @ 2017-01-20 9:50 UTC (permalink / raw) To: linux-mmc; +Cc: ulf.hansson, adrian.hunter, Jaehoon Chung Remove the sdhci-s3c-regs.h file. Instead, it located those defined values into sdhci-s3c.c. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/mmc/host/sdhci-s3c-regs.h | 87 --------------------------------------- drivers/mmc/host/sdhci-s3c.c | 70 ++++++++++++++++++++++++++++++- 2 files changed, 69 insertions(+), 88 deletions(-) delete mode 100644 drivers/mmc/host/sdhci-s3c-regs.h diff --git a/drivers/mmc/host/sdhci-s3c-regs.h b/drivers/mmc/host/sdhci-s3c-regs.h deleted file mode 100644 index e34049ad..0000000 --- a/drivers/mmc/host/sdhci-s3c-regs.h +++ /dev/null @@ -1,87 +0,0 @@ -/* linux/arch/arm/plat-s3c/include/plat/regs-sdhci.h - * - * Copyright 2008 Openmoko, Inc. - * Copyright 2008 Simtec Electronics - * http://armlinux.simtec.co.uk/ - * Ben Dooks <ben@simtec.co.uk> - * - * S3C Platform - SDHCI (HSMMC) register definitions - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. -*/ - -#ifndef __PLAT_S3C_SDHCI_REGS_H -#define __PLAT_S3C_SDHCI_REGS_H __FILE__ - -#define S3C_SDHCI_CONTROL2 (0x80) -#define S3C_SDHCI_CONTROL3 (0x84) -#define S3C64XX_SDHCI_CONTROL4 (0x8C) - -#define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) -#define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) -#define S3C_SDHCI_CTRL2_CDINVRXD3 (1 << 29) -#define S3C_SDHCI_CTRL2_SLCARDOUT (1 << 28) - -#define S3C_SDHCI_CTRL2_FLTCLKSEL_MASK (0xf << 24) -#define S3C_SDHCI_CTRL2_FLTCLKSEL_SHIFT (24) -#define S3C_SDHCI_CTRL2_FLTCLKSEL(_x) ((_x) << 24) - -#define S3C_SDHCI_CTRL2_LVLDAT_MASK (0xff << 16) -#define S3C_SDHCI_CTRL2_LVLDAT_SHIFT (16) -#define S3C_SDHCI_CTRL2_LVLDAT(_x) ((_x) << 16) - -#define S3C_SDHCI_CTRL2_ENFBCLKTX (1 << 15) -#define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) -#define S3C_SDHCI_CTRL2_SDCDSEL (1 << 13) -#define S3C_SDHCI_CTRL2_SDSIGPC (1 << 12) -#define S3C_SDHCI_CTRL2_ENBUSYCHKTXSTART (1 << 11) - -#define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) -#define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) -#define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) -#define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) -#define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) -#define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) - -#define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) -#define S3C_SDHCI_CTRL2_RWAITMODE (1 << 7) -#define S3C_SDHCI_CTRL2_DISBUFRD (1 << 6) -#define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) -#define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) -#define S3C_SDHCI_CTRL2_PWRSYNC (1 << 3) -#define S3C_SDHCI_CTRL2_ENCLKOUTMSKCON (1 << 1) -#define S3C_SDHCI_CTRL2_HWINITFIN (1 << 0) - -#define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) -#define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) -#define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) -#define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) - -#define S3C_SDHCI_CTRL3_FIA3_MASK (0x7f << 24) -#define S3C_SDHCI_CTRL3_FIA3_SHIFT (24) -#define S3C_SDHCI_CTRL3_FIA3(_x) ((_x) << 24) - -#define S3C_SDHCI_CTRL3_FIA2_MASK (0x7f << 16) -#define S3C_SDHCI_CTRL3_FIA2_SHIFT (16) -#define S3C_SDHCI_CTRL3_FIA2(_x) ((_x) << 16) - -#define S3C_SDHCI_CTRL3_FIA1_MASK (0x7f << 8) -#define S3C_SDHCI_CTRL3_FIA1_SHIFT (8) -#define S3C_SDHCI_CTRL3_FIA1(_x) ((_x) << 8) - -#define S3C_SDHCI_CTRL3_FIA0_MASK (0x7f << 0) -#define S3C_SDHCI_CTRL3_FIA0_SHIFT (0) -#define S3C_SDHCI_CTRL3_FIA0(_x) ((_x) << 0) - -#define S3C64XX_SDHCI_CONTROL4_DRIVE_MASK (0x3 << 16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_SHIFT (16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_2mA (0x0 << 16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_4mA (0x1 << 16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_7mA (0x2 << 16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) - -#define S3C64XX_SDHCI_CONTROL4_BUSY (1) - -#endif /* __PLAT_S3C_SDHCI_REGS_H */ diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index de219ca..7a230a1 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -29,11 +29,79 @@ #include <linux/mmc/host.h> -#include "sdhci-s3c-regs.h" #include "sdhci.h" #define MAX_BUS_CLK (4) +#define S3C_SDHCI_CONTROL2 (0x80) +#define S3C_SDHCI_CONTROL3 (0x84) +#define S3C64XX_SDHCI_CONTROL4 (0x8C) + +#define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) +#define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) +#define S3C_SDHCI_CTRL2_CDINVRXD3 (1 << 29) +#define S3C_SDHCI_CTRL2_SLCARDOUT (1 << 28) + +#define S3C_SDHCI_CTRL2_FLTCLKSEL_MASK (0xf << 24) +#define S3C_SDHCI_CTRL2_FLTCLKSEL_SHIFT (24) +#define S3C_SDHCI_CTRL2_FLTCLKSEL(_x) ((_x) << 24) + +#define S3C_SDHCI_CTRL2_LVLDAT_MASK (0xff << 16) +#define S3C_SDHCI_CTRL2_LVLDAT_SHIFT (16) +#define S3C_SDHCI_CTRL2_LVLDAT(_x) ((_x) << 16) + +#define S3C_SDHCI_CTRL2_ENFBCLKTX (1 << 15) +#define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) +#define S3C_SDHCI_CTRL2_SDCDSEL (1 << 13) +#define S3C_SDHCI_CTRL2_SDSIGPC (1 << 12) +#define S3C_SDHCI_CTRL2_ENBUSYCHKTXSTART (1 << 11) + +#define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) +#define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) +#define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) +#define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) +#define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) +#define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) + +#define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) +#define S3C_SDHCI_CTRL2_RWAITMODE (1 << 7) +#define S3C_SDHCI_CTRL2_DISBUFRD (1 << 6) +#define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) +#define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) +#define S3C_SDHCI_CTRL2_PWRSYNC (1 << 3) +#define S3C_SDHCI_CTRL2_ENCLKOUTMSKCON (1 << 1) +#define S3C_SDHCI_CTRL2_HWINITFIN (1 << 0) + +#define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) +#define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) +#define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) +#define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) + +#define S3C_SDHCI_CTRL3_FIA3_MASK (0x7f << 24) +#define S3C_SDHCI_CTRL3_FIA3_SHIFT (24) +#define S3C_SDHCI_CTRL3_FIA3(_x) ((_x) << 24) + +#define S3C_SDHCI_CTRL3_FIA2_MASK (0x7f << 16) +#define S3C_SDHCI_CTRL3_FIA2_SHIFT (16) +#define S3C_SDHCI_CTRL3_FIA2(_x) ((_x) << 16) + +#define S3C_SDHCI_CTRL3_FIA1_MASK (0x7f << 8) +#define S3C_SDHCI_CTRL3_FIA1_SHIFT (8) +#define S3C_SDHCI_CTRL3_FIA1(_x) ((_x) << 8) + +#define S3C_SDHCI_CTRL3_FIA0_MASK (0x7f << 0) +#define S3C_SDHCI_CTRL3_FIA0_SHIFT (0) +#define S3C_SDHCI_CTRL3_FIA0(_x) ((_x) << 0) + +#define S3C64XX_SDHCI_CONTROL4_DRIVE_MASK (0x3 << 16) +#define S3C64XX_SDHCI_CONTROL4_DRIVE_SHIFT (16) +#define S3C64XX_SDHCI_CONTROL4_DRIVE_2mA (0x0 << 16) +#define S3C64XX_SDHCI_CONTROL4_DRIVE_4mA (0x1 << 16) +#define S3C64XX_SDHCI_CONTROL4_DRIVE_7mA (0x2 << 16) +#define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) + +#define S3C64XX_SDHCI_CONTROL4_BUSY (1) + /** * struct sdhci_s3c - S3C SDHCI instance * @host: The SDHCI host created -- 2.10.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <CGME20170120095012epcas5p436242f1882d319fe958f0084dea71628@epcas5p4.samsung.com>]
* [PATCH 2/3] mmc: sdhci-s3c: remove the unnecessary defined values [not found] ` <CGME20170120095012epcas5p436242f1882d319fe958f0084dea71628@epcas5p4.samsung.com> @ 2017-01-20 9:50 ` Jaehoon Chung 2017-01-20 10:22 ` Ulf Hansson 0 siblings, 1 reply; 8+ messages in thread From: Jaehoon Chung @ 2017-01-20 9:50 UTC (permalink / raw) To: linux-mmc; +Cc: ulf.hansson, adrian.hunter, Jaehoon Chung Some defined value don't use anywhere. It doesn't need to maintain anywhere. Just keeps the minimum values what is using and needs. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/mmc/host/sdhci-s3c.c | 50 ++------------------------------------------ 1 file changed, 2 insertions(+), 48 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 7a230a1..e8b57cd 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -34,74 +34,28 @@ #define MAX_BUS_CLK (4) #define S3C_SDHCI_CONTROL2 (0x80) -#define S3C_SDHCI_CONTROL3 (0x84) -#define S3C64XX_SDHCI_CONTROL4 (0x8C) - #define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) #define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) -#define S3C_SDHCI_CTRL2_CDINVRXD3 (1 << 29) -#define S3C_SDHCI_CTRL2_SLCARDOUT (1 << 28) - -#define S3C_SDHCI_CTRL2_FLTCLKSEL_MASK (0xf << 24) -#define S3C_SDHCI_CTRL2_FLTCLKSEL_SHIFT (24) -#define S3C_SDHCI_CTRL2_FLTCLKSEL(_x) ((_x) << 24) - -#define S3C_SDHCI_CTRL2_LVLDAT_MASK (0xff << 16) -#define S3C_SDHCI_CTRL2_LVLDAT_SHIFT (16) -#define S3C_SDHCI_CTRL2_LVLDAT(_x) ((_x) << 16) - -#define S3C_SDHCI_CTRL2_ENFBCLKTX (1 << 15) #define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) -#define S3C_SDHCI_CTRL2_SDCDSEL (1 << 13) -#define S3C_SDHCI_CTRL2_SDSIGPC (1 << 12) -#define S3C_SDHCI_CTRL2_ENBUSYCHKTXSTART (1 << 11) - #define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) #define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) #define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) #define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) #define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) #define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) - #define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) -#define S3C_SDHCI_CTRL2_RWAITMODE (1 << 7) -#define S3C_SDHCI_CTRL2_DISBUFRD (1 << 6) #define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) #define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) -#define S3C_SDHCI_CTRL2_PWRSYNC (1 << 3) -#define S3C_SDHCI_CTRL2_ENCLKOUTMSKCON (1 << 1) -#define S3C_SDHCI_CTRL2_HWINITFIN (1 << 0) +#define S3C_SDHCI_CONTROL3 (0x84) #define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) #define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) #define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) #define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) -#define S3C_SDHCI_CTRL3_FIA3_MASK (0x7f << 24) -#define S3C_SDHCI_CTRL3_FIA3_SHIFT (24) -#define S3C_SDHCI_CTRL3_FIA3(_x) ((_x) << 24) - -#define S3C_SDHCI_CTRL3_FIA2_MASK (0x7f << 16) -#define S3C_SDHCI_CTRL3_FIA2_SHIFT (16) -#define S3C_SDHCI_CTRL3_FIA2(_x) ((_x) << 16) - -#define S3C_SDHCI_CTRL3_FIA1_MASK (0x7f << 8) -#define S3C_SDHCI_CTRL3_FIA1_SHIFT (8) -#define S3C_SDHCI_CTRL3_FIA1(_x) ((_x) << 8) - -#define S3C_SDHCI_CTRL3_FIA0_MASK (0x7f << 0) -#define S3C_SDHCI_CTRL3_FIA0_SHIFT (0) -#define S3C_SDHCI_CTRL3_FIA0(_x) ((_x) << 0) - -#define S3C64XX_SDHCI_CONTROL4_DRIVE_MASK (0x3 << 16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_SHIFT (16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_2mA (0x0 << 16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_4mA (0x1 << 16) -#define S3C64XX_SDHCI_CONTROL4_DRIVE_7mA (0x2 << 16) +#define S3C64XX_SDHCI_CONTROL4 (0x8C) #define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) -#define S3C64XX_SDHCI_CONTROL4_BUSY (1) - /** * struct sdhci_s3c - S3C SDHCI instance * @host: The SDHCI host created -- 2.10.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] mmc: sdhci-s3c: remove the unnecessary defined values 2017-01-20 9:50 ` [PATCH 2/3] mmc: sdhci-s3c: remove the unnecessary defined values Jaehoon Chung @ 2017-01-20 10:22 ` Ulf Hansson 2017-01-23 1:59 ` Jaehoon Chung 0 siblings, 1 reply; 8+ messages in thread From: Ulf Hansson @ 2017-01-20 10:22 UTC (permalink / raw) To: Jaehoon Chung; +Cc: linux-mmc, Adrian Hunter On 20 January 2017 at 10:50, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Some defined value don't use anywhere. > It doesn't need to maintain anywhere. > Just keeps the minimum values what is using and needs. I don't mind keeping them, even if they are unused. And perhaps, we start to use them one day. Moreover, sometimes it helps to understand the HW, particularly if you don't have the spec at hand. Kind regards Uffe > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/mmc/host/sdhci-s3c.c | 50 ++------------------------------------------ > 1 file changed, 2 insertions(+), 48 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 7a230a1..e8b57cd 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -34,74 +34,28 @@ > #define MAX_BUS_CLK (4) > > #define S3C_SDHCI_CONTROL2 (0x80) > -#define S3C_SDHCI_CONTROL3 (0x84) > -#define S3C64XX_SDHCI_CONTROL4 (0x8C) > - > #define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) > #define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) > -#define S3C_SDHCI_CTRL2_CDINVRXD3 (1 << 29) > -#define S3C_SDHCI_CTRL2_SLCARDOUT (1 << 28) > - > -#define S3C_SDHCI_CTRL2_FLTCLKSEL_MASK (0xf << 24) > -#define S3C_SDHCI_CTRL2_FLTCLKSEL_SHIFT (24) > -#define S3C_SDHCI_CTRL2_FLTCLKSEL(_x) ((_x) << 24) > - > -#define S3C_SDHCI_CTRL2_LVLDAT_MASK (0xff << 16) > -#define S3C_SDHCI_CTRL2_LVLDAT_SHIFT (16) > -#define S3C_SDHCI_CTRL2_LVLDAT(_x) ((_x) << 16) > - > -#define S3C_SDHCI_CTRL2_ENFBCLKTX (1 << 15) > #define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) > -#define S3C_SDHCI_CTRL2_SDCDSEL (1 << 13) > -#define S3C_SDHCI_CTRL2_SDSIGPC (1 << 12) > -#define S3C_SDHCI_CTRL2_ENBUSYCHKTXSTART (1 << 11) > - > #define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) > #define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) > #define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) > #define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) > #define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) > #define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) > - > #define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) > -#define S3C_SDHCI_CTRL2_RWAITMODE (1 << 7) > -#define S3C_SDHCI_CTRL2_DISBUFRD (1 << 6) > #define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) > #define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) > -#define S3C_SDHCI_CTRL2_PWRSYNC (1 << 3) > -#define S3C_SDHCI_CTRL2_ENCLKOUTMSKCON (1 << 1) > -#define S3C_SDHCI_CTRL2_HWINITFIN (1 << 0) > > +#define S3C_SDHCI_CONTROL3 (0x84) > #define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) > #define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) > #define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) > #define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) > > -#define S3C_SDHCI_CTRL3_FIA3_MASK (0x7f << 24) > -#define S3C_SDHCI_CTRL3_FIA3_SHIFT (24) > -#define S3C_SDHCI_CTRL3_FIA3(_x) ((_x) << 24) > - > -#define S3C_SDHCI_CTRL3_FIA2_MASK (0x7f << 16) > -#define S3C_SDHCI_CTRL3_FIA2_SHIFT (16) > -#define S3C_SDHCI_CTRL3_FIA2(_x) ((_x) << 16) > - > -#define S3C_SDHCI_CTRL3_FIA1_MASK (0x7f << 8) > -#define S3C_SDHCI_CTRL3_FIA1_SHIFT (8) > -#define S3C_SDHCI_CTRL3_FIA1(_x) ((_x) << 8) > - > -#define S3C_SDHCI_CTRL3_FIA0_MASK (0x7f << 0) > -#define S3C_SDHCI_CTRL3_FIA0_SHIFT (0) > -#define S3C_SDHCI_CTRL3_FIA0(_x) ((_x) << 0) > - > -#define S3C64XX_SDHCI_CONTROL4_DRIVE_MASK (0x3 << 16) > -#define S3C64XX_SDHCI_CONTROL4_DRIVE_SHIFT (16) > -#define S3C64XX_SDHCI_CONTROL4_DRIVE_2mA (0x0 << 16) > -#define S3C64XX_SDHCI_CONTROL4_DRIVE_4mA (0x1 << 16) > -#define S3C64XX_SDHCI_CONTROL4_DRIVE_7mA (0x2 << 16) > +#define S3C64XX_SDHCI_CONTROL4 (0x8C) > #define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) > > -#define S3C64XX_SDHCI_CONTROL4_BUSY (1) > - > /** > * struct sdhci_s3c - S3C SDHCI instance > * @host: The SDHCI host created > -- > 2.10.2 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] mmc: sdhci-s3c: remove the unnecessary defined values 2017-01-20 10:22 ` Ulf Hansson @ 2017-01-23 1:59 ` Jaehoon Chung 2017-01-23 9:12 ` Ulf Hansson 0 siblings, 1 reply; 8+ messages in thread From: Jaehoon Chung @ 2017-01-23 1:59 UTC (permalink / raw) To: Ulf Hansson; +Cc: linux-mmc, Adrian Hunter Hi Ulf, On 01/20/2017 07:22 PM, Ulf Hansson wrote: > On 20 January 2017 at 10:50, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> Some defined value don't use anywhere. >> It doesn't need to maintain anywhere. >> Just keeps the minimum values what is using and needs. > > I don't mind keeping them, even if they are unused. And perhaps, we > start to use them one day. > > Moreover, sometimes it helps to understand the HW, particularly if you > don't have the spec at hand. Agreed..Then how do you think about other patches? Best Regards, Jaehoon Chung > > Kind regards > Uffe > >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> drivers/mmc/host/sdhci-s3c.c | 50 ++------------------------------------------ >> 1 file changed, 2 insertions(+), 48 deletions(-) >> >> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c >> index 7a230a1..e8b57cd 100644 >> --- a/drivers/mmc/host/sdhci-s3c.c >> +++ b/drivers/mmc/host/sdhci-s3c.c >> @@ -34,74 +34,28 @@ >> #define MAX_BUS_CLK (4) >> >> #define S3C_SDHCI_CONTROL2 (0x80) >> -#define S3C_SDHCI_CONTROL3 (0x84) >> -#define S3C64XX_SDHCI_CONTROL4 (0x8C) >> - >> #define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) >> #define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) >> -#define S3C_SDHCI_CTRL2_CDINVRXD3 (1 << 29) >> -#define S3C_SDHCI_CTRL2_SLCARDOUT (1 << 28) >> - >> -#define S3C_SDHCI_CTRL2_FLTCLKSEL_MASK (0xf << 24) >> -#define S3C_SDHCI_CTRL2_FLTCLKSEL_SHIFT (24) >> -#define S3C_SDHCI_CTRL2_FLTCLKSEL(_x) ((_x) << 24) >> - >> -#define S3C_SDHCI_CTRL2_LVLDAT_MASK (0xff << 16) >> -#define S3C_SDHCI_CTRL2_LVLDAT_SHIFT (16) >> -#define S3C_SDHCI_CTRL2_LVLDAT(_x) ((_x) << 16) >> - >> -#define S3C_SDHCI_CTRL2_ENFBCLKTX (1 << 15) >> #define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) >> -#define S3C_SDHCI_CTRL2_SDCDSEL (1 << 13) >> -#define S3C_SDHCI_CTRL2_SDSIGPC (1 << 12) >> -#define S3C_SDHCI_CTRL2_ENBUSYCHKTXSTART (1 << 11) >> - >> #define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) >> #define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) >> #define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) >> #define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) >> #define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) >> #define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) >> - >> #define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) >> -#define S3C_SDHCI_CTRL2_RWAITMODE (1 << 7) >> -#define S3C_SDHCI_CTRL2_DISBUFRD (1 << 6) >> #define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) >> #define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) >> -#define S3C_SDHCI_CTRL2_PWRSYNC (1 << 3) >> -#define S3C_SDHCI_CTRL2_ENCLKOUTMSKCON (1 << 1) >> -#define S3C_SDHCI_CTRL2_HWINITFIN (1 << 0) >> >> +#define S3C_SDHCI_CONTROL3 (0x84) >> #define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) >> #define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) >> #define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) >> #define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) >> >> -#define S3C_SDHCI_CTRL3_FIA3_MASK (0x7f << 24) >> -#define S3C_SDHCI_CTRL3_FIA3_SHIFT (24) >> -#define S3C_SDHCI_CTRL3_FIA3(_x) ((_x) << 24) >> - >> -#define S3C_SDHCI_CTRL3_FIA2_MASK (0x7f << 16) >> -#define S3C_SDHCI_CTRL3_FIA2_SHIFT (16) >> -#define S3C_SDHCI_CTRL3_FIA2(_x) ((_x) << 16) >> - >> -#define S3C_SDHCI_CTRL3_FIA1_MASK (0x7f << 8) >> -#define S3C_SDHCI_CTRL3_FIA1_SHIFT (8) >> -#define S3C_SDHCI_CTRL3_FIA1(_x) ((_x) << 8) >> - >> -#define S3C_SDHCI_CTRL3_FIA0_MASK (0x7f << 0) >> -#define S3C_SDHCI_CTRL3_FIA0_SHIFT (0) >> -#define S3C_SDHCI_CTRL3_FIA0(_x) ((_x) << 0) >> - >> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_MASK (0x3 << 16) >> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_SHIFT (16) >> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_2mA (0x0 << 16) >> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_4mA (0x1 << 16) >> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_7mA (0x2 << 16) >> +#define S3C64XX_SDHCI_CONTROL4 (0x8C) >> #define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) >> >> -#define S3C64XX_SDHCI_CONTROL4_BUSY (1) >> - >> /** >> * struct sdhci_s3c - S3C SDHCI instance >> * @host: The SDHCI host created >> -- >> 2.10.2 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] mmc: sdhci-s3c: remove the unnecessary defined values 2017-01-23 1:59 ` Jaehoon Chung @ 2017-01-23 9:12 ` Ulf Hansson 2017-01-23 10:50 ` Jaehoon Chung 0 siblings, 1 reply; 8+ messages in thread From: Ulf Hansson @ 2017-01-23 9:12 UTC (permalink / raw) To: Jaehoon Chung; +Cc: linux-mmc, Adrian Hunter On 23 January 2017 at 02:59, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Hi Ulf, > > On 01/20/2017 07:22 PM, Ulf Hansson wrote: >> On 20 January 2017 at 10:50, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>> Some defined value don't use anywhere. >>> It doesn't need to maintain anywhere. >>> Just keeps the minimum values what is using and needs. >> >> I don't mind keeping them, even if they are unused. And perhaps, we >> start to use them one day. >> >> Moreover, sometimes it helps to understand the HW, particularly if you >> don't have the spec at hand. > > Agreed..Then how do you think about other patches? Looks good. Do they apply as is or you need to rebase the series? Kind regards Uffe > > Best Regards, > Jaehoon Chung > >> >> Kind regards >> Uffe >> >>> >>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >>> --- >>> drivers/mmc/host/sdhci-s3c.c | 50 ++------------------------------------------ >>> 1 file changed, 2 insertions(+), 48 deletions(-) >>> >>> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c >>> index 7a230a1..e8b57cd 100644 >>> --- a/drivers/mmc/host/sdhci-s3c.c >>> +++ b/drivers/mmc/host/sdhci-s3c.c >>> @@ -34,74 +34,28 @@ >>> #define MAX_BUS_CLK (4) >>> >>> #define S3C_SDHCI_CONTROL2 (0x80) >>> -#define S3C_SDHCI_CONTROL3 (0x84) >>> -#define S3C64XX_SDHCI_CONTROL4 (0x8C) >>> - >>> #define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) >>> #define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) >>> -#define S3C_SDHCI_CTRL2_CDINVRXD3 (1 << 29) >>> -#define S3C_SDHCI_CTRL2_SLCARDOUT (1 << 28) >>> - >>> -#define S3C_SDHCI_CTRL2_FLTCLKSEL_MASK (0xf << 24) >>> -#define S3C_SDHCI_CTRL2_FLTCLKSEL_SHIFT (24) >>> -#define S3C_SDHCI_CTRL2_FLTCLKSEL(_x) ((_x) << 24) >>> - >>> -#define S3C_SDHCI_CTRL2_LVLDAT_MASK (0xff << 16) >>> -#define S3C_SDHCI_CTRL2_LVLDAT_SHIFT (16) >>> -#define S3C_SDHCI_CTRL2_LVLDAT(_x) ((_x) << 16) >>> - >>> -#define S3C_SDHCI_CTRL2_ENFBCLKTX (1 << 15) >>> #define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) >>> -#define S3C_SDHCI_CTRL2_SDCDSEL (1 << 13) >>> -#define S3C_SDHCI_CTRL2_SDSIGPC (1 << 12) >>> -#define S3C_SDHCI_CTRL2_ENBUSYCHKTXSTART (1 << 11) >>> - >>> #define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) >>> #define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) >>> #define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) >>> #define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) >>> #define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) >>> #define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) >>> - >>> #define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) >>> -#define S3C_SDHCI_CTRL2_RWAITMODE (1 << 7) >>> -#define S3C_SDHCI_CTRL2_DISBUFRD (1 << 6) >>> #define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) >>> #define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) >>> -#define S3C_SDHCI_CTRL2_PWRSYNC (1 << 3) >>> -#define S3C_SDHCI_CTRL2_ENCLKOUTMSKCON (1 << 1) >>> -#define S3C_SDHCI_CTRL2_HWINITFIN (1 << 0) >>> >>> +#define S3C_SDHCI_CONTROL3 (0x84) >>> #define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) >>> #define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) >>> #define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) >>> #define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) >>> >>> -#define S3C_SDHCI_CTRL3_FIA3_MASK (0x7f << 24) >>> -#define S3C_SDHCI_CTRL3_FIA3_SHIFT (24) >>> -#define S3C_SDHCI_CTRL3_FIA3(_x) ((_x) << 24) >>> - >>> -#define S3C_SDHCI_CTRL3_FIA2_MASK (0x7f << 16) >>> -#define S3C_SDHCI_CTRL3_FIA2_SHIFT (16) >>> -#define S3C_SDHCI_CTRL3_FIA2(_x) ((_x) << 16) >>> - >>> -#define S3C_SDHCI_CTRL3_FIA1_MASK (0x7f << 8) >>> -#define S3C_SDHCI_CTRL3_FIA1_SHIFT (8) >>> -#define S3C_SDHCI_CTRL3_FIA1(_x) ((_x) << 8) >>> - >>> -#define S3C_SDHCI_CTRL3_FIA0_MASK (0x7f << 0) >>> -#define S3C_SDHCI_CTRL3_FIA0_SHIFT (0) >>> -#define S3C_SDHCI_CTRL3_FIA0(_x) ((_x) << 0) >>> - >>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_MASK (0x3 << 16) >>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_SHIFT (16) >>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_2mA (0x0 << 16) >>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_4mA (0x1 << 16) >>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_7mA (0x2 << 16) >>> +#define S3C64XX_SDHCI_CONTROL4 (0x8C) >>> #define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) >>> >>> -#define S3C64XX_SDHCI_CONTROL4_BUSY (1) >>> - >>> /** >>> * struct sdhci_s3c - S3C SDHCI instance >>> * @host: The SDHCI host created >>> -- >>> 2.10.2 >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] mmc: sdhci-s3c: remove the unnecessary defined values 2017-01-23 9:12 ` Ulf Hansson @ 2017-01-23 10:50 ` Jaehoon Chung 0 siblings, 0 replies; 8+ messages in thread From: Jaehoon Chung @ 2017-01-23 10:50 UTC (permalink / raw) To: Ulf Hansson; +Cc: linux-mmc, Adrian Hunter On 01/23/2017 06:12 PM, Ulf Hansson wrote: > On 23 January 2017 at 02:59, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> Hi Ulf, >> >> On 01/20/2017 07:22 PM, Ulf Hansson wrote: >>> On 20 January 2017 at 10:50, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>>> Some defined value don't use anywhere. >>>> It doesn't need to maintain anywhere. >>>> Just keeps the minimum values what is using and needs. >>> >>> I don't mind keeping them, even if they are unused. And perhaps, we >>> start to use them one day. >>> >>> Moreover, sometimes it helps to understand the HW, particularly if you >>> don't have the spec at hand. >> >> Agreed..Then how do you think about other patches? > > Looks good. Do they apply as is or you need to rebase the series? I will resend the patch v2. Best Regards, Jaehoon Chung > > Kind regards > Uffe > >> >> Best Regards, >> Jaehoon Chung >> >>> >>> Kind regards >>> Uffe >>> >>>> >>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >>>> --- >>>> drivers/mmc/host/sdhci-s3c.c | 50 ++------------------------------------------ >>>> 1 file changed, 2 insertions(+), 48 deletions(-) >>>> >>>> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c >>>> index 7a230a1..e8b57cd 100644 >>>> --- a/drivers/mmc/host/sdhci-s3c.c >>>> +++ b/drivers/mmc/host/sdhci-s3c.c >>>> @@ -34,74 +34,28 @@ >>>> #define MAX_BUS_CLK (4) >>>> >>>> #define S3C_SDHCI_CONTROL2 (0x80) >>>> -#define S3C_SDHCI_CONTROL3 (0x84) >>>> -#define S3C64XX_SDHCI_CONTROL4 (0x8C) >>>> - >>>> #define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) >>>> #define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) >>>> -#define S3C_SDHCI_CTRL2_CDINVRXD3 (1 << 29) >>>> -#define S3C_SDHCI_CTRL2_SLCARDOUT (1 << 28) >>>> - >>>> -#define S3C_SDHCI_CTRL2_FLTCLKSEL_MASK (0xf << 24) >>>> -#define S3C_SDHCI_CTRL2_FLTCLKSEL_SHIFT (24) >>>> -#define S3C_SDHCI_CTRL2_FLTCLKSEL(_x) ((_x) << 24) >>>> - >>>> -#define S3C_SDHCI_CTRL2_LVLDAT_MASK (0xff << 16) >>>> -#define S3C_SDHCI_CTRL2_LVLDAT_SHIFT (16) >>>> -#define S3C_SDHCI_CTRL2_LVLDAT(_x) ((_x) << 16) >>>> - >>>> -#define S3C_SDHCI_CTRL2_ENFBCLKTX (1 << 15) >>>> #define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) >>>> -#define S3C_SDHCI_CTRL2_SDCDSEL (1 << 13) >>>> -#define S3C_SDHCI_CTRL2_SDSIGPC (1 << 12) >>>> -#define S3C_SDHCI_CTRL2_ENBUSYCHKTXSTART (1 << 11) >>>> - >>>> #define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) >>>> #define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) >>>> #define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) >>>> #define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) >>>> #define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) >>>> #define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) >>>> - >>>> #define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) >>>> -#define S3C_SDHCI_CTRL2_RWAITMODE (1 << 7) >>>> -#define S3C_SDHCI_CTRL2_DISBUFRD (1 << 6) >>>> #define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) >>>> #define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) >>>> -#define S3C_SDHCI_CTRL2_PWRSYNC (1 << 3) >>>> -#define S3C_SDHCI_CTRL2_ENCLKOUTMSKCON (1 << 1) >>>> -#define S3C_SDHCI_CTRL2_HWINITFIN (1 << 0) >>>> >>>> +#define S3C_SDHCI_CONTROL3 (0x84) >>>> #define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) >>>> #define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) >>>> #define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) >>>> #define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) >>>> >>>> -#define S3C_SDHCI_CTRL3_FIA3_MASK (0x7f << 24) >>>> -#define S3C_SDHCI_CTRL3_FIA3_SHIFT (24) >>>> -#define S3C_SDHCI_CTRL3_FIA3(_x) ((_x) << 24) >>>> - >>>> -#define S3C_SDHCI_CTRL3_FIA2_MASK (0x7f << 16) >>>> -#define S3C_SDHCI_CTRL3_FIA2_SHIFT (16) >>>> -#define S3C_SDHCI_CTRL3_FIA2(_x) ((_x) << 16) >>>> - >>>> -#define S3C_SDHCI_CTRL3_FIA1_MASK (0x7f << 8) >>>> -#define S3C_SDHCI_CTRL3_FIA1_SHIFT (8) >>>> -#define S3C_SDHCI_CTRL3_FIA1(_x) ((_x) << 8) >>>> - >>>> -#define S3C_SDHCI_CTRL3_FIA0_MASK (0x7f << 0) >>>> -#define S3C_SDHCI_CTRL3_FIA0_SHIFT (0) >>>> -#define S3C_SDHCI_CTRL3_FIA0(_x) ((_x) << 0) >>>> - >>>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_MASK (0x3 << 16) >>>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_SHIFT (16) >>>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_2mA (0x0 << 16) >>>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_4mA (0x1 << 16) >>>> -#define S3C64XX_SDHCI_CONTROL4_DRIVE_7mA (0x2 << 16) >>>> +#define S3C64XX_SDHCI_CONTROL4 (0x8C) >>>> #define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) >>>> >>>> -#define S3C64XX_SDHCI_CONTROL4_BUSY (1) >>>> - >>>> /** >>>> * struct sdhci_s3c - S3C SDHCI instance >>>> * @host: The SDHCI host created >>>> -- >>>> 2.10.2 >>>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >>> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20170120095012epcas5p4b5e0955e3e75e96b37ef1ef66fb501f6@epcas5p4.samsung.com>]
* [PATCH 3/3] mmc: sdhci-s3c: use the bitops API for bit operation [not found] ` <CGME20170120095012epcas5p4b5e0955e3e75e96b37ef1ef66fb501f6@epcas5p4.samsung.com> @ 2017-01-20 9:50 ` Jaehoon Chung 0 siblings, 0 replies; 8+ messages in thread From: Jaehoon Chung @ 2017-01-20 9:50 UTC (permalink / raw) To: linux-mmc; +Cc: ulf.hansson, adrian.hunter, Jaehoon Chung Use the bitops API instead of shifting directly. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/mmc/host/sdhci-s3c.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index e8b57cd..6c102d8 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -34,24 +34,24 @@ #define MAX_BUS_CLK (4) #define S3C_SDHCI_CONTROL2 (0x80) -#define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) -#define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) -#define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) +#define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR BIT(31) +#define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK BIT(30) +#define S3C_SDHCI_CTRL2_ENFBCLKRX BIT(14) #define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) #define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) #define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) #define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) #define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) #define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) -#define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) +#define S3C_SDHCI_CTRL2_ENCLKOUTHOLD BIT(8) #define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) #define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) #define S3C_SDHCI_CONTROL3 (0x84) -#define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) -#define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) -#define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) -#define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) +#define S3C_SDHCI_CTRL3_FCSEL3 BIT(31) +#define S3C_SDHCI_CTRL3_FCSEL2 BIT(23) +#define S3C_SDHCI_CTRL3_FCSEL1 BIT(15) +#define S3C_SDHCI_CTRL3_FCSEL0 BIT(7) #define S3C64XX_SDHCI_CONTROL4 (0x8C) #define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16) -- 2.10.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-01-23 10:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170120095012epcas5p463695278b6bd5d934c5af9cc26d09f03@epcas5p4.samsung.com>
2017-01-20 9:50 ` [PATCH 0/3] mmc: sdhci-s3c: remove s3c specific header file Jaehoon Chung
[not found] ` <CGME20170120095012epcas5p444c0df4b86b9118c2bc5571a3f5c0161@epcas5p4.samsung.com>
2017-01-20 9:50 ` [PATCH 1/3] mmc: sdhci-s3c: remove the sdhci-s3c-regs " Jaehoon Chung
[not found] ` <CGME20170120095012epcas5p436242f1882d319fe958f0084dea71628@epcas5p4.samsung.com>
2017-01-20 9:50 ` [PATCH 2/3] mmc: sdhci-s3c: remove the unnecessary defined values Jaehoon Chung
2017-01-20 10:22 ` Ulf Hansson
2017-01-23 1:59 ` Jaehoon Chung
2017-01-23 9:12 ` Ulf Hansson
2017-01-23 10:50 ` Jaehoon Chung
[not found] ` <CGME20170120095012epcas5p4b5e0955e3e75e96b37ef1ef66fb501f6@epcas5p4.samsung.com>
2017-01-20 9:50 ` [PATCH 3/3] mmc: sdhci-s3c: use the bitops API for bit operation Jaehoon Chung
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.