From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Bjorn Andersson
<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Subhash Jadavani
<subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Vivek Gautam
<vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 3/4] phy: qcom-ufs: Remove -always-on property
Date: Sat, 21 Jan 2017 14:43:02 -0600 [thread overview]
Message-ID: <20170121204302.ek2oovgay5odhdi3@rob-hp-laptop> (raw)
In-Reply-To: <20170119104739.4376-3-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Thu, Jan 19, 2017 at 02:47:38AM -0800, Bjorn Andersson wrote:
> The fact that a regulator is always-on is a property of the regulator,
> not a specific consumer. Implementing this in the driver leads to a
> system behaviour that is dependent on if the Qualcomm UFS PHY was ever
> (partially) probed.
>
> If the specific regulator should be always on in a particular device,
> mark it so by specifying "regulator-always-on" in the regulator node.
>
> Cc: Subhash Jadavani <subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Cc: Vivek Gautam <vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 1 -
> drivers/phy/phy-qcom-ufs-i.h | 1 -
> drivers/phy/phy-qcom-ufs.c | 5 +----
> 3 files changed, 1 insertion(+), 6 deletions(-)
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Subhash Jadavani <subhashj@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: Re: [PATCH 3/4] phy: qcom-ufs: Remove -always-on property
Date: Sat, 21 Jan 2017 14:43:02 -0600 [thread overview]
Message-ID: <20170121204302.ek2oovgay5odhdi3@rob-hp-laptop> (raw)
In-Reply-To: <20170119104739.4376-3-bjorn.andersson@linaro.org>
On Thu, Jan 19, 2017 at 02:47:38AM -0800, Bjorn Andersson wrote:
> The fact that a regulator is always-on is a property of the regulator,
> not a specific consumer. Implementing this in the driver leads to a
> system behaviour that is dependent on if the Qualcomm UFS PHY was ever
> (partially) probed.
>
> If the specific regulator should be always on in a particular device,
> mark it so by specifying "regulator-always-on" in the regulator node.
>
> Cc: Subhash Jadavani <subhashj@codeaurora.org>
> Cc: Vivek Gautam <vivek.gautam@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 1 -
> drivers/phy/phy-qcom-ufs-i.h | 1 -
> drivers/phy/phy-qcom-ufs.c | 5 +----
> 3 files changed, 1 insertion(+), 6 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2017-01-21 20:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 10:47 [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource Bjorn Andersson
2017-01-19 10:47 ` [PATCH 2/4] phy: qcom-ufs: Correct usage of regulator_get() Bjorn Andersson
2017-01-19 19:33 ` vivek.gautam
2017-01-20 22:50 ` Subhash Jadavani
2017-01-19 10:47 ` [PATCH 3/4] phy: qcom-ufs: Remove -always-on property Bjorn Andersson
2017-01-19 19:39 ` Vivek Gautam
[not found] ` <20170119104739.4376-3-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-20 22:53 ` Subhash Jadavani
2017-01-20 22:53 ` Subhash Jadavani
2017-01-21 20:43 ` Rob Herring [this message]
2017-01-21 20:43 ` Rob Herring
2017-01-19 10:47 ` [PATCH 4/4] phy: qcom-ufs: Suppress extraneous logging Bjorn Andersson
2017-01-19 20:07 ` Vivek Gautam
2017-01-20 22:54 ` Subhash Jadavani
2017-01-19 20:09 ` [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource Vivek Gautam
2017-01-20 20:10 ` Subhash Jadavani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170121204302.ek2oovgay5odhdi3@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.