* [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code
@ 2017-01-23 7:09 ` Jisheng Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2017-01-23 7:09 UTC (permalink / raw)
To: Peter.Chen, gregkh
Cc: linux-usb, linux-kernel, linux-arm-kernel, Jisheng Zhang
Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the
redundant setting default DMA mask code"), the ci_hdrc_usb2 platform
device is also created by device tree, the default DMA mask should be
already set by of_dma_configure when the device are created. So delete
the redundant code at driver.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
index 4456d2cf80ff..d162cc0bb8ce 100644
--- a/drivers/usb/chipidea/ci_hdrc_usb2.c
+++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
@@ -74,10 +74,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
}
}
- ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
- if (ret)
- goto clk_err;
-
ci_pdata->name = dev_name(dev);
priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code
@ 2017-01-23 7:09 ` Jisheng Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2017-01-23 7:09 UTC (permalink / raw)
To: linux-arm-kernel
Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the
redundant setting default DMA mask code"), the ci_hdrc_usb2 platform
device is also created by device tree, the default DMA mask should be
already set by of_dma_configure when the device are created. So delete
the redundant code at driver.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
index 4456d2cf80ff..d162cc0bb8ce 100644
--- a/drivers/usb/chipidea/ci_hdrc_usb2.c
+++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
@@ -74,10 +74,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
}
}
- ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
- if (ret)
- goto clk_err;
-
ci_pdata->name = dev_name(dev);
priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code
2017-01-23 7:09 ` Jisheng Zhang
@ 2017-01-23 9:04 ` Peter Chen
-1 siblings, 0 replies; 4+ messages in thread
From: Peter Chen @ 2017-01-23 9:04 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Peter.Chen, gregkh, linux-usb, linux-kernel, linux-arm-kernel
On Mon, Jan 23, 2017 at 03:09:23PM +0800, Jisheng Zhang wrote:
> Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the
> redundant setting default DMA mask code"), the ci_hdrc_usb2 platform
> device is also created by device tree, the default DMA mask should be
> already set by of_dma_configure when the device are created. So delete
> the redundant code at driver.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
> index 4456d2cf80ff..d162cc0bb8ce 100644
> --- a/drivers/usb/chipidea/ci_hdrc_usb2.c
> +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
> @@ -74,10 +74,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
> }
> }
>
> - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
> - if (ret)
> - goto clk_err;
> -
> ci_pdata->name = dev_name(dev);
>
> priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource,
Applied, thanks.
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code
@ 2017-01-23 9:04 ` Peter Chen
0 siblings, 0 replies; 4+ messages in thread
From: Peter Chen @ 2017-01-23 9:04 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 23, 2017 at 03:09:23PM +0800, Jisheng Zhang wrote:
> Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the
> redundant setting default DMA mask code"), the ci_hdrc_usb2 platform
> device is also created by device tree, the default DMA mask should be
> already set by of_dma_configure when the device are created. So delete
> the redundant code at driver.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
> index 4456d2cf80ff..d162cc0bb8ce 100644
> --- a/drivers/usb/chipidea/ci_hdrc_usb2.c
> +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
> @@ -74,10 +74,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
> }
> }
>
> - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
> - if (ret)
> - goto clk_err;
> -
> ci_pdata->name = dev_name(dev);
>
> priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource,
Applied, thanks.
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-23 9:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23 7:09 [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code Jisheng Zhang
2017-01-23 7:09 ` Jisheng Zhang
2017-01-23 9:04 ` Peter Chen
2017-01-23 9:04 ` Peter Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.