All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [linux-sunxi] Re: [PATCH 02/12] sunxi: simplify ACTLR.SMP bit set #ifdef
Date: Mon, 23 Jan 2017 10:55:45 +0100	[thread overview]
Message-ID: <20170123095545.r2hhpipg2bngrk75@lukather> (raw)
In-Reply-To: <13a5b049-d5aa-738a-a514-d252b068741c@arm.com>

On Sun, Jan 22, 2017 at 01:06:47AM +0000, Andr? Przywara wrote:
> > If we still needs it,
> 
> First: we definitely need this symbol, since it guards an implementation
> defined register and the Cortex-A53 does not define it. So we have to
> confine its use to the ARMv7 Cortex CPUs.

Ack.

> > x86 has a CONFIG_SMP symbol, that would be
> > better to just leverage that.
> 
> Sounds tempting, but this seems to be a generic symbol that enables SMP
> support _within_ U-Boot, so it allows multiple cores to execute U-Boot
> code. This is clearly not what we want. Defining it seems to enable
> architecture specific and generic code paths in U-Boot.
> 
> I can rename this symbol if that helps to avoid confusion, for instance
> to read CONFIG_SUNXI_NO_ACTLR_SMP or to CONFIG_CPU_IS_NOT_SMP or
> CONFIG_CPU_IS_UP.

There's nothing sunxi specific about it, the last one is better imho.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170123/b8be54b0/attachment.sig>

  reply	other threads:[~2017-01-23  9:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  1:29 [U-Boot] [PATCH 00/12] sunxi: Allwinner H5 and OrangePi PC2 support Andre Przywara
2017-01-13  1:29 ` [U-Boot] [PATCH 01/12] sunxi: fix ACTLR.SMP assembly routine Andre Przywara
2017-01-16  7:42   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 02/12] sunxi: simplify ACTLR.SMP bit set #ifdef Andre Przywara
2017-01-13  4:41   ` Icenowy Zheng
2017-01-13  8:09     ` [U-Boot] [linux-sunxi] " Vishnu Patekar
2017-01-13  8:28       ` André Przywara
2017-01-16  7:44         ` Maxime Ripard
2017-01-22  1:06           ` André Przywara
2017-01-23  9:55             ` Maxime Ripard [this message]
2017-01-13  8:20     ` [U-Boot] " André Przywara
2017-01-13  1:29 ` [U-Boot] [PATCH 03/12] sunxi: configs: merge sun9i and sun50i SPL memory definitions Andre Przywara
2017-01-16  7:45   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 04/12] sunxi: Kconfig: introduce CONFIG_SUNXI_HIGH_SRAM Andre Przywara
2017-01-16  7:46   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 05/12] sunxi: provide ARMv8 mem_map for every ARM64 board Andre Przywara
2017-01-16  7:47   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 06/12] SPI: SPL: sunxi: fix 64-bit build Andre Przywara
2017-01-15 12:17   ` Rask Ingemann Lambertsen
2017-01-19 13:57     ` Simon Glass
2017-01-13  1:29 ` [U-Boot] [PATCH 07/12] sunxi: DRAM: add Allwinner H5 support Andre Przywara
2017-01-16  7:56   ` Maxime Ripard
2017-01-13  1:30 ` [U-Boot] [PATCH 08/12] sunxi: prepare for sharing MACH_SUN8I_H3 config symbol Andre Przywara
2017-01-16  7:59   ` Maxime Ripard
2017-01-22  1:06     ` André Przywara
2017-01-13  1:30 ` [U-Boot] [PATCH 09/12] sunxi: H5: add COUNTER_FREQUENCY Andre Przywara
2017-01-16  8:01   ` Maxime Ripard
2017-01-22  1:06     ` André Przywara
2017-01-13  1:30 ` [U-Boot] [PATCH 10/12] sunxi: introduce Allwinner H5 config option Andre Przywara
2017-01-13  1:30 ` [U-Boot] [PATCH 11/12] sunxi: dts: add basic OrangePi PC 2 device tree file Andre Przywara
2017-01-13  1:30 ` [U-Boot] [PATCH 12/12] sunxi: configs: add basic OrangePi PC 2 defconfig Andre Przywara
2017-01-13  4:39 ` [U-Boot] [PATCH 00/12] sunxi: Allwinner H5 and OrangePi PC2 support Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123095545.r2hhpipg2bngrk75@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.