All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Przywara" <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/12] sunxi: H5: add COUNTER_FREQUENCY
Date: Sun, 22 Jan 2017 01:06:16 +0000	[thread overview]
Message-ID: <305d18e5-7d9b-5aa5-19fd-5b5e51f53a2f@arm.com> (raw)
In-Reply-To: <20170116080125.etvagx4osav44psy@lukather>

Hi,

On 16/01/17 08:01, Maxime Ripard wrote:
> On Fri, Jan 13, 2017 at 01:30:01AM +0000, Andre Przywara wrote:
>> For the arch timer to work properly, we need to setup the CNTFRQ
>> register, which is only possible in EL3.
>> Define the arch timer frequency in sun8i.h as well, so that ARMv8's
>> start.S can program the register correctly.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>>  include/configs/sun8i.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/configs/sun8i.h b/include/configs/sun8i.h
>> index a4c3fb6..cbb7239 100644
>> --- a/include/configs/sun8i.h
>> +++ b/include/configs/sun8i.h
>> @@ -13,6 +13,8 @@
>>   * A23 specific configuration
>>   */
>>  
>> +#define COUNTER_FREQUENCY		CONFIG_TIMER_CLK_FREQ
>> +
> 
> Why not convert the armv8 code to use CONFIG_TIMER_CLK_FREQ, or armv7
> to use COUNTER_FREQUENCY?
> 
> The both options seem redundant.

Good point, they indeed are.
So I will drop this patch here and instead have a new one to rename the
v7 users over to use COUNTER_FREQUENCY.
I chose COUNTER_FREQUENCY because the other symbol has less users.

Thanks for the idea!

Cheers,
Andre.

  reply	other threads:[~2017-01-22  1:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  1:29 [U-Boot] [PATCH 00/12] sunxi: Allwinner H5 and OrangePi PC2 support Andre Przywara
2017-01-13  1:29 ` [U-Boot] [PATCH 01/12] sunxi: fix ACTLR.SMP assembly routine Andre Przywara
2017-01-16  7:42   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 02/12] sunxi: simplify ACTLR.SMP bit set #ifdef Andre Przywara
2017-01-13  4:41   ` Icenowy Zheng
2017-01-13  8:09     ` [U-Boot] [linux-sunxi] " Vishnu Patekar
2017-01-13  8:28       ` André Przywara
2017-01-16  7:44         ` Maxime Ripard
2017-01-22  1:06           ` André Przywara
2017-01-23  9:55             ` Maxime Ripard
2017-01-13  8:20     ` [U-Boot] " André Przywara
2017-01-13  1:29 ` [U-Boot] [PATCH 03/12] sunxi: configs: merge sun9i and sun50i SPL memory definitions Andre Przywara
2017-01-16  7:45   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 04/12] sunxi: Kconfig: introduce CONFIG_SUNXI_HIGH_SRAM Andre Przywara
2017-01-16  7:46   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 05/12] sunxi: provide ARMv8 mem_map for every ARM64 board Andre Przywara
2017-01-16  7:47   ` Maxime Ripard
2017-01-13  1:29 ` [U-Boot] [PATCH 06/12] SPI: SPL: sunxi: fix 64-bit build Andre Przywara
2017-01-15 12:17   ` Rask Ingemann Lambertsen
2017-01-19 13:57     ` Simon Glass
2017-01-13  1:29 ` [U-Boot] [PATCH 07/12] sunxi: DRAM: add Allwinner H5 support Andre Przywara
2017-01-16  7:56   ` Maxime Ripard
2017-01-13  1:30 ` [U-Boot] [PATCH 08/12] sunxi: prepare for sharing MACH_SUN8I_H3 config symbol Andre Przywara
2017-01-16  7:59   ` Maxime Ripard
2017-01-22  1:06     ` André Przywara
2017-01-13  1:30 ` [U-Boot] [PATCH 09/12] sunxi: H5: add COUNTER_FREQUENCY Andre Przywara
2017-01-16  8:01   ` Maxime Ripard
2017-01-22  1:06     ` André Przywara [this message]
2017-01-13  1:30 ` [U-Boot] [PATCH 10/12] sunxi: introduce Allwinner H5 config option Andre Przywara
2017-01-13  1:30 ` [U-Boot] [PATCH 11/12] sunxi: dts: add basic OrangePi PC 2 device tree file Andre Przywara
2017-01-13  1:30 ` [U-Boot] [PATCH 12/12] sunxi: configs: add basic OrangePi PC 2 defconfig Andre Przywara
2017-01-13  4:39 ` [U-Boot] [PATCH 00/12] sunxi: Allwinner H5 and OrangePi PC2 support Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=305d18e5-7d9b-5aa5-19fd-5b5e51f53a2f@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.