All of lore.kernel.org
 help / color / mirror / Atom feed
* net: dsa: remaining references on NET_DSA_HWMON
@ 2017-01-23  9:31 Valentin Rothberg
  2017-01-23 15:13 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Valentin Rothberg @ 2017-01-23  9:31 UTC (permalink / raw)
  To: andrew; +Cc: davem, LKML

Hi Andrew,

your commit cf1a56a4cf19 ("net: dsa: Remove hwmon support") has popped
up in today's linux-next.  The commit removes all references on
NET_DSA_HWMON but the following:

Documentation/networking/dsa/dsa.txt:501:These callbacks are only
available if CONFIG_NET_DSA_HWMON is enabled:

include/net/dsa.h:181:#ifdef CONFIG_NET_DSA_HWMON

Is it on purpose?

Best regards,
 Valentin

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: net: dsa: remaining references on NET_DSA_HWMON
  2017-01-23  9:31 net: dsa: remaining references on NET_DSA_HWMON Valentin Rothberg
@ 2017-01-23 15:13 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2017-01-23 15:13 UTC (permalink / raw)
  To: Valentin Rothberg; +Cc: davem, LKML

On Mon, Jan 23, 2017 at 10:31:12AM +0100, Valentin Rothberg wrote:
> Hi Andrew,
> 
> your commit cf1a56a4cf19 ("net: dsa: Remove hwmon support") has popped
> up in today's linux-next.  The commit removes all references on
> NET_DSA_HWMON but the following:
> 
> Documentation/networking/dsa/dsa.txt:501:These callbacks are only
> available if CONFIG_NET_DSA_HWMON is enabled:
> 
> include/net/dsa.h:181:#ifdef CONFIG_NET_DSA_HWMON
> 
> Is it on purpose?

Hi Valentin

Nope, those should be cleaned up as well.

Thanks for pointing this out.

       Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-23 15:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23  9:31 net: dsa: remaining references on NET_DSA_HWMON Valentin Rothberg
2017-01-23 15:13 ` Andrew Lunn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.