From: Bart Van Assche <bart.vanassche@sandisk.com> To: "Martin K . Petersen" <martin.petersen@oracle.com> Cc: <linux-scsi@vger.kernel.org>, Bart Van Assche <bart.vanassche@sandisk.com>, Naresh Bannoth <nbannoth@in.ibm.com>, "Mauricio Faria de Oliveira" <mauricfo@linux.vnet.ibm.com>, Himanshu Madhani <himanshu.madhani@cavium.com>, <stable@vger.kernel.org> Subject: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash Date: Mon, 23 Jan 2017 08:34:46 -0800 [thread overview] Message-ID: <20170123163446.9227-3-bart.vanassche@sandisk.com> (raw) In-Reply-To: <20170123163446.9227-1-bart.vanassche@sandisk.com> Avoid that issuing a LIP as follows: find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done triggers the following: BUG: unable to handle kernel NULL pointer dereference at (null) Call Trace: qla2x00_abort_all_cmds+0xed/0x140 [qla2xxx] qla2x00_abort_isp_cleanup+0x1e3/0x280 [qla2xxx] qla2x00_abort_isp+0xef/0x690 [qla2xxx] qla2x00_do_dpc+0x36c/0x880 [qla2xxx] kthread+0x10c/0x140 Fixes: 1535aa75a3d8 ("qla2xxx: fix invalid DMA access after command aborts in PCI device remove") Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Naresh Bannoth <nbannoth@in.ibm.com> Cc: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> Cc: Himanshu Madhani <himanshu.madhani@cavium.com> Cc: <stable@vger.kernel.org> --- drivers/scsi/qla2xxx/qla_os.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 0a000ecf0881..ae9c5a7b239a 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1600,6 +1600,7 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) srb_t *sp; struct qla_hw_data *ha = vha->hw; struct req_que *req; + struct scsi_cmnd *scmd; qlt_host_reset_handler(ha); @@ -1613,6 +1614,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) for (cnt = 1; cnt < req->num_outstanding_cmds; cnt++) { sp = req->outstanding_cmds[cnt]; if (sp) { + scmd = GET_CMD_SP(sp); + /* Don't abort commands in adapter during EEH * recovery as it's not accessible/responding. */ @@ -1624,7 +1627,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) */ sp_get(sp); spin_unlock_irqrestore(&ha->hardware_lock, flags); - qla2xxx_eh_abort(GET_CMD_SP(sp)); + if (scmd) + qla2xxx_eh_abort(scmd); spin_lock_irqsave(&ha->hardware_lock, flags); } req->outstanding_cmds[cnt] = NULL; -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com> To: "Martin K . Petersen" <martin.petersen@oracle.com> Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bart.vanassche@sandisk.com>, Naresh Bannoth <nbannoth@in.ibm.com>, Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>, Himanshu Madhani <himanshu.madhani@cavium.com>, stable@vger.kernel.org Subject: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash Date: Mon, 23 Jan 2017 08:34:46 -0800 [thread overview] Message-ID: <20170123163446.9227-3-bart.vanassche@sandisk.com> (raw) In-Reply-To: <20170123163446.9227-1-bart.vanassche@sandisk.com> Avoid that issuing a LIP as follows: find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done triggers the following: BUG: unable to handle kernel NULL pointer dereference at (null) Call Trace: qla2x00_abort_all_cmds+0xed/0x140 [qla2xxx] qla2x00_abort_isp_cleanup+0x1e3/0x280 [qla2xxx] qla2x00_abort_isp+0xef/0x690 [qla2xxx] qla2x00_do_dpc+0x36c/0x880 [qla2xxx] kthread+0x10c/0x140 Fixes: 1535aa75a3d8 ("qla2xxx: fix invalid DMA access after command aborts in PCI device remove") Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Naresh Bannoth <nbannoth@in.ibm.com> Cc: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> Cc: Himanshu Madhani <himanshu.madhani@cavium.com> Cc: <stable@vger.kernel.org> --- drivers/scsi/qla2xxx/qla_os.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 0a000ecf0881..ae9c5a7b239a 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1600,6 +1600,7 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) srb_t *sp; struct qla_hw_data *ha = vha->hw; struct req_que *req; + struct scsi_cmnd *scmd; qlt_host_reset_handler(ha); @@ -1613,6 +1614,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) for (cnt = 1; cnt < req->num_outstanding_cmds; cnt++) { sp = req->outstanding_cmds[cnt]; if (sp) { + scmd = GET_CMD_SP(sp); + /* Don't abort commands in adapter during EEH * recovery as it's not accessible/responding. */ @@ -1624,7 +1627,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) */ sp_get(sp); spin_unlock_irqrestore(&ha->hardware_lock, flags); - qla2xxx_eh_abort(GET_CMD_SP(sp)); + if (scmd) + qla2xxx_eh_abort(scmd); spin_lock_irqsave(&ha->hardware_lock, flags); } req->outstanding_cmds[cnt] = NULL; -- 2.11.0
next prev parent reply other threads:[~2017-01-23 16:34 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-23 16:34 [PATCH 0/2] qla2xxx: Two bug fixes Bart Van Assche 2017-01-23 16:34 ` [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak Bart Van Assche 2017-01-23 16:34 ` Bart Van Assche 2017-01-23 16:45 ` Christoph Hellwig 2017-01-23 17:04 ` Madhani, Himanshu 2017-01-24 12:10 ` Johannes Thumshirn 2017-01-24 12:10 ` Johannes Thumshirn 2017-01-25 15:47 ` Bart Van Assche 2017-01-26 14:36 ` hch 2017-01-29 5:17 ` Bart Van Assche 2017-01-29 9:07 ` hch 2017-01-29 17:14 ` Bart Van Assche 2017-01-25 23:28 ` Martin K. Petersen 2017-01-25 23:28 ` Martin K. Petersen 2017-02-03 16:59 ` Bart Van Assche 2017-02-07 0:23 ` Martin K. Petersen 2017-01-23 16:34 ` Bart Van Assche [this message] 2017-01-23 16:34 ` [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash Bart Van Assche 2017-01-23 17:41 ` Madhani, Himanshu 2017-01-24 12:12 ` Johannes Thumshirn 2017-01-24 12:12 ` Johannes Thumshirn 2017-01-24 14:59 ` Mauricio Faria de Oliveira 2017-01-25 22:05 ` Madhani, Himanshu 2017-01-25 23:29 ` Martin K. Petersen 2017-01-26 0:09 ` Mauricio Faria de Oliveira
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170123163446.9227-3-bart.vanassche@sandisk.com \ --to=bart.vanassche@sandisk.com \ --cc=himanshu.madhani@cavium.com \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=mauricfo@linux.vnet.ibm.com \ --cc=nbannoth@in.ibm.com \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.