* [PATCH] btrfs-progs: sanitize - Use correct source for memcpy
@ 2017-01-20 19:03 Goldwyn Rodrigues
2017-01-23 17:11 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Goldwyn Rodrigues @ 2017-01-20 19:03 UTC (permalink / raw)
To: linux-btrfs; +Cc: Goldwyn Rodrigues
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
While performing a memcpy, we are copying from uninitialized dst
as opposed to src->data. Though using eb->len is correct, I used
src->len to make it more readable.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
image/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/image/main.c b/image/main.c
index 58dcecb..0158844 100644
--- a/image/main.c
+++ b/image/main.c
@@ -550,7 +550,7 @@ static void sanitize_name(struct metadump_struct *md, u8 *dst,
return;
}
- memcpy(eb->data, dst, eb->len);
+ memcpy(eb->data, src->data, src->len);
switch (key->type) {
case BTRFS_DIR_ITEM_KEY:
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs-progs: sanitize - Use correct source for memcpy
2017-01-20 19:03 [PATCH] btrfs-progs: sanitize - Use correct source for memcpy Goldwyn Rodrigues
@ 2017-01-23 17:11 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-01-23 17:11 UTC (permalink / raw)
To: Goldwyn Rodrigues; +Cc: linux-btrfs, Goldwyn Rodrigues
On Fri, Jan 20, 2017 at 01:03:33PM -0600, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> While performing a memcpy, we are copying from uninitialized dst
> as opposed to src->data. Though using eb->len is correct, I used
> src->len to make it more readable.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-23 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-20 19:03 [PATCH] btrfs-progs: sanitize - Use correct source for memcpy Goldwyn Rodrigues
2017-01-23 17:11 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.