[U-Boot] [PATCH] arm: dts: imx53-cx9020: fix packetloss on fec_mxc

[U-Boot] [PATCH] arm: dts: imx53-cx9020: fix packetloss on fec_mxc

[linux-kernel-dev at beckhoff.com]

From: Patrick Bruenn <p.bruenn@beckhoff.com>

The pinmuxing for i.MX53 FEC ethernet copied from
<kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9)
was bad. It is different from the manual pinmuxing in
<u-boot>/board/freescale/mx53loco/mx53loco.c which was used in
cx9020 implementation previously before mainlining into u-boot.
It seems the bug in imx53-qsb kernel device tree is hidden for so long,
because it was never used, by the kernel driver.

Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
---

 arch/arm/dts/imx53-cx9020.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/dts/imx53-cx9020.dts b/arch/arm/dts/imx53-cx9020.dts
index 9610301..c928e72 100644
--- a/arch/arm/dts/imx53-cx9020.dts
+++ b/arch/arm/dts/imx53-cx9020.dts
@@ -114,16 +114,16 @@
 				MX53_PAD_SD2_CMD__ESDHC2_CMD		0x1d5
 				MX53_PAD_SD2_CLK__ESDHC2_CLK		0x1d5
 
-				MX53_PAD_FEC_MDC__FEC_MDC		0x80000000
-				MX53_PAD_FEC_MDIO__FEC_MDIO		0x80000000
-				MX53_PAD_FEC_REF_CLK__FEC_TX_CLK	0x80000000
-				MX53_PAD_FEC_RX_ER__FEC_RX_ER		0x80000000
-				MX53_PAD_FEC_CRS_DV__FEC_RX_DV		0x80000000
-				MX53_PAD_FEC_RXD1__FEC_RDATA_1		0x80000000
-				MX53_PAD_FEC_RXD0__FEC_RDATA_0		0x80000000
-				MX53_PAD_FEC_TX_EN__FEC_TX_EN		0x80000000
-				MX53_PAD_FEC_TXD1__FEC_TDATA_1		0x80000000
-				MX53_PAD_FEC_TXD0__FEC_TDATA_0		0x80000000
+				MX53_PAD_FEC_MDC__FEC_MDC		0x4
+				MX53_PAD_FEC_MDIO__FEC_MDIO		0x1fc
+				MX53_PAD_FEC_REF_CLK__FEC_TX_CLK	0x180
+				MX53_PAD_FEC_RX_ER__FEC_RX_ER		0x180
+				MX53_PAD_FEC_CRS_DV__FEC_RX_DV		0x180
+				MX53_PAD_FEC_RXD1__FEC_RDATA_1		0x180
+				MX53_PAD_FEC_RXD0__FEC_RDATA_0		0x180
+				MX53_PAD_FEC_TX_EN__FEC_TX_EN		0x4
+				MX53_PAD_FEC_TXD1__FEC_TDATA_1		0x4
+				MX53_PAD_FEC_TXD0__FEC_TDATA_0		0x4
 
 				MX53_PAD_CSI0_DAT8__I2C1_SDA		0x400001ec
 				MX53_PAD_CSI0_DAT9__I2C1_SCL		0x400001ec
-- 
2.7.4

[U-Boot] [PATCH] arm: dts: imx53-cx9020: fix packetloss on fec_mxc

[Tom Rini]

On Mon, Jan 23, 2017 at 03:11:27PM +0100, linux-kernel-dev at beckhoff.com wrote:

> From: Patrick Bruenn <p.bruenn@beckhoff.com>
> 
> The pinmuxing for i.MX53 FEC ethernet copied from
> <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9)
> was bad. It is different from the manual pinmuxing in
> <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in
> cx9020 implementation previously before mainlining into u-boot.
> It seems the bug in imx53-qsb kernel device tree is hidden for so long,
> because it was never used, by the kernel driver.
> 
> Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>

So in other words, the dts file is correct in current mainline kernel?
Or still pending?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170123/350de686/attachment.sig>

[U-Boot] [PATCH] arm: dts: imx53-cx9020: fix packetloss on fec_mxc

[linux-kernel-dev]

>From: Tom Rini [mailto:trini at konsulko.com]
>Sent: Montag, 23. Januar 2017 16:31
>
>On Mon, Jan 23, 2017 at 03:11:27PM +0100, linux-kernel-dev at beckhoff.com
>wrote:
>
>> From: Patrick Bruenn <p.bruenn@beckhoff.com>
>>
>> The pinmuxing for i.MX53 FEC ethernet copied from
>> <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9)
>> was bad. It is different from the manual pinmuxing in
>> <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in
>> cx9020 implementation previously before mainlining into u-boot.
>> It seems the bug in imx53-qsb kernel device tree is hidden for so long,
>> because it was never used, by the kernel driver.
>>
>> Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
>
>So in other words, the dts file is correct in current mainline kernel?
>Or still pending?  Thanks!
Sorry, no it is still pending. I just reported it to the kernel maintainers:
https://mail-archive.com/linux-kernel at vger.kernel.org/msg1316717.html

Patrick

[U-Boot] [PATCH] arm: dts: imx53-cx9020: fix packetloss on fec_mxc

[Tom Rini]

On Mon, Jan 23, 2017 at 05:20:25PM +0000, linux-kernel-dev wrote:
> >From: Tom Rini [mailto:trini at konsulko.com]
> >Sent: Montag, 23. Januar 2017 16:31
> >
> >On Mon, Jan 23, 2017 at 03:11:27PM +0100, linux-kernel-dev at beckhoff.com
> >wrote:
> >
> >> From: Patrick Bruenn <p.bruenn@beckhoff.com>
> >>
> >> The pinmuxing for i.MX53 FEC ethernet copied from
> >> <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9)
> >> was bad. It is different from the manual pinmuxing in
> >> <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in
> >> cx9020 implementation previously before mainlining into u-boot.
> >> It seems the bug in imx53-qsb kernel device tree is hidden for so long,
> >> because it was never used, by the kernel driver.
> >>
> >> Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
> >
> >So in other words, the dts file is correct in current mainline kernel?
> >Or still pending?  Thanks!
> Sorry, no it is still pending. I just reported it to the kernel maintainers:
> https://mail-archive.com/linux-kernel at vger.kernel.org/msg1316717.html

Ah, OK.  I think we want get this in the release, but it can wait for
-rc3 or so, unless it gets ack'ed by the kernel folks sooner.  Please
keep us apprised, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170123/4406c1bf/attachment.sig>

[U-Boot] [PATCH] arm: dts: imx53-cx9020: fix packetloss on fec_mxc

[Stefano Babic]

On 23/01/2017 18:45, Tom Rini wrote:
> On Mon, Jan 23, 2017 at 05:20:25PM +0000, linux-kernel-dev wrote:
>>> From: Tom Rini [mailto:trini at konsulko.com]
>>> Sent: Montag, 23. Januar 2017 16:31
>>>
>>> On Mon, Jan 23, 2017 at 03:11:27PM +0100, linux-kernel-dev at beckhoff.com
>>> wrote:
>>>
>>>> From: Patrick Bruenn <p.bruenn@beckhoff.com>
>>>>
>>>> The pinmuxing for i.MX53 FEC ethernet copied from
>>>> <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9)
>>>> was bad. It is different from the manual pinmuxing in
>>>> <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in
>>>> cx9020 implementation previously before mainlining into u-boot.
>>>> It seems the bug in imx53-qsb kernel device tree is hidden for so long,
>>>> because it was never used, by the kernel driver.
>>>>
>>>> Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
>>>
>>> So in other words, the dts file is correct in current mainline kernel?
>>> Or still pending?  Thanks!
>> Sorry, no it is still pending. I just reported it to the kernel maintainers:
>> https://mail-archive.com/linux-kernel at vger.kernel.org/msg1316717.html
> 
> Ah, OK.  I think we want get this in the release, but it can wait for
> -rc3 or so, unless it gets ack'ed by the kernel folks sooner.  Please
> keep us apprised, thanks!
>

I saw patch was integrated in kernel - I merge this as well in u-boot-imx.

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================