All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>, Jiri Olsa <jolsa@kernel.org>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 4/5] perf, tools, script: Add support for printing assembler
Date: Mon, 23 Jan 2017 11:55:21 -0800	[thread overview]
Message-ID: <20170123195521.GP26852@two.firstfloor.org> (raw)
In-Reply-To: <20170123194907.GA10340@kernel.org>

> Do you know if there is any tool comparing the output of objdump -d to what is
> produced by a similar xed based tool?

I'm not aware of such a tool, but could be written using the "xed" tool
in the xed distribution. However I would trust xed over objdump,
it is used widely in Intel tools with likely far more testing
than binutils

>   4b8506  jz 0x4b84d0 <perf_evsel__enable+0x70>      74 c8                 je     4b84d0 <perf_evsel__enable+0x70>
>   4b84d0  add $0x1, %r14                                                   add    $0x1,%r14
>   4b84d4  cmp %r14d, %ebx                                                  cmp    %r14d,%ebx
>   4b84d7  jle 0x4b8530 <perf_evsel__enable+0xd0>                           jle    4b8530 <perf_evsel__enable+0xd0>
>   4b8530  add $0x1, %r12                                                   add    $0x1,%r12
>   4b8534  cmp %r12d, %r13d                                                 cmp    %r12d,%r13d
>   4b8537  jnle 0x4b84c2 <perf_evsel__enable+0x62>    7f 89                 jg     4b84c2 <perf_evsel__enable+0x62>
>   4b84c2  xor %r14d, %r14d                                                 xor    %r14d,%r14d
>   4b84c5  test %ebx, %ebx                                                  test   %ebx,%ebx
>   4b84c7  jnle 0x4b84d9 <perf_evsel__enable+0x79>    7f 10                 jg     4b84d9 <perf_evsel__enable+0x79>
>   4b84d9  movq  0x90(%r15), %rax                     49 8b 87 90 00 00 00  mov    0x90(%r15),%rax
>   4b84e0  mov %r12, %rdx                                                   mov    %r12,%rdx
>   4b84e3  mov %r14, %rcx                                                   mov    %r14,%rcx
>   4b84e6  mov $0x2400, %esi                                                mov    $0x2400,%esi
>   4b84eb  imulq  (%rax), %rdx                        48 0f af 10           imul   (%rax),%rdx
>   4b84ef  imulq  0x8(%rax), %rcx                     48 0f af 48 08        imul   0x8(%rax),%rcx
>   4b84f4  add %rdx, %rax                                                   add    %rdx,%rax
>   4b84f7  xor %edx, %edx                                                   xor    %edx,%edx
>   4b84f9  movl  0x18(%rcx,%rax,1), %edi              8b 7c 01 18           mov    0x18(%rcx,%rax,1),%edi
>   4b84fd  xor %eax, %eax                                                   xor    %eax,%eax
>   4b84ff  callq  0x42d990 <ioctl@plt>                                      callq  42d990 <ioctl@plt>
>   4b8504  test %eax, %eax                                                  test   %eax,%eax
>   4b8506  jz 0x4b84d0 <perf_evsel__enable+0x70>      74 c8                 je     4b84d0 <perf_evsel__enable+0x70>

Yes all the differences are ok. It's just synonyms of the instructions.

-Andi

  reply	other threads:[~2017-01-23 19:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  1:41 New attempt at adding an disassembler to perf Andi Kleen
2017-01-19  1:41 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
2017-01-19  1:41 ` [PATCH 2/5] perf, tools: Add one liner warning for disabled features Andi Kleen
2017-01-19  1:41 ` [PATCH 3/5] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-19  1:41 ` [PATCH 4/5] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-23 19:49   ` Arnaldo Carvalho de Melo
2017-01-23 19:55     ` Andi Kleen [this message]
2017-01-23 20:06       ` Arnaldo Carvalho de Melo
2017-01-19  1:41 ` [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-24 18:54   ` Arnaldo Carvalho de Melo
2017-01-19 15:36 ` New attempt at adding an disassembler to perf Jiri Olsa
2017-01-19 16:54   ` Andi Kleen
2017-01-20 13:22 ` Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2017-01-10  1:02 New attempt at adding an disassembler to perf v2 Andi Kleen
2017-01-10  1:02 ` [PATCH 4/5] perf, tools, script: Add support for printing assembler Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123195521.GP26852@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.