libibverbs changes broke usnic libfabric provider

libibverbs changes broke usnic libfabric provider

[Hefty, Sean]

I was notified of the following bug, which is a break in the libfabric build:


http://bugs.openfabrics.org/show_bug.cgi?id=2614

           Summary: Build break when building "libfabric" package using
                    OFED-4.8-20170123-0458  on RHEL 7.3 LE on Power8 box
           Product: OpenFabrics Linux
           Version: 4.8
          Platform: PPC64
        OS/Version: RHEL7.3
            Status: NEW
          Severity: normal
          Priority: P5
         Component: libfabric

...

The /tmp/OFED.3725.logs/libfabric.rpmbuild.log has this error:
prov/usnic/src/usnic_direct/usd_ib_cmd.c: In function 'usd_ib_cmd_modify_qp':
prov/usnic/src/usnic_direct/usd_ib_cmd.c:739:8: error: 'struct ibv_modify_qp'
has no member named 'qp_handle'
     icp->qp_handle = qp->uq_qp_handle;
        ^
prov/usnic/src/usnic_direct/usd_ib_cmd.c:740:8: error: 'struct ibv_modify_qp'
has no member named 'attr_mask'
     icp->attr_mask = IBV_QP_STATE;
        ^
prov/usnic/src/usnic_direct/usd_ib_cmd.c:741:8: error: 'struct ibv_modify_qp'
has no member named 'qp_state'
     icp->qp_state = state;
        ^
make[1]: *** [prov/usnic/src/usnic_direct/src_libfabric_la-usd_ib_cmd.lo] Error 
1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/OFED_topdir/BUILD/libfabric-1.3.0'


This results from recent changes to kern-abi.h.  :/

Jeff, I'm not sure how you want to fix this.  Do you need libibverbs installed, or just the header files?  If just the latter, you may want to use a private copy, since compatibility won't be guaranteed anymore.

Re: libibverbs changes broke usnic libfabric provider

[Jason Gunthorpe]

On Mon, Jan 23, 2017 at 10:24:52PM +0000, Hefty, Sean wrote:

> prov/usnic/src/usnic_direct/usd_ib_cmd.c: In function 'usd_ib_cmd_modify_qp':
> prov/usnic/src/usnic_direct/usd_ib_cmd.c:739:8: error: 'struct ibv_modify_qp'
> has no member named 'qp_handle'
>      icp->qp_handle = qp->uq_qp_handle;
>         ^
> prov/usnic/src/usnic_direct/usd_ib_cmd.c:740:8: error: 'struct ibv_modify_qp'
> has no member named 'attr_mask'
>      icp->attr_mask = IBV_QP_STATE;
>         ^
> prov/usnic/src/usnic_direct/usd_ib_cmd.c:741:8: error: 'struct ibv_modify_qp'
> has no member named 'qp_state'
>      icp->qp_state = state;
>         ^
> make[1]: *** [prov/usnic/src/usnic_direct/src_libfabric_la-usd_ib_cmd.lo] Error 
> 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory `/var/tmp/OFED_topdir/BUILD/libfabric-1.3.0'
> 
> 
> This results from recent changes to kern-abi.h.  :/

FWIW, there was a decision to stop supporting out of tree drivers and
so ther drive API and ABI is now considered internal to
rdma-core. Plan for kern-abi.h and related to go away someday.

It doesn't look like usd_ib_cmd.c is using the libibverbs driver API
so it should use the kernel header /usr/include/rdma/ib_user_verbs.h,
not the libibverbs header.

> Jeff, I'm not sure how you want to fix this.  Do you need libibverbs
> installed, or just the header files?  If just the latter, you may
> want to use a private copy, since compatibility won't be guaranteed
> anymore.

If you copy libibverbs headers then do not link to libibverbs. We
certainly will not support that.

A private copy of the kernel uapi header is OK..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html