* [radeon-alex:drm-next-4.11-wip 131/131] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token
@ 2017-01-23 22:37 kbuild test robot
[not found] ` <201701240656.PoIVchhM%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-01-23 22:37 UTC (permalink / raw)
To: Nils Holland
Cc: Alex Deucher, Michel Dänzer, kbuild-all, dri-devel,
Christian König
[-- Attachment #1: Type: text/plain, Size: 1949 bytes --]
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.11-wip
head: ebe88f26b6161d76f3d74a458bcb19759b15a1b2
commit: ebe88f26b6161d76f3d74a458bcb19759b15a1b2 [131/131] drm/amdgpu: Bring bo creation in line with radeon driver
config: x86_64-randconfig-x019-201704 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout ebe88f26b6161d76f3d74a458bcb19759b15a1b2
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_create_restricted':
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:377:2: warning: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [-Wcpp]
#warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
^~~~~~~
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token
if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
^
vim +380 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
371 #elif defined(CONFIG_X86) && !defined(CONFIG_X86_PAT)
372 /* Don't try to enable write-combining when it can't work, or things
373 * may be slow
374 * See https://bugs.freedesktop.org/show_bug.cgi?id=88758
375 */
376
> 377 #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
378 thanks to write-combining
379
> 380 if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
381 DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for "
382 "better performance thanks to write-combining\n");
383 bo->flags &= ~AMDGPU_GEM_CREATE_CPU_GTT_USWC;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28037 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [radeon-alex:drm-next-4.11-wip 131/131] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token
[not found] ` <201701240656.PoIVchhM%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2017-01-24 0:30 ` Nils Holland
[not found] ` <20170124003039.GA17304-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Nils Holland @ 2017-01-24 0:30 UTC (permalink / raw)
To: kbuild test robot
Cc: Alex Deucher, Michel Dänzer, kbuild-all-JC7UmRfGjtg,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Christian König
On Tue, Jan 24, 2017 at 06:37:58AM +0800, kbuild test robot wrote:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_create_restricted':
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:377:2: warning: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [-Wcpp]
> #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
> ^~~~~~~
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token
> if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
> ^
>
> vim +380 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>
> 371 #elif defined(CONFIG_X86) && !defined(CONFIG_X86_PAT)
> 372 /* Don't try to enable write-combining when it can't work, or things
> 373 * may be slow
> 374 * See https://bugs.freedesktop.org/show_bug.cgi?id=88758
> 375 */
> 376
> > 377 #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
> 378 thanks to write-combining
> 379
> > 380 if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
> 381 DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for "
> 382 "better performance thanks to write-combining\n");
> 383 bo->flags &= ~AMDGPU_GEM_CREATE_CPU_GTT_USWC;
Whoops, the robot is certainly right, there's a ; that doesn't belong
in line 380. Shame on me! :-(
Michel, now that you've already commited this patch, what do I do?
Should I submit another patch that just fixes this one issue, or
should I re-submit the whole patch, in fixed state, as a v2?
Sorry for the hassle! :-/
Greetings
Nils
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [radeon-alex:drm-next-4.11-wip 131/131] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token
[not found] ` <20170124003039.GA17304-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
@ 2017-01-24 14:41 ` Deucher, Alexander
0 siblings, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2017-01-24 14:41 UTC (permalink / raw)
To: 'Nils Holland', kbuild test robot
Cc: Daenzer, Michel, kbuild-all-JC7UmRfGjtg,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Koenig, Christian
> -----Original Message-----
> From: Nils Holland [mailto:nholland@tisys.org]
> Sent: Monday, January 23, 2017 7:31 PM
> To: kbuild test robot
> Cc: kbuild-all@01.org; amd-gfx@lists.freedesktop.org; Deucher, Alexander;
> Daenzer, Michel; Koenig, Christian
> Subject: Re: [radeon-alex:drm-next-4.11-wip 131/131]
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')'
> before ';' token
>
> On Tue, Jan 24, 2017 at 06:37:58AM +0800, kbuild test robot wrote:
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function
> 'amdgpu_bo_create_restricted':
> > >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:377:2: warning:
> #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better
> performance thanks to write-combining [-Wcpp]
> > #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better
> performance \
> > ^~~~~~~
> > >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error:
> expected ')' before ';' token
> > if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
> > ^
> >
> > vim +380 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> >
> > 371 #elif defined(CONFIG_X86) && !defined(CONFIG_X86_PAT)
> > 372 /* Don't try to enable write-combining when it can't work, or
> things
> > 373 * may be slow
> > 374 * See https://bugs.freedesktop.org/show_bug.cgi?id=88758
> > 375 */
> > 376
> > > 377 #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for
> better performance \
> > 378 thanks to write-combining
> > 379
> > > 380 if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
> > 381 DRM_INFO_ONCE("Please enable CONFIG_MTRR
> and CONFIG_X86_PAT for "
> > 382 "better performance thanks to write-
> combining\n");
> > 383 bo->flags &= ~AMDGPU_GEM_CREATE_CPU_GTT_USWC;
>
> Whoops, the robot is certainly right, there's a ; that doesn't belong
> in line 380. Shame on me! :-(
>
> Michel, now that you've already commited this patch, what do I do?
> Should I submit another patch that just fixes this one issue, or
> should I re-submit the whole patch, in fixed state, as a v2?
>
> Sorry for the hassle! :-/
I fixed this up locally when I committed it. It's already taken care of.
Alex
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-24 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23 22:37 [radeon-alex:drm-next-4.11-wip 131/131] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token kbuild test robot
[not found] ` <201701240656.PoIVchhM%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-24 0:30 ` Nils Holland
[not found] ` <20170124003039.GA17304-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
2017-01-24 14:41 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.