All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ata: pata_of_platform: using of_property_read_u32() helper
@ 2017-01-24 12:08 ` Kefeng Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Kefeng Wang @ 2017-01-24 12:08 UTC (permalink / raw)
  To: Tejun Heo, linux-kernel
  Cc: linux-ide, Kefeng Wang, Bartlomiej Zolnierkiewicz, Hans de Goede

Using better of_property_read_u32() than generic of_get_property().

Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/ata/pata_of_platform.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c
index b6b7af8..201a32d 100644
--- a/drivers/ata/pata_of_platform.c
+++ b/drivers/ata/pata_of_platform.c
@@ -32,7 +32,6 @@ static int pata_of_platform_probe(struct platform_device *ofdev)
 	unsigned int reg_shift = 0;
 	int pio_mode = 0;
 	int pio_mask;
-	const u32 *prop;
 
 	ret = of_address_to_resource(dn, 0, &io_res);
 	if (ret) {
@@ -50,13 +49,9 @@ static int pata_of_platform_probe(struct platform_device *ofdev)
 
 	irq_res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);
 
-	prop = of_get_property(dn, "reg-shift", NULL);
-	if (prop)
-		reg_shift = be32_to_cpup(prop);
+	of_property_read_u32(dn, "reg-shift", &reg_shift);
 
-	prop = of_get_property(dn, "pio-mode", NULL);
-	if (prop) {
-		pio_mode = be32_to_cpup(prop);
+	if (!of_property_read_u32(dn, "pio-mode", &pio_mode)) {
 		if (pio_mode > 6) {
 			dev_err(&ofdev->dev, "invalid pio-mode\n");
 			return -EINVAL;
-- 
1.7.12.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] ata: pata_of_platform: using of_property_read_u32() helper
@ 2017-01-24 12:08 ` Kefeng Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Kefeng Wang @ 2017-01-24 12:08 UTC (permalink / raw)
  To: Tejun Heo, linux-kernel
  Cc: linux-ide, Kefeng Wang, Bartlomiej Zolnierkiewicz, Hans de Goede

Using better of_property_read_u32() than generic of_get_property().

Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/ata/pata_of_platform.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c
index b6b7af8..201a32d 100644
--- a/drivers/ata/pata_of_platform.c
+++ b/drivers/ata/pata_of_platform.c
@@ -32,7 +32,6 @@ static int pata_of_platform_probe(struct platform_device *ofdev)
 	unsigned int reg_shift = 0;
 	int pio_mode = 0;
 	int pio_mask;
-	const u32 *prop;
 
 	ret = of_address_to_resource(dn, 0, &io_res);
 	if (ret) {
@@ -50,13 +49,9 @@ static int pata_of_platform_probe(struct platform_device *ofdev)
 
 	irq_res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);
 
-	prop = of_get_property(dn, "reg-shift", NULL);
-	if (prop)
-		reg_shift = be32_to_cpup(prop);
+	of_property_read_u32(dn, "reg-shift", &reg_shift);
 
-	prop = of_get_property(dn, "pio-mode", NULL);
-	if (prop) {
-		pio_mode = be32_to_cpup(prop);
+	if (!of_property_read_u32(dn, "pio-mode", &pio_mode)) {
 		if (pio_mode > 6) {
 			dev_err(&ofdev->dev, "invalid pio-mode\n");
 			return -EINVAL;
-- 
1.7.12.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] ata: pata_of_platform: using of_property_read_u32() helper
  2017-01-24 12:08 ` Kefeng Wang
  (?)
@ 2017-01-24 16:15 ` Tejun Heo
  -1 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2017-01-24 16:15 UTC (permalink / raw)
  To: Kefeng Wang
  Cc: linux-kernel, linux-ide, Bartlomiej Zolnierkiewicz, Hans de Goede

On Tue, Jan 24, 2017 at 08:08:29PM +0800, Kefeng Wang wrote:
> Using better of_property_read_u32() than generic of_get_property().
> 
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Applied to libata/for-4.11.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-24 16:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 12:08 [PATCH] ata: pata_of_platform: using of_property_read_u32() helper Kefeng Wang
2017-01-24 12:08 ` Kefeng Wang
2017-01-24 16:15 ` Tejun Heo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.