From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: Andrea Arcangeli <aarcange@redhat.com>, Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: [PATCH 06/12] mm: convert page_mkclean_one() to page_check_walk() Date: Tue, 24 Jan 2017 19:28:18 +0300 [thread overview] Message-ID: <20170124162824.91275-7-kirill.shutemov@linux.intel.com> (raw) In-Reply-To: <20170124162824.91275-1-kirill.shutemov@linux.intel.com> For consistency, it worth converting all page_check_address() to page_check_walk(), so we could drop the former. PMD handling here is future-proofing, we don't have users yet. ext4 with huge pages will be the first. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- mm/rmap.c | 66 +++++++++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 23 deletions(-) diff --git a/mm/rmap.c b/mm/rmap.c index 3bbf83b32553..41874a6f6cf5 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1017,34 +1017,54 @@ int page_referenced(struct page *page, static int page_mkclean_one(struct page *page, struct vm_area_struct *vma, unsigned long address, void *arg) { - struct mm_struct *mm = vma->vm_mm; - pte_t *pte; - spinlock_t *ptl; - int ret = 0; + struct page_check_walk pcw = { + .page = page, + .vma = vma, + .address = address, + .flags = PAGE_CHECK_WALK_SYNC, + }; int *cleaned = arg; - pte = page_check_address(page, mm, address, &ptl, 1); - if (!pte) - goto out; - - if (pte_dirty(*pte) || pte_write(*pte)) { - pte_t entry; + while (page_check_walk(&pcw)) { + int ret = 0; + address = pcw.address; + if (pcw.pte) { + pte_t entry; + pte_t *pte = pcw.pte; + + if (!pte_dirty(*pte) && !pte_write(*pte)) + continue; + + flush_cache_page(vma, address, pte_pfn(*pte)); + entry = ptep_clear_flush(vma, address, pte); + entry = pte_wrprotect(entry); + entry = pte_mkclean(entry); + set_pte_at(vma->vm_mm, address, pte, entry); + ret = 1; + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGE_PAGECACHE)) { + pmd_t *pmd = pcw.pmd; + pmd_t entry; + + if (!pmd_dirty(*pmd) && !pmd_write(*pmd)) + continue; + + flush_cache_page(vma, address, page_to_pfn(page)); + entry = pmdp_huge_clear_flush(vma, address, pmd); + entry = pmd_wrprotect(entry); + entry = pmd_mkclean(entry); + set_pmd_at(vma->vm_mm, address, pmd, entry); + ret = 1; + } else { + /* unexpected pmd-mapped page? */ + WARN_ON_ONCE(1); + } - flush_cache_page(vma, address, pte_pfn(*pte)); - entry = ptep_clear_flush(vma, address, pte); - entry = pte_wrprotect(entry); - entry = pte_mkclean(entry); - set_pte_at(mm, address, pte, entry); - ret = 1; + if (ret) { + mmu_notifier_invalidate_page(vma->vm_mm, address); + (*cleaned)++; + } } - pte_unmap_unlock(pte, ptl); - - if (ret) { - mmu_notifier_invalidate_page(mm, address); - (*cleaned)++; - } -out: return SWAP_AGAIN; } -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: Andrea Arcangeli <aarcange@redhat.com>, Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: [PATCH 06/12] mm: convert page_mkclean_one() to page_check_walk() Date: Tue, 24 Jan 2017 19:28:18 +0300 [thread overview] Message-ID: <20170124162824.91275-7-kirill.shutemov@linux.intel.com> (raw) In-Reply-To: <20170124162824.91275-1-kirill.shutemov@linux.intel.com> For consistency, it worth converting all page_check_address() to page_check_walk(), so we could drop the former. PMD handling here is future-proofing, we don't have users yet. ext4 with huge pages will be the first. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- mm/rmap.c | 66 +++++++++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 23 deletions(-) diff --git a/mm/rmap.c b/mm/rmap.c index 3bbf83b32553..41874a6f6cf5 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1017,34 +1017,54 @@ int page_referenced(struct page *page, static int page_mkclean_one(struct page *page, struct vm_area_struct *vma, unsigned long address, void *arg) { - struct mm_struct *mm = vma->vm_mm; - pte_t *pte; - spinlock_t *ptl; - int ret = 0; + struct page_check_walk pcw = { + .page = page, + .vma = vma, + .address = address, + .flags = PAGE_CHECK_WALK_SYNC, + }; int *cleaned = arg; - pte = page_check_address(page, mm, address, &ptl, 1); - if (!pte) - goto out; - - if (pte_dirty(*pte) || pte_write(*pte)) { - pte_t entry; + while (page_check_walk(&pcw)) { + int ret = 0; + address = pcw.address; + if (pcw.pte) { + pte_t entry; + pte_t *pte = pcw.pte; + + if (!pte_dirty(*pte) && !pte_write(*pte)) + continue; + + flush_cache_page(vma, address, pte_pfn(*pte)); + entry = ptep_clear_flush(vma, address, pte); + entry = pte_wrprotect(entry); + entry = pte_mkclean(entry); + set_pte_at(vma->vm_mm, address, pte, entry); + ret = 1; + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGE_PAGECACHE)) { + pmd_t *pmd = pcw.pmd; + pmd_t entry; + + if (!pmd_dirty(*pmd) && !pmd_write(*pmd)) + continue; + + flush_cache_page(vma, address, page_to_pfn(page)); + entry = pmdp_huge_clear_flush(vma, address, pmd); + entry = pmd_wrprotect(entry); + entry = pmd_mkclean(entry); + set_pmd_at(vma->vm_mm, address, pmd, entry); + ret = 1; + } else { + /* unexpected pmd-mapped page? */ + WARN_ON_ONCE(1); + } - flush_cache_page(vma, address, pte_pfn(*pte)); - entry = ptep_clear_flush(vma, address, pte); - entry = pte_wrprotect(entry); - entry = pte_mkclean(entry); - set_pte_at(mm, address, pte, entry); - ret = 1; + if (ret) { + mmu_notifier_invalidate_page(vma->vm_mm, address); + (*cleaned)++; + } } - pte_unmap_unlock(pte, ptl); - - if (ret) { - mmu_notifier_invalidate_page(mm, address); - (*cleaned)++; - } -out: return SWAP_AGAIN; } -- 2.11.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-24 16:29 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-24 16:28 [PATCH 00/12] Fix few rmap-related THP bugs Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 16:28 ` [PATCH 01/12] uprobes: split THPs before trying replace them Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 18:08 ` Rik van Riel 2017-01-24 18:08 ` Rik van Riel 2017-01-24 21:28 ` Andrew Morton 2017-01-24 21:28 ` Andrew Morton 2017-01-24 22:22 ` Kirill A. Shutemov 2017-01-24 22:22 ` Kirill A. Shutemov 2017-01-24 22:35 ` Andrew Morton 2017-01-24 22:35 ` Andrew Morton 2017-01-24 22:56 ` Kirill A. Shutemov 2017-01-24 22:56 ` Kirill A. Shutemov 2017-01-25 16:55 ` Srikar Dronamraju 2017-01-25 16:55 ` Srikar Dronamraju 2017-01-25 17:44 ` Rik van Riel 2017-01-25 17:44 ` Kirill A. Shutemov 2017-01-25 17:44 ` Kirill A. Shutemov 2017-01-25 18:35 ` Johannes Weiner 2017-01-25 18:35 ` Johannes Weiner 2017-01-25 18:38 ` Kirill A. Shutemov 2017-01-25 18:38 ` Kirill A. Shutemov 2017-01-26 2:54 ` Srikar Dronamraju 2017-01-26 2:54 ` Srikar Dronamraju 2017-01-25 18:22 ` Johannes Weiner 2017-01-25 18:22 ` Johannes Weiner 2017-01-24 16:28 ` [PATCH 02/12] mm: introduce page_check_walk() Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 21:41 ` Andrew Morton 2017-01-24 21:41 ` Andrew Morton 2017-01-24 22:50 ` Kirill A. Shutemov 2017-01-24 22:50 ` Kirill A. Shutemov 2017-01-24 22:55 ` Andrew Morton 2017-01-24 22:55 ` Andrew Morton 2017-01-25 17:53 ` Kirill A. Shutemov 2017-01-25 17:53 ` Kirill A. Shutemov 2017-01-25 1:19 ` kbuild test robot 2017-01-25 1:19 ` kbuild test robot 2017-01-25 1:59 ` kbuild test robot 2017-01-25 1:59 ` kbuild test robot 2017-01-24 16:28 ` [PATCH 03/12] mm: fix handling PTE-mapped THPs in page_referenced() Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 16:28 ` [PATCH 04/12] mm: fix handling PTE-mapped THPs in page_idle_clear_pte_refs() Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 16:28 ` [PATCH 05/12] mm, rmap: check all VMAs that PTE-mapped THP can be part of Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov [this message] 2017-01-24 16:28 ` [PATCH 06/12] mm: convert page_mkclean_one() to page_check_walk() Kirill A. Shutemov 2017-01-25 1:44 ` kbuild test robot 2017-01-25 1:44 ` kbuild test robot 2017-01-25 2:00 ` kbuild test robot 2017-01-25 2:00 ` kbuild test robot 2017-01-24 16:28 ` [PATCH 07/12] mm: convert try_to_unmap_one() " Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-25 3:13 ` kbuild test robot 2017-01-25 3:13 ` kbuild test robot 2017-01-24 16:28 ` [PATCH 08/12] mm, ksm: convert write_protect_page() " Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 16:28 ` [PATCH 09/12] mm, uprobes: convert __replace_page() " Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-26 2:58 ` Srikar Dronamraju 2017-01-26 2:58 ` Srikar Dronamraju 2017-01-24 16:28 ` [PATCH 10/12] mm: convert page_mapped_in_vma() " Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 16:28 ` [PATCH 11/12] mm: drop page_check_address{,_transhuge} Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-24 16:28 ` [PATCH 12/12] mm: convert remove_migration_pte() to page_check_walk() Kirill A. Shutemov 2017-01-24 16:28 ` Kirill A. Shutemov 2017-01-25 1:54 ` kbuild test robot 2017-01-25 1:54 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170124162824.91275-7-kirill.shutemov@linux.intel.com \ --to=kirill.shutemov@linux.intel.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=hughd@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.