All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1
@ 2017-01-24 20:31 Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency Adam Duskett
                   ` (9 more replies)
  0 siblings, 10 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: No changes

 package/janus-gateway/janus-gateway.hash | 2 +-
 package/janus-gateway/janus-gateway.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/janus-gateway/janus-gateway.hash b/package/janus-gateway/janus-gateway.hash
index fece97a..68b9c31 100644
--- a/package/janus-gateway/janus-gateway.hash
+++ b/package/janus-gateway/janus-gateway.hash
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 4d341a54d3eae5506c3e2409f4a6e4f5159dc4ece3197aaf077d3eb997e69a10 janus-gateway-v0.1.0.tar.gz
+sha256 5d071592faca2a1574b996b4ca07b6c9e02cd42a719b0dbb4bfb5dfde8d55ff3 janus-gateway-v0.2.1.tar.gz
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index d65ab19..4b87b33 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-JANUS_GATEWAY_VERSION = v0.1.0
+JANUS_GATEWAY_VERSION = v0.2.1
 JANUS_GATEWAY_SITE = $(call github,meetecho,janus-gateway,$(JANUS_GATEWAY_VERSION))
 JANUS_GATEWAY_LICENSE = GPLv3
 JANUS_GATEWAY_LICENSE_FILES = COPYING
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 21:15   ` Thomas Petazzoni
  2017-01-24 20:31 ` [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional Adam Duskett
                   ` (8 subsequent siblings)
  9 siblings, 1 reply; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway requires sofia-sip in the build system, however
this is unessasary.  This patch makes the sip gateway plugin a option.
It also creates a menuconfig for janus gateway for the following patches
that enable selecting more optional plugins.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: No changes

 package/janus-gateway/Config.in        | 12 ++++++++++--
 package/janus-gateway/janus-gateway.mk |  9 ++++++++-
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 20491b7..2a25c01 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -1,9 +1,8 @@
-config BR2_PACKAGE_JANUS_GATEWAY
+menuconfig BR2_PACKAGE_JANUS_GATEWAY
 	bool "janus-gateway"
 	select BR2_PACKAGE_LIBMICROHTTPD
 	select BR2_PACKAGE_JANSSON
 	select BR2_PACKAGE_LIBNICE
-	select BR2_PACKAGE_SOFIA_SIP
 	select BR2_PACKAGE_LIBSRTP
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_DING_LIBS
@@ -18,6 +17,15 @@ config BR2_PACKAGE_JANUS_GATEWAY
 
 	  https://github.com/meetecho/janus-gateway
 
+if BR2_PACKAGE_JANUS_GATEWAY
+
+comment "janus-gateway plugins"
+
+config BR2_PACKAGE_JANUS_PLUGIN_SIP
+	bool "janus sip gateway plugin"
+	default n
+endif
+
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
 	depends on BR2_USE_MMU
 	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index 4b87b33..77254e6 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -11,7 +11,7 @@ JANUS_GATEWAY_LICENSE_FILES = COPYING
 
 # ding-libs provides the ini_config library
 JANUS_GATEWAY_DEPENDENCIES = host-pkgconf libmicrohttpd jansson \
-	libnice sofia-sip libsrtp host-gengetopt openssl ding-libs
+	libnice libsrtp host-gengetopt openssl ding-libs
 
 # Straight out of the repository, no ./configure, and we also patch
 # configure.ac.
@@ -26,6 +26,13 @@ JANUS_GATEWAY_CONF_OPTS = \
 	--disable-data-channels \
 	--disable-rabbitmq
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_SIP_GATEWAY),y)
+JANUS_GATEWAY_DEPENDENCIES += sofia-sip
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-sip
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-sip
+endif
+
 ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS),y)
 JANUS_GATEWAY_DEPENDENCIES += libwebsockets
 JANUS_GATEWAY_CONF_OPTS += --enable-websockets
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 21:23   ` Thomas Petazzoni
  2017-01-24 20:31 ` [Buildroot] [V2 04/10] janus-gateway: Make echo test " Adam Duskett
                   ` (7 subsequent siblings)
  9 siblings, 1 reply; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the audio bridge plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the audio bridge plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: Fixed patch so that this patch adds the plugin to both the
Config.in and the .mk file.


 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 2a25c01..20e72ff 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -21,6 +21,10 @@ if BR2_PACKAGE_JANUS_GATEWAY
 
 comment "janus-gateway plugins"
 
+config BR2_PACKAGE_JANUS_PLUGIN_AUDIO_BRIDGE
+	bool "janus audio bridge plugin"
+	default n
+
 config BR2_PACKAGE_JANUS_PLUGIN_SIP
 	bool "janus sip gateway plugin"
 	default n
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index 77254e6..da25137 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -26,6 +26,12 @@ JANUS_GATEWAY_CONF_OPTS = \
 	--disable-data-channels \
 	--disable-rabbitmq
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_AUDIO_BRIDGE),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-audiobridge
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-audiobridge
+endif
+
 ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_SIP_GATEWAY),y)
 JANUS_GATEWAY_DEPENDENCIES += sofia-sip
 JANUS_GATEWAY_CONF_OPTS += --enable-plugin-sip
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 04/10] janus-gateway: Make echo test plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 05/10] janus-gateway: Make recordplay " Adam Duskett
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the echo test plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the echo test plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: Fixed patch so that this patch only adds the plugin to both the
Config.in and the .mk file.

 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 20e72ff..19e5a13 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -25,6 +25,10 @@ config BR2_PACKAGE_JANUS_PLUGIN_AUDIO_BRIDGE
 	bool "janus audio bridge plugin"
 	default n
 
+config BR2_PACKAGE_JANUS_PLUGIN_ECHO_TEST
+	bool "janus echo test plugin"
+	default n
+
 config BR2_PACKAGE_JANUS_PLUGIN_SIP
 	bool "janus sip gateway plugin"
 	default n
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index da25137..e1e3601 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -32,6 +32,12 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-audiobridge
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_ECHO_TEST),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-echotest
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-echotest
+endif
+
 ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_SIP_GATEWAY),y)
 JANUS_GATEWAY_DEPENDENCIES += sofia-sip
 JANUS_GATEWAY_CONF_OPTS += --enable-plugin-sip
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 05/10] janus-gateway: Make recordplay plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
                   ` (2 preceding siblings ...)
  2017-01-24 20:31 ` [Buildroot] [V2 04/10] janus-gateway: Make echo test " Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 06/10] janus-gateway: Make streaming " Adam Duskett
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the recordplay plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the recordplay plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
Fixed patch so that this patch actually adds the plugin to both the
Config.in and the .mk file.

 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 19e5a13..7d1ccf9 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -29,6 +29,10 @@ config BR2_PACKAGE_JANUS_PLUGIN_ECHO_TEST
 	bool "janus echo test plugin"
 	default n
 
+config BR2_PACKAGE_JANUS_PLUGIN_RECORDPLAY
+	bool "janus record and play plugin"
+	default n
+
 config BR2_PACKAGE_JANUS_PLUGIN_SIP
 	bool "janus sip gateway plugin"
 	default n
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index e1e3601..d2ffb8b 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -38,6 +38,12 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-echotest
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_RECORDPLAY),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-recordplay
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-recordplay
+endif
+
 ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_SIP_GATEWAY),y)
 JANUS_GATEWAY_DEPENDENCIES += sofia-sip
 JANUS_GATEWAY_CONF_OPTS += --enable-plugin-sip
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 06/10] janus-gateway: Make streaming plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
                   ` (3 preceding siblings ...)
  2017-01-24 20:31 ` [Buildroot] [V2 05/10] janus-gateway: Make recordplay " Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 07/10] janus-gateway: Make text room " Adam Duskett
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the streaming plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the streaming  plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: Fixed patch so that this patch only adds the plugin to both the
Config.in and the .mk file.

 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 7d1ccf9..a7edb61 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -37,6 +37,10 @@ config BR2_PACKAGE_JANUS_PLUGIN_SIP
 	bool "janus sip gateway plugin"
 	default n
 
+config  BR2_PACKAGE_JANUS_PLUGIN_STREAMING
+	bool "janus streaming plugin"
+	default n
+
 endif
 
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index d2ffb8b..2ad1990 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -51,6 +51,12 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-sip
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_STREAMING),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-streaming
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-streaming
+endif
+
 ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS),y)
 JANUS_GATEWAY_DEPENDENCIES += libwebsockets
 JANUS_GATEWAY_CONF_OPTS += --enable-websockets
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 07/10] janus-gateway: Make text room plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
                   ` (4 preceding siblings ...)
  2017-01-24 20:31 ` [Buildroot] [V2 06/10] janus-gateway: Make streaming " Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 08/10] janus-gateway: Make video call " Adam Duskett
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the text room plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the text room plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: no changes.

 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index a7edb61..3a16534 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -41,6 +41,10 @@ config  BR2_PACKAGE_JANUS_PLUGIN_STREAMING
 	bool "janus streaming plugin"
 	default y
 
+config BR2_PACKAGE_JANUS_PLUGIN_TEXT_ROOM
+	bool "janus text room plugin"
+	default n
+
 endif
 
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index 2ad1990..c3e35c8 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -57,6 +57,12 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-streaming
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_TEXT_ROOM),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-textroom
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-textroom
+endif
+
 ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS),y)
 JANUS_GATEWAY_DEPENDENCIES += libwebsockets
 JANUS_GATEWAY_CONF_OPTS += --enable-websockets
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 08/10] janus-gateway: Make video call plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
                   ` (5 preceding siblings ...)
  2017-01-24 20:31 ` [Buildroot] [V2 07/10] janus-gateway: Make text room " Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 09/10] janus-gateway: Make video room " Adam Duskett
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the video call plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the video call plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: no changes.

 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 3a16534..c24de88 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -45,6 +45,10 @@ config BR2_PACKAGE_JANUS_PLUGIN_TEXT_ROOM
 	bool "janus text room plugin"
 	default n
 
+config BR2_PACKAGE_JANUS_PLUGIN_VIDEO_CALL
+	bool "janus video call plugin"
+	default n
+
 endif
 
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index c3e35c8..a1fffa1 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -63,6 +63,12 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-textroom
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_VIDEO_CALL),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-videocall
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-videocall
+endif
+
 ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS),y)
 JANUS_GATEWAY_DEPENDENCIES += libwebsockets
 JANUS_GATEWAY_CONF_OPTS += --enable-websockets
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 09/10] janus-gateway: Make video room plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
                   ` (6 preceding siblings ...)
  2017-01-24 20:31 ` [Buildroot] [V2 08/10] janus-gateway: Make video call " Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 20:31 ` [Buildroot] [V2 10/10] janus-gateway: Make voicemail " Adam Duskett
  2017-01-24 23:57 ` [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Thomas Petazzoni
  9 siblings, 0 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the video room plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the video room plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: no changes.

 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index c24de88..4bfb282 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -49,6 +49,10 @@ config BR2_PACKAGE_JANUS_PLUGIN_VIDEO_CALL
 	bool "janus video call plugin"
 	default n
 
+config BR2_PACKAGE_JANUS_PLUGIN_VIDEO_ROOM
+	bool "janus video room plugin"
+	default n
+
 endif
 
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index a1fffa1..040973d 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -69,6 +69,12 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-videocall
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_VIDEO_ROOM),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-videoroom
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-videoroom
+endif
+
 ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS),y)
 JANUS_GATEWAY_DEPENDENCIES += libwebsockets
 JANUS_GATEWAY_CONF_OPTS += --enable-websockets
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 10/10] janus-gateway: Make voicemail plugin optional.
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
                   ` (7 preceding siblings ...)
  2017-01-24 20:31 ` [Buildroot] [V2 09/10] janus-gateway: Make video room " Adam Duskett
@ 2017-01-24 20:31 ` Adam Duskett
  2017-01-24 23:57 ` [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Thomas Petazzoni
  9 siblings, 0 replies; 13+ messages in thread
From: Adam Duskett @ 2017-01-24 20:31 UTC (permalink / raw)
  To: buildroot

Currently janus-gateway is built by default with the voicemail plugin.
This causes a example config file to be placed on the target filing system
that the user may not need or want.
This patch makes the voicemail plugin a option.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 -> v2: no changes.

 package/janus-gateway/Config.in        | 4 ++++
 package/janus-gateway/janus-gateway.mk | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 4bfb282..468f44d 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -53,6 +53,10 @@ config BR2_PACKAGE_JANUS_PLUGIN_VIDEO_ROOM
 	bool "janus video room plugin"
 	default n
 
+config BR2_PACKAGE_JANUS_PLUGIN_VOICE_MAIL
+	bool "janus voice mail plugin"
+	default n
+
 endif
 
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index 040973d..d716c2e 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -75,6 +75,12 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-videoroom
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_PLUGIN_VOICE_MAIL),y)
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-voicemail
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-voicemail
+endif
+
 ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS),y)
 JANUS_GATEWAY_DEPENDENCIES += libwebsockets
 JANUS_GATEWAY_CONF_OPTS += --enable-websockets
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency.
  2017-01-24 20:31 ` [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency Adam Duskett
@ 2017-01-24 21:15   ` Thomas Petazzoni
  0 siblings, 0 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2017-01-24 21:15 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 24 Jan 2017 15:31:31 -0500, Adam Duskett wrote:

> +if BR2_PACKAGE_JANUS_GATEWAY
> +
> +comment "janus-gateway plugins"
> +
> +config BR2_PACKAGE_JANUS_PLUGIN_SIP
> +	bool "janus sip gateway plugin"

You should select the SOFIA_SIP package here, and inherit its
dependencies.

> +	default n

Not needed, this is the default (applies to all other patches).

Also, since you no longer select the SOFIA_SIP package from the
top-level janus-gateway option, you may want to double check if all the
janus-gateway "depends on" are still necessary.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional.
  2017-01-24 20:31 ` [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional Adam Duskett
@ 2017-01-24 21:23   ` Thomas Petazzoni
  0 siblings, 0 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2017-01-24 21:23 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 24 Jan 2017 15:31:32 -0500, Adam Duskett wrote:
> Currently janus-gateway is built by default with the audio bridge plugin.
> This causes a example config file to be placed on the target filing system
> that the user may not need or want.

I'm not sure to understand this config file story. Why does it matter?
Are these plugin options only installing a config file, or also a
plugin library or something like this?

What is the filesystem size contribution of each plugin? Is it
significant enough to justify having all those additional plugin
options?

> +config BR2_PACKAGE_JANUS_PLUGIN_AUDIO_BRIDGE
> +	bool "janus audio bridge plugin"
> +	default n

Remove "janus" from the prompt: those options are already indented
under the main janus option, so there is no point in repeating that.

And remove the "default n", as it's the default.

I'm just wondering if we shouldn't use "default y" instead, in order to
preserve backward compatibility. But that kind of violates the general
Buildroot rule of "let's build a minimal thing by default". Since I'm
not too strict on backward compatibility, I'd say leave them disabled
by default (but others might disagree).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1
  2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
                   ` (8 preceding siblings ...)
  2017-01-24 20:31 ` [Buildroot] [V2 10/10] janus-gateway: Make voicemail " Adam Duskett
@ 2017-01-24 23:57 ` Thomas Petazzoni
  9 siblings, 0 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2017-01-24 23:57 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 24 Jan 2017 15:31:30 -0500, Adam Duskett wrote:
> Signed-off-by: Adam Duskett <aduskett@codeblue.com>
> ---
> v1 -> v2: No changes

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-01-24 23:57 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency Adam Duskett
2017-01-24 21:15   ` Thomas Petazzoni
2017-01-24 20:31 ` [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional Adam Duskett
2017-01-24 21:23   ` Thomas Petazzoni
2017-01-24 20:31 ` [Buildroot] [V2 04/10] janus-gateway: Make echo test " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 05/10] janus-gateway: Make recordplay " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 06/10] janus-gateway: Make streaming " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 07/10] janus-gateway: Make text room " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 08/10] janus-gateway: Make video call " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 09/10] janus-gateway: Make video room " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 10/10] janus-gateway: Make voicemail " Adam Duskett
2017-01-24 23:57 ` [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.