[PATCH] x86/gpu: GLK uses the same GMS values as SKL

[PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Paulo Zanoni]

So don't forget to reserve its stolen memory bits.

Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: x86@kernel.org
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 arch/x86/kernel/early-quirks.c | 1 +
 1 file changed, 1 insertion(+)

Found by code inspection. This is completely untested since I don't have
GLK hardware.

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 6a08e25..23c4f1c 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
 	INTEL_SKL_IDS(&gen9_early_ops),
 	INTEL_BXT_IDS(&gen9_early_ops),
 	INTEL_KBL_IDS(&gen9_early_ops),
+	INTEL_GLK_IDS(&gen9_early_ops),
 };
 
 static void __init
-- 
2.7.4

[PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Paulo Zanoni]

So don't forget to reserve its stolen memory bits.

Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: x86@kernel.org
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 arch/x86/kernel/early-quirks.c | 1 +
 1 file changed, 1 insertion(+)

Found by code inspection. This is completely untested since I don't have
GLK hardware.

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 6a08e25..23c4f1c 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
 	INTEL_SKL_IDS(&gen9_early_ops),
 	INTEL_BXT_IDS(&gen9_early_ops),
 	INTEL_KBL_IDS(&gen9_early_ops),
+	INTEL_GLK_IDS(&gen9_early_ops),
 };
 
 static void __init
-- 
2.7.4

✓ Fi.CI.BAT: success for x86/gpu: GLK uses the same GMS values as SKL

[Patchwork]

== Series Details ==

Series: x86/gpu: GLK uses the same GMS values as SKL
URL   : https://patchwork.freedesktop.org/series/18505/
State : success

== Summary ==

Series 18505v1 x86/gpu: GLK uses the same GMS values as SKL
https://patchwork.freedesktop.org/api/1.0/series/18505/revisions/1/mbox/


fi-bdw-5557u     total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 
fi-bsw-n3050     total:247  pass:208  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-j4205     total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 
fi-byt-j1900     total:247  pass:220  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-hsw-4770r     total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-ivb-3520m     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-ivb-3770      total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-kbl-7500u     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6260u     total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-skl-6700hq    total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20 
fi-skl-6700k     total:247  pass:222  dwarn:4   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-snb-2520m     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31 
fi-snb-2600      total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 
fi-bxt-t5700 failed to collect. IGT log at Patchwork_3596/fi-bxt-t5700/igt.log

cdab47465a54c45bdf4e9708e39c61d38c7a41ba drm-tip: 2017y-01m-24d-18h-30m-06s UTC integration manifest
3711f0d x86/gpu: GLK uses the same GMS values as SKL

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3596/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Ingo Molnar]

* Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:

> So don't forget to reserve its stolen memory bits.
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: x86@kernel.org
> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  arch/x86/kernel/early-quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> Found by code inspection. This is completely untested since I don't have
> GLK hardware.
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 6a08e25..23c4f1c 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>  	INTEL_SKL_IDS(&gen9_early_ops),
>  	INTEL_BXT_IDS(&gen9_early_ops),
>  	INTEL_KBL_IDS(&gen9_early_ops),
> +	INTEL_GLK_IDS(&gen9_early_ops),
>  };

There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
changes to the i915 GPU driver?

Thanks,

	Ingo

Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Ingo Molnar]

* Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:

> So don't forget to reserve its stolen memory bits.
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: x86@kernel.org
> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  arch/x86/kernel/early-quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> Found by code inspection. This is completely untested since I don't have
> GLK hardware.
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 6a08e25..23c4f1c 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>  	INTEL_SKL_IDS(&gen9_early_ops),
>  	INTEL_BXT_IDS(&gen9_early_ops),
>  	INTEL_KBL_IDS(&gen9_early_ops),
> +	INTEL_GLK_IDS(&gen9_early_ops),
>  };

There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
changes to the i915 GPU driver?

Thanks,

	Ingo

Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Jani Nikula]

On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>
>> So don't forget to reserve its stolen memory bits.
>> 
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: H. Peter Anvin <hpa@zytor.com>
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Cc: x86@kernel.org
>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> ---
>>  arch/x86/kernel/early-quirks.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> Found by code inspection. This is completely untested since I don't have
>> GLK hardware.
>> 
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index 6a08e25..23c4f1c 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>  	INTEL_SKL_IDS(&gen9_early_ops),
>>  	INTEL_BXT_IDS(&gen9_early_ops),
>>  	INTEL_KBL_IDS(&gen9_early_ops),
>> +	INTEL_GLK_IDS(&gen9_early_ops),
>>  };
>
> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
> changes to the i915 GPU driver?

It's in our -next. Ack for merging this through drm-intel along with the
deps?

BR,
Jani.

>
> Thanks,
>
> 	Ingo
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Jani Nikula]

On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>
>> So don't forget to reserve its stolen memory bits.
>> 
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: H. Peter Anvin <hpa@zytor.com>
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Cc: x86@kernel.org
>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> ---
>>  arch/x86/kernel/early-quirks.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> Found by code inspection. This is completely untested since I don't have
>> GLK hardware.
>> 
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index 6a08e25..23c4f1c 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>  	INTEL_SKL_IDS(&gen9_early_ops),
>>  	INTEL_BXT_IDS(&gen9_early_ops),
>>  	INTEL_KBL_IDS(&gen9_early_ops),
>> +	INTEL_GLK_IDS(&gen9_early_ops),
>>  };
>
> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
> changes to the i915 GPU driver?

It's in our -next. Ack for merging this through drm-intel along with the
deps?

BR,
Jani.

>
> Thanks,
>
> 	Ingo
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Jani Nikula]

(Now without the typo in Daniel's address; apologies for the extra
noise.)

On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
>> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>>
>>> So don't forget to reserve its stolen memory bits.
>>> 
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Cc: x86@kernel.org
>>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> ---
>>>  arch/x86/kernel/early-quirks.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>> Found by code inspection. This is completely untested since I don't have
>>> GLK hardware.
>>> 
>>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>>> index 6a08e25..23c4f1c 100644
>>> --- a/arch/x86/kernel/early-quirks.c
>>> +++ b/arch/x86/kernel/early-quirks.c
>>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>>  	INTEL_SKL_IDS(&gen9_early_ops),
>>>  	INTEL_BXT_IDS(&gen9_early_ops),
>>>  	INTEL_KBL_IDS(&gen9_early_ops),
>>> +	INTEL_GLK_IDS(&gen9_early_ops),
>>>  };
>>
>> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
>> changes to the i915 GPU driver?
>
> It's in our -next. Ack for merging this through drm-intel along with the
> deps?
>
> BR,
> Jani.
>
>>
>> Thanks,
>>
>> 	Ingo
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Jani Nikula]

(Now without the typo in Daniel's address; apologies for the extra
noise.)

On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
>> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>>
>>> So don't forget to reserve its stolen memory bits.
>>> 
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Cc: x86@kernel.org
>>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> ---
>>>  arch/x86/kernel/early-quirks.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>> Found by code inspection. This is completely untested since I don't have
>>> GLK hardware.
>>> 
>>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>>> index 6a08e25..23c4f1c 100644
>>> --- a/arch/x86/kernel/early-quirks.c
>>> +++ b/arch/x86/kernel/early-quirks.c
>>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>>  	INTEL_SKL_IDS(&gen9_early_ops),
>>>  	INTEL_BXT_IDS(&gen9_early_ops),
>>>  	INTEL_KBL_IDS(&gen9_early_ops),
>>> +	INTEL_GLK_IDS(&gen9_early_ops),
>>>  };
>>
>> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
>> changes to the i915 GPU driver?
>
> It's in our -next. Ack for merging this through drm-intel along with the
> deps?
>
> BR,
> Jani.
>
>>
>> Thanks,
>>
>> 	Ingo
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Ingo Molnar]

* Jani Nikula <jani.nikula@linux.intel.com> wrote:

> On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> >> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >>
> >>> So don't forget to reserve its stolen memory bits.
> >>> 
> >>> Cc: Ingo Molnar <mingo@kernel.org>
> >>> Cc: H. Peter Anvin <hpa@zytor.com>
> >>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Cc: x86@kernel.org
> >>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>> ---
> >>>  arch/x86/kernel/early-quirks.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>> 
> >>> Found by code inspection. This is completely untested since I don't have
> >>> GLK hardware.
> >>> 
> >>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> >>> index 6a08e25..23c4f1c 100644
> >>> --- a/arch/x86/kernel/early-quirks.c
> >>> +++ b/arch/x86/kernel/early-quirks.c
> >>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> >>>  	INTEL_SKL_IDS(&gen9_early_ops),
> >>>  	INTEL_BXT_IDS(&gen9_early_ops),
> >>>  	INTEL_KBL_IDS(&gen9_early_ops),
> >>> +	INTEL_GLK_IDS(&gen9_early_ops),
> >>>  };
> >>
> >> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
> >> changes to the i915 GPU driver?
> >
> > It's in our -next. Ack for merging this through drm-intel along with the
> > deps?

Yeah, LGTM:

  Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

[Ingo Molnar]

* Jani Nikula <jani.nikula@linux.intel.com> wrote:

> On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> >> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >>
> >>> So don't forget to reserve its stolen memory bits.
> >>> 
> >>> Cc: Ingo Molnar <mingo@kernel.org>
> >>> Cc: H. Peter Anvin <hpa@zytor.com>
> >>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Cc: x86@kernel.org
> >>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>> ---
> >>>  arch/x86/kernel/early-quirks.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>> 
> >>> Found by code inspection. This is completely untested since I don't have
> >>> GLK hardware.
> >>> 
> >>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> >>> index 6a08e25..23c4f1c 100644
> >>> --- a/arch/x86/kernel/early-quirks.c
> >>> +++ b/arch/x86/kernel/early-quirks.c
> >>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> >>>  	INTEL_SKL_IDS(&gen9_early_ops),
> >>>  	INTEL_BXT_IDS(&gen9_early_ops),
> >>>  	INTEL_KBL_IDS(&gen9_early_ops),
> >>> +	INTEL_GLK_IDS(&gen9_early_ops),
> >>>  };
> >>
> >> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
> >> changes to the i915 GPU driver?
> >
> > It's in our -next. Ack for merging this through drm-intel along with the
> > deps?

Yeah, LGTM:

  Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo