All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Griffin <peter.griffin@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
	linux-serial@vger.kernel.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@stlinux.com
Subject: Re: [STLinux Kernel] [PATCH 6/8] ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control
Date: Wed, 25 Jan 2017 11:01:12 +0000	[thread overview]
Message-ID: <20170125110112.GB5680@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <20170124134310.27512-7-lee.jones@linaro.org>

Hi Lee,

On Tue, 24 Jan 2017, Lee Jones wrote:

> Each serial port which supports HW flow-control should have 2 Pinctrl
> groups.  Once for when HW flow-control is in progress, where the IP

Nit: Once?

> will take over controlling the lines and another group which enables
> the lines to be toggled using GPIO mechanisms.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Peter Griffin <peter.griffin@linaro.org>

> ---
>  arch/arm/boot/dts/stih407-pinctrl.dtsi | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index daab16b..fbb7f86 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -465,8 +465,16 @@
>  			serial0 {
>  				pinctrl_serial0: serial0-0 {
>  					st,pins {
> -						tx = <&pio17 0 ALT1 OUT>;
> -						rx = <&pio17 1 ALT1 IN>;
> +						tx =  <&pio17 0 ALT1 OUT>;
> +						rx =  <&pio17 1 ALT1 IN>;
> +					};
> +				};
> +				pinctrl_serial0_flowctrl: serial0-0_flowctrl {
> +					st,pins {
> +						tx =  <&pio17 0 ALT1 OUT>;
> +						rx =  <&pio17 1 ALT1 IN>;
> +						cts = <&pio17 2 ALT1 IN>;
> +						rts = <&pio17 3 ALT1 OUT>;
>  					};
>  				};
>  			};

WARNING: multiple messages have this Message-ID (diff)
From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [STLinux Kernel] [PATCH 6/8] ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control
Date: Wed, 25 Jan 2017 11:01:12 +0000	[thread overview]
Message-ID: <20170125110112.GB5680@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <20170124134310.27512-7-lee.jones@linaro.org>

Hi Lee,

On Tue, 24 Jan 2017, Lee Jones wrote:

> Each serial port which supports HW flow-control should have 2 Pinctrl
> groups.  Once for when HW flow-control is in progress, where the IP

Nit: Once?

> will take over controlling the lines and another group which enables
> the lines to be toggled using GPIO mechanisms.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Peter Griffin <peter.griffin@linaro.org>

> ---
>  arch/arm/boot/dts/stih407-pinctrl.dtsi | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index daab16b..fbb7f86 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -465,8 +465,16 @@
>  			serial0 {
>  				pinctrl_serial0: serial0-0 {
>  					st,pins {
> -						tx = <&pio17 0 ALT1 OUT>;
> -						rx = <&pio17 1 ALT1 IN>;
> +						tx =  <&pio17 0 ALT1 OUT>;
> +						rx =  <&pio17 1 ALT1 IN>;
> +					};
> +				};
> +				pinctrl_serial0_flowctrl: serial0-0_flowctrl {
> +					st,pins {
> +						tx =  <&pio17 0 ALT1 OUT>;
> +						rx =  <&pio17 1 ALT1 IN>;
> +						cts = <&pio17 2 ALT1 IN>;
> +						rts = <&pio17 3 ALT1 OUT>;
>  					};
>  				};
>  			};

  reply	other threads:[~2017-01-25 11:01 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 13:43 [PATCH 0/8] serial: st-asc: Allow handling of RTS line Lee Jones
2017-01-24 13:43 ` Lee Jones
2017-01-24 13:43 ` [PATCH 1/8] serial: st-asc: Ignore the parity error bit if 8-bit mode is enabled Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-25 11:02   ` [STLinux Kernel] " Peter Griffin
2017-01-25 11:02     ` Peter Griffin
2017-01-24 13:43 ` [PATCH 2/8] serial: st-asc: Provide RTS functionality Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-25 11:03   ` [STLinux Kernel] " Peter Griffin
2017-01-25 11:03     ` Peter Griffin
2017-01-24 13:43 ` [PATCH 3/8] serial: st-asc: Read in all Pinctrl states Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-24 21:28   ` kbuild test robot
2017-01-24 21:28     ` kbuild test robot
2017-01-24 21:28     ` kbuild test robot
2017-01-25 11:21   ` [STLinux Kernel] " Peter Griffin
2017-01-25 11:21     ` Peter Griffin
2017-01-27 11:54     ` Lee Jones
2017-01-27 11:54       ` Lee Jones
2017-01-27 11:54       ` Lee Jones
2017-01-30 14:23       ` Peter Griffin
2017-01-30 14:23         ` Peter Griffin
2017-01-30 14:23         ` Peter Griffin
2017-01-30 15:32         ` Lee Jones
2017-01-30 15:32           ` Lee Jones
2017-01-30 15:32           ` Lee Jones
2017-01-30 16:10           ` Peter Griffin
2017-01-30 16:10             ` Peter Griffin
2017-01-30 16:10             ` Peter Griffin
2017-01-30 19:11             ` Lee Jones
2017-01-30 19:11               ` Lee Jones
2017-01-30 19:11               ` Lee Jones
2017-01-30 22:35               ` Peter Griffin
2017-01-30 22:35                 ` Peter Griffin
2017-01-30 22:35                 ` Peter Griffin
2017-01-31 10:13                 ` Lee Jones
2017-01-31 10:13                   ` Lee Jones
2017-01-31 10:13                   ` Lee Jones
2017-01-31 11:31                   ` Peter Griffin
2017-01-31 11:31                     ` Peter Griffin
2017-01-31 11:31                     ` Peter Griffin
2017-01-31 12:27                     ` Lee Jones
2017-01-31 12:27                       ` Lee Jones
2017-01-31 12:27                       ` Lee Jones
2017-02-01 11:50                       ` Peter Griffin
2017-02-01 11:50                         ` Peter Griffin
2017-02-01 11:50                         ` Peter Griffin
2017-02-01 12:47                         ` Lee Jones
2017-02-01 12:47                           ` Lee Jones
2017-02-01 12:47                           ` Lee Jones
2017-01-24 13:43 ` [PATCH 4/8] serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-24 22:00   ` kbuild test robot
2017-01-24 22:00     ` kbuild test robot
2017-01-24 22:00     ` kbuild test robot
2017-01-25 11:24   ` [STLinux Kernel] " Peter Griffin
2017-01-25 11:24     ` Peter Griffin
2017-01-24 13:43 ` [PATCH 5/8] ARM: dts: STiH410-b2260: Identify the UART RTS line Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-24 13:43 ` [PATCH 6/8] ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-25 11:01   ` Peter Griffin [this message]
2017-01-25 11:01     ` [STLinux Kernel] " Peter Griffin
2017-01-24 13:43 ` [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-25 11:54   ` [STLinux Kernel] " Peter Griffin
2017-01-25 11:54     ` Peter Griffin
2017-01-27 11:03     ` Lee Jones
2017-01-27 11:03       ` Lee Jones
2017-01-27 11:03       ` Lee Jones
2017-01-27 11:29       ` Lee Jones
2017-01-27 11:29         ` Lee Jones
2017-01-24 13:43 ` [PATCH 8/8] ARM: dts: STiH407-family: Enable HW flow-control Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-24 13:43   ` Lee Jones
2017-01-25 10:59   ` [STLinux Kernel] " Peter Griffin
2017-01-25 10:59     ` Peter Griffin
2017-01-25 10:59     ` Peter Griffin
2017-01-25 11:40     ` Peter Griffin
2017-01-25 11:40       ` Peter Griffin
2017-01-27 11:33       ` Lee Jones
2017-01-27 11:33         ` Lee Jones
2017-01-27 11:32     ` Lee Jones
2017-01-27 11:32       ` Lee Jones
2017-01-25 10:07 ` [PATCH 0/8] serial: st-asc: Allow handling of RTS line Greg KH
2017-01-25 10:07   ` Greg KH
2017-01-25 15:35   ` Lee Jones
2017-01-25 15:35     ` Lee Jones
2017-01-25 15:35     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125110112.GB5680@griffinp-ThinkPad-X1-Carbon-2nd \
    --to=peter.griffin@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.