* [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
@ 2017-01-26 12:50 Chris Wilson
2017-01-26 12:50 ` [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Chris Wilson @ 2017-01-26 12:50 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi, Zanoni, Paulo R
As we add new generations, we should keep detecting new system
development platforms that were temporarily enabled (via
"i915.alpha_support") and now superseded by production systems. To make
it easier to add more platforms, split the if into a series of logical
operations.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 008fc1e62a69..c2c210b0f47f 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
*/
static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
{
- if (IS_HSW_EARLY_SDV(dev_priv) ||
- IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
+ bool sdv = false;
+
+ sdv |= IS_HSW_EARLY_SDV(dev_priv);
+ sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
+
+ if (sdv)
DRM_ERROR("This is a pre-production stepping. "
"It may not be fully functional.\n");
}
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check
2017-01-26 12:50 [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
@ 2017-01-26 12:50 ` Chris Wilson
2017-01-26 13:26 ` Jani Nikula
2017-01-26 12:50 ` [PATCH 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines Chris Wilson
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2017-01-26 12:50 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi, Zanoni, Paulo R
Preproduction sdv are not supported beyond the release of production
hardware, and continued use is ill-advised. Mark the kernel as tainted
to reinforce the error.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index c2c210b0f47f..ce22ab426d86 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -787,9 +787,11 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
sdv |= IS_HSW_EARLY_SDV(dev_priv);
sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
- if (sdv)
+ if (sdv) {
DRM_ERROR("This is a pre-production stepping. "
"It may not be fully functional.\n");
+ add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);
+ }
}
/**
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines
2017-01-26 12:50 [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
2017-01-26 12:50 ` [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
@ 2017-01-26 12:50 ` Chris Wilson
2017-01-26 13:02 ` [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Ville Syrjälä
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2017-01-26 12:50 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi, Zanoni, Paulo R
Extend intel_detect_preproduction_hw() to include BXT A and B steppings.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index ce22ab426d86..4c1178e7ad7d 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -786,6 +786,7 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
sdv |= IS_HSW_EARLY_SDV(dev_priv);
sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
+ sdv |= IS_BXT_REVID(dev_priv, 0, BXT_REVID_B_LAST);
if (sdv) {
DRM_ERROR("This is a pre-production stepping. "
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 12:50 [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
2017-01-26 12:50 ` [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
2017-01-26 12:50 ` [PATCH 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines Chris Wilson
@ 2017-01-26 13:02 ` Ville Syrjälä
2017-01-26 13:06 ` Paulo Zanoni
2017-01-26 13:16 ` Chris Wilson
2017-01-26 13:18 ` Jani Nikula
2017-01-26 22:54 ` ✗ Fi.CI.BAT: warning for series starting with [1/3] " Patchwork
4 siblings, 2 replies; 12+ messages in thread
From: Ville Syrjälä @ 2017-01-26 13:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: Jani Nikula, intel-gfx, Zanoni, Paulo R, Rodrigo Vivi
On Thu, Jan 26, 2017 at 12:50:28PM +0000, Chris Wilson wrote:
> As we add new generations, we should keep detecting new system
> development platforms that were temporarily enabled (via
> "i915.alpha_support") and now superseded by production systems. To make
> it easier to add more platforms, split the if into a series of logical
> operations.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 008fc1e62a69..c2c210b0f47f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
> */
> static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> {
> - if (IS_HSW_EARLY_SDV(dev_priv) ||
> - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> + bool sdv = false;
Presumably not all SDVs use pre-production silicon, so the name of
this variable feels a bit off. Also since it doesn't actually check
anything about the actual board we can't even say that it's an
actual SDV, so the HSW_EARLY_SDV() macro seems somewhat poorly named
to me as well.
> +
> + sdv |= IS_HSW_EARLY_SDV(dev_priv);
> + sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
> +
> + if (sdv)
> DRM_ERROR("This is a pre-production stepping. "
> "It may not be fully functional.\n");
> }
> --
> 2.11.0
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 13:02 ` [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Ville Syrjälä
@ 2017-01-26 13:06 ` Paulo Zanoni
2017-01-26 13:16 ` Chris Wilson
1 sibling, 0 replies; 12+ messages in thread
From: Paulo Zanoni @ 2017-01-26 13:06 UTC (permalink / raw)
To: Ville Syrjälä, Chris Wilson
Cc: Jani Nikula, intel-gfx, Rodrigo Vivi
Em Qui, 2017-01-26 às 15:02 +0200, Ville Syrjälä escreveu:
> On Thu, Jan 26, 2017 at 12:50:28PM +0000, Chris Wilson wrote:
> >
> > As we add new generations, we should keep detecting new system
> > development platforms that were temporarily enabled (via
> > "i915.alpha_support") and now superseded by production systems. To
> > make
> > it easier to add more platforms, split the if into a series of
> > logical
> > operations.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c
> > b/drivers/gpu/drm/i915/i915_drv.c
> > index 008fc1e62a69..c2c210b0f47f 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct
> > drm_i915_private *dev_priv)
> > */
> > static void intel_detect_preproduction_hw(struct drm_i915_private
> > *dev_priv)
> > {
> > - if (IS_HSW_EARLY_SDV(dev_priv) ||
> > - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> > + bool sdv = false;
>
> Presumably not all SDVs use pre-production silicon, so the name of
> this variable feels a bit off. Also since it doesn't actually check
> anything about the actual board we can't even say that it's an
> actual SDV, so the HSW_EARLY_SDV() macro seems somewhat poorly named
> to me as well.
The HSW case is different since those SDVs even have different PCI IDs
too, not only REV IDs, and "_SDV" is how the PCI IDs are named. I
wonder if we should just remove them from our list of PCI IDs. Could
these IDs be repurposed in the future?
>
> >
> > +
> > + sdv |= IS_HSW_EARLY_SDV(dev_priv);
> > + sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
> > +
> > + if (sdv)
> > DRM_ERROR("This is a pre-production stepping. "
> > "It may not be fully functional.\n");
> > }
> > --
> > 2.11.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 13:02 ` [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Ville Syrjälä
2017-01-26 13:06 ` Paulo Zanoni
@ 2017-01-26 13:16 ` Chris Wilson
2017-01-26 13:21 ` Chris Wilson
1 sibling, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2017-01-26 13:16 UTC (permalink / raw)
To: Ville Syrjälä
Cc: Jani Nikula, intel-gfx, Zanoni, Paulo R, Rodrigo Vivi
On Thu, Jan 26, 2017 at 03:02:14PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 26, 2017 at 12:50:28PM +0000, Chris Wilson wrote:
> > As we add new generations, we should keep detecting new system
> > development platforms that were temporarily enabled (via
> > "i915.alpha_support") and now superseded by production systems. To make
> > it easier to add more platforms, split the if into a series of logical
> > operations.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index 008fc1e62a69..c2c210b0f47f 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
> > */
> > static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> > {
> > - if (IS_HSW_EARLY_SDV(dev_priv) ||
> > - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> > + bool sdv = false;
>
> Presumably not all SDVs use pre-production silicon, so the name of
> this variable feels a bit off. Also since it doesn't actually check
> anything about the actual board we can't even say that it's an
> actual SDV, so the HSW_EARLY_SDV() macro seems somewhat poorly named
> to me as well.
I started with bool preproduction; but that eats too many characters.
Ideas for something short and snappy? bool alpha_hw? bool alpha?
-Chris
>
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 12:50 [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
` (2 preceding siblings ...)
2017-01-26 13:02 ` [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Ville Syrjälä
@ 2017-01-26 13:18 ` Jani Nikula
2017-01-26 13:35 ` Chris Wilson
2017-01-26 22:54 ` ✗ Fi.CI.BAT: warning for series starting with [1/3] " Patchwork
4 siblings, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2017-01-26 13:18 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Rodrigo Vivi, Zanoni, Paulo R
On Thu, 26 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> As we add new generations, we should keep detecting new system
> development platforms that were temporarily enabled (via
> "i915.alpha_support") and now superseded by production systems. To make
> it easier to add more platforms, split the if into a series of logical
> operations.
Please be careful not to conflate preproduction/early hardware with
alpha support in the driver. They are two distinct things. The former is
purely about hardware. The latter is purely about software.
(Okay, there's the dependency that we're probably unable to say we have
a production quality driver until we have production quality hardware to
test it on.)
BR,
Jani.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 008fc1e62a69..c2c210b0f47f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
> */
> static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> {
> - if (IS_HSW_EARLY_SDV(dev_priv) ||
> - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> + bool sdv = false;
> +
> + sdv |= IS_HSW_EARLY_SDV(dev_priv);
> + sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
> +
> + if (sdv)
> DRM_ERROR("This is a pre-production stepping. "
> "It may not be fully functional.\n");
> }
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 13:16 ` Chris Wilson
@ 2017-01-26 13:21 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2017-01-26 13:21 UTC (permalink / raw)
To: Ville Syrjälä,
intel-gfx, Zanoni, Paulo R, Rodrigo Vivi, Jani Nikula
On Thu, Jan 26, 2017 at 01:16:03PM +0000, Chris Wilson wrote:
> On Thu, Jan 26, 2017 at 03:02:14PM +0200, Ville Syrjälä wrote:
> > On Thu, Jan 26, 2017 at 12:50:28PM +0000, Chris Wilson wrote:
> > > As we add new generations, we should keep detecting new system
> > > development platforms that were temporarily enabled (via
> > > "i915.alpha_support") and now superseded by production systems. To make
> > > it easier to add more platforms, split the if into a series of logical
> > > operations.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > > index 008fc1e62a69..c2c210b0f47f 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.c
> > > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > > @@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
> > > */
> > > static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> > > {
> > > - if (IS_HSW_EARLY_SDV(dev_priv) ||
> > > - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> > > + bool sdv = false;
> >
> > Presumably not all SDVs use pre-production silicon, so the name of
> > this variable feels a bit off. Also since it doesn't actually check
> > anything about the actual board we can't even say that it's an
> > actual SDV, so the HSW_EARLY_SDV() macro seems somewhat poorly named
> > to me as well.
>
> I started with bool preproduction; but that eats too many characters.
> Ideas for something short and snappy? bool alpha_hw? bool alpha?
Preferring bool pre; to avoid the connotations of "alpha hardware". All
our hardware is perfect.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check
2017-01-26 12:50 ` [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
@ 2017-01-26 13:26 ` Jani Nikula
0 siblings, 0 replies; 12+ messages in thread
From: Jani Nikula @ 2017-01-26 13:26 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Rodrigo Vivi, Zanoni, Paulo R
On Thu, 26 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Preproduction sdv are not supported beyond the release of production
> hardware, and continued use is ill-advised. Mark the kernel as tainted
> to reinforce the error.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c2c210b0f47f..ce22ab426d86 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -787,9 +787,11 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> sdv |= IS_HSW_EARLY_SDV(dev_priv);
> sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
>
> - if (sdv)
> + if (sdv) {
> DRM_ERROR("This is a pre-production stepping. "
> "It may not be fully functional.\n");
> + add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);
This is rather harsh, but I suppose it should be. Popularity contest in
the kernel suggests it's not used lightly (actually not much at all).
Acked-by: Jani Nikula <jani.nikula@intel.com>
> + }
> }
>
> /**
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 13:18 ` Jani Nikula
@ 2017-01-26 13:35 ` Chris Wilson
2017-01-26 13:45 ` Jani Nikula
0 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2017-01-26 13:35 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Zanoni, Paulo R, Rodrigo Vivi
On Thu, Jan 26, 2017 at 03:18:28PM +0200, Jani Nikula wrote:
> On Thu, 26 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > As we add new generations, we should keep detecting new system
> > development platforms that were temporarily enabled (via
> > "i915.alpha_support") and now superseded by production systems. To make
> > it easier to add more platforms, split the if into a series of logical
> > operations.
>
> Please be careful not to conflate preproduction/early hardware with
> alpha support in the driver. They are two distinct things. The former is
> purely about hardware. The latter is purely about software.
"temporarily enabled to facilitate development and now superseded..." ?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 13:35 ` Chris Wilson
@ 2017-01-26 13:45 ` Jani Nikula
0 siblings, 0 replies; 12+ messages in thread
From: Jani Nikula @ 2017-01-26 13:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, Zanoni, Paulo R, Rodrigo Vivi
On Thu, 26 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Jan 26, 2017 at 03:18:28PM +0200, Jani Nikula wrote:
>> On Thu, 26 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > As we add new generations, we should keep detecting new system
>> > development platforms that were temporarily enabled (via
>> > "i915.alpha_support") and now superseded by production systems. To make
>> > it easier to add more platforms, split the if into a series of logical
>> > operations.
>>
>> Please be careful not to conflate preproduction/early hardware with
>> alpha support in the driver. They are two distinct things. The former is
>> purely about hardware. The latter is purely about software.
>
> "temporarily enabled to facilitate development and now superseded..." ?
Yes, that's fine. A released kernel with alpha support for a given
platform will still only have alpha support for production versions of
said platform.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✗ Fi.CI.BAT: warning for series starting with [1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
2017-01-26 12:50 [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
` (3 preceding siblings ...)
2017-01-26 13:18 ` Jani Nikula
@ 2017-01-26 22:54 ` Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2017-01-26 22:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
URL : https://patchwork.freedesktop.org/series/18604/
State : warning
== Summary ==
Series 18604v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/18604/revisions/1/mbox/
Test gem_close_race:
Subgroup basic-threads:
incomplete -> PASS (fi-bxt-j4205)
Test kms_force_connector_basic:
Subgroup force-edid:
pass -> DMESG-WARN (fi-snb-2520m)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (fi-skl-6700k)
fi-bdw-5557u total:247 pass:233 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:247 pass:208 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:247 pass:225 dwarn:0 dfail:0 fail:0 skip:22
fi-bxt-t5700 total:79 pass:66 dwarn:0 dfail:0 fail:0 skip:12
fi-byt-j1900 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
fi-hsw-4770r total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
fi-ivb-3520m total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-ivb-3770 total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-kbl-7500u total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6260u total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:247 pass:227 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:247 pass:222 dwarn:4 dfail:0 fail:0 skip:21
fi-skl-6770hq total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:247 pass:215 dwarn:1 dfail:0 fail:0 skip:31
fi-snb-2600 total:247 pass:215 dwarn:0 dfail:0 fail:0 skip:32
48cf644b4781ce8345c7506b719601c563982802 drm-tip: 2017y-01m-26d-18h-59m-50s UTC integration manifest
62a4368 drm/i915: Add early BXT sdv to the list of preproduction machines
e5e6fad drm/i915: Mark the kernel as tainted if we fail the preproduction check
332518d drm/i915: Make intel_detect_preproduction_hw easier to extend
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3613/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-01-26 22:54 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 12:50 [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
2017-01-26 12:50 ` [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
2017-01-26 13:26 ` Jani Nikula
2017-01-26 12:50 ` [PATCH 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines Chris Wilson
2017-01-26 13:02 ` [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Ville Syrjälä
2017-01-26 13:06 ` Paulo Zanoni
2017-01-26 13:16 ` Chris Wilson
2017-01-26 13:21 ` Chris Wilson
2017-01-26 13:18 ` Jani Nikula
2017-01-26 13:35 ` Chris Wilson
2017-01-26 13:45 ` Jani Nikula
2017-01-26 22:54 ` ✗ Fi.CI.BAT: warning for series starting with [1/3] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.