All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] booti: Set images.os.arch
@ 2017-01-26 22:55 Scott Wood
  2017-01-26 23:01 ` Tom Rini
  2017-01-28 22:46 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Scott Wood @ 2017-01-26 22:55 UTC (permalink / raw)
  To: u-boot

Commit ec6617c39741adc6c549 ("armv8: Support loading 32-bit OS in AArch32
execution state") broke SMP boot by assuming that an image is 32-bit if
the arch field in the spin table != IH_ARCH_DEFAULT (i.e.
IH_ARCH_ARM64), even if the arch field also does not match IH_ARCH_ARM,
even though nothing actually set the arch field in the spin table.

Commit e2c18e40b111470f ("armv8: fsl-layerscape: SMP support for loading
32-bit OS") fixed this for bootm by setting the arch field of the spin
table based on images.os.arch, but booti remaineed broken because it did
not set images.os.arch.

Fixes: ec6617c39741adc6c549 ("armv8: Support loading 32-bit OS in AArch32 execution state")
Fixes: e2c18e40b111 ("armv8: fsl-layerscape: SMP support for loading 32-bit OS")
Cc: Alison Wang <alison.wang@nxp.com>
Cc: Chenhui Zhao <chenhui.zhao@nxp.com>
Cc: York Sun <york.sun@nxp.com>
Cc: Stuart Yoder <stuart.yoder@nxp.com>
Signed-off-by: Scott Wood <oss@buserror.net>
---
 cmd/booti.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/booti.c b/cmd/booti.c
index 2d879f3..bff87a8 100644
--- a/cmd/booti.c
+++ b/cmd/booti.c
@@ -131,6 +131,7 @@ int do_booti(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	bootm_disable_interrupts();
 
 	images.os.os = IH_OS_LINUX;
+	images.os.arch = IH_ARCH_ARM64;
 	ret = do_bootm_states(cmdtp, flag, argc, argv,
 #ifdef CONFIG_SYS_BOOT_RAMDISK_HIGH
 			      BOOTM_STATE_RAMDISK |
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] booti: Set images.os.arch
  2017-01-26 22:55 [U-Boot] [PATCH] booti: Set images.os.arch Scott Wood
@ 2017-01-26 23:01 ` Tom Rini
  2017-01-28 22:46 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-01-26 23:01 UTC (permalink / raw)
  To: u-boot

On Thu, Jan 26, 2017 at 04:55:44PM -0600, Scott Wood wrote:

> Commit ec6617c39741adc6c549 ("armv8: Support loading 32-bit OS in AArch32
> execution state") broke SMP boot by assuming that an image is 32-bit if
> the arch field in the spin table != IH_ARCH_DEFAULT (i.e.
> IH_ARCH_ARM64), even if the arch field also does not match IH_ARCH_ARM,
> even though nothing actually set the arch field in the spin table.
> 
> Commit e2c18e40b111470f ("armv8: fsl-layerscape: SMP support for loading
> 32-bit OS") fixed this for bootm by setting the arch field of the spin
> table based on images.os.arch, but booti remaineed broken because it did
> not set images.os.arch.
> 
> Fixes: ec6617c39741adc6c549 ("armv8: Support loading 32-bit OS in AArch32 execution state")
> Fixes: e2c18e40b111 ("armv8: fsl-layerscape: SMP support for loading 32-bit OS")
> Cc: Alison Wang <alison.wang@nxp.com>
> Cc: Chenhui Zhao <chenhui.zhao@nxp.com>
> Cc: York Sun <york.sun@nxp.com>
> Cc: Stuart Yoder <stuart.yoder@nxp.com>
> Signed-off-by: Scott Wood <oss@buserror.net>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170126/3b3d65f1/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] booti: Set images.os.arch
  2017-01-26 22:55 [U-Boot] [PATCH] booti: Set images.os.arch Scott Wood
  2017-01-26 23:01 ` Tom Rini
@ 2017-01-28 22:46 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-01-28 22:46 UTC (permalink / raw)
  To: u-boot

On Thu, Jan 26, 2017 at 04:55:44PM -0600, Scott Wood wrote:

> Commit ec6617c39741adc6c549 ("armv8: Support loading 32-bit OS in AArch32
> execution state") broke SMP boot by assuming that an image is 32-bit if
> the arch field in the spin table != IH_ARCH_DEFAULT (i.e.
> IH_ARCH_ARM64), even if the arch field also does not match IH_ARCH_ARM,
> even though nothing actually set the arch field in the spin table.
> 
> Commit e2c18e40b111470f ("armv8: fsl-layerscape: SMP support for loading
> 32-bit OS") fixed this for bootm by setting the arch field of the spin
> table based on images.os.arch, but booti remaineed broken because it did
> not set images.os.arch.
> 
> Fixes: ec6617c39741adc6c549 ("armv8: Support loading 32-bit OS in AArch32 execution state")
> Fixes: e2c18e40b111 ("armv8: fsl-layerscape: SMP support for loading 32-bit OS")
> Cc: Alison Wang <alison.wang@nxp.com>
> Cc: Chenhui Zhao <chenhui.zhao@nxp.com>
> Cc: York Sun <york.sun@nxp.com>
> Cc: Stuart Yoder <stuart.yoder@nxp.com>
> Signed-off-by: Scott Wood <oss@buserror.net>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170128/de8ef2b1/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-28 22:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 22:55 [U-Boot] [PATCH] booti: Set images.os.arch Scott Wood
2017-01-26 23:01 ` Tom Rini
2017-01-28 22:46 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.