* [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27
@ 2017-01-27 19:35 Paolo Bonzini
2017-01-27 19:35 ` [Qemu-devel] [PULL 18/41] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Paolo Bonzini @ 2017-01-27 19:35 UTC (permalink / raw)
To: qemu-devel
The following changes since commit 29ba0cdc1fd1300f910d150c03a0f74236083bf7:
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-01-27' into staging (2017-01-27 15:20:08 +0000)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to 6da67de6803e93cbb7e93ac3497865832f8c00ea:
memory: don't sign-extend 32-bit writes (2017-01-27 18:08:00 +0100)
----------------------------------------------------------------
* SCSI max_transfer support for scsi-generic (Eric)
* x86 SMI broadcast (Laszlo)
* Character device QOMification (Marc-André)
* Record/replay improvements (Pavel)
* iscsi fixes (Peter L.)
* "info mtree -f" command (Peter Xu)
* TSC clock rate reporting (Phil)
* DEVICE_CATEGORY_CPU (Thomas)
* Memory sign-extension fix (Ladi)
----------------------------------------------------------------
Eric Farman (3):
hw/scsi: Fix debug message of cdb structure in scsi-generic
block: Fix target variable of BLKSECTGET ioctl
block: get max_transfer limit for char (scsi-generic) devices
Ladi Prosek (1):
memory: don't sign-extend 32-bit writes
Laszlo Ersek (3):
hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg
hw/isa/lpc_ich9: add broadcast SMI feature
hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types
Marc-André Lureau (20):
tests: fix linking test-char on win32
qemu-options: stdio is available on win32
char: add qemu_chr_fe_add_watch() Returns description
doc: fix spelling
char: use a const CharDriver
char: use a static array for backends
char: move callbacks in CharDriver
char: fold single-user functions in caller
char: introduce generic qemu_chr_get_kind()
char: use a feature bit for replay
char: allocate CharDriverState as a single object
bt: use qemu_chr_alloc()
char: rename CharDriverState Chardev
char: rename TCPChardev and NetChardev
spice-char: improve error reporting
char: use error_report()
gtk: overwrite the console.c char driver
baum: use a common prefix for chr callbacks
vc: use a common prefix for chr callbacks
chardev: qom-ify
Pavel Dovgalyuk (7):
icount: update instruction counter on apic patching
replay: improve interrupt handling
replay: don't use rtc clock on loadvm phase
savevm: add public save_vmstate function
replay: save/load initial state
replay: exception replay fix
apic: save apic_delivered flag
Peter Lieven (2):
block/iscsi: avoid data corruption with cache=writeback
block/iscsi: statically link qemu_iscsi_opts
Peter Xu (2):
memory: tune mtree_print_mr() to dump mr type
memory: hmp: add "-f" for "info mtree"
Phil Dennis-Jordan (2):
x86-KVM: Supply TSC and APIC clock rates to guest like VMWare
pc: Enable vmware-cpuid-freq CPU option for 2.9+ machine types
Thomas Huth (1):
Introduce DEVICE_CATEGORY_CPU for CPU devices
MAINTAINERS | 1 +
backends/baum.c | 102 +-
backends/msmouse.c | 77 +-
backends/rng-egd.c | 4 +-
backends/testdev.c | 53 +-
block/Makefile.objs | 1 +
block/file-posix.c | 19 +-
block/iscsi-opts.c | 69 ++
block/iscsi.c | 8 +-
cpu-exec.c | 2 +-
docs/replay.txt | 16 +
exec.c | 2 +-
gdbstub.c | 45 +-
hmp-commands-info.hx | 6 +-
hw/arm/fsl-imx25.c | 2 +-
hw/arm/fsl-imx31.c | 2 +-
hw/arm/fsl-imx6.c | 2 +-
hw/arm/nseries.c | 2 +-
hw/arm/omap2.c | 2 +-
hw/arm/pxa2xx.c | 2 +-
hw/arm/virt.c | 2 +-
hw/bt/hci-csr.c | 64 +-
hw/char/escc.c | 2 +-
hw/char/exynos4210_uart.c | 2 +-
hw/char/imx_serial.c | 2 +-
hw/char/mcf_uart.c | 4 +-
hw/char/omap_uart.c | 6 +-
hw/char/parallel.c | 2 +-
hw/char/serial-isa.c | 2 +-
hw/char/serial.c | 4 +-
hw/char/sh_serial.c | 2 +-
hw/char/spapr_vty.c | 2 +-
hw/char/virtio-console.c | 2 +-
hw/core/qdev-properties-system.c | 4 +-
hw/cpu/core.c | 8 +
hw/display/milkymist-tmu2.c | 2 +-
hw/display/sm501.c | 2 +-
hw/i386/kvmvapic.c | 6 +
hw/intc/apic_common.c | 33 +
hw/isa/isa-bus.c | 2 +-
hw/isa/lpc_ich9.c | 91 +-
hw/isa/pc87312.c | 2 +-
hw/lm32/lm32.h | 4 +-
hw/lm32/milkymist-hw.h | 2 +-
hw/mips/mips_malta.c | 4 +-
hw/misc/ivshmem.c | 2 +-
hw/misc/milkymist-pfpu.c | 2 +-
hw/scsi/scsi-generic.c | 5 +-
hw/timer/mc146818rtc.c | 15 +-
hw/usb/ccid-card-passthru.c | 2 +-
hw/usb/dev-serial.c | 6 +-
hw/usb/redirect.c | 4 +-
include/block/block.h | 1 +
include/exec/memory.h | 2 +-
include/hw/arm/exynos4210.h | 2 +-
include/hw/arm/omap.h | 6 +-
include/hw/bt.h | 4 +-
include/hw/char/cadence_uart.h | 2 +-
include/hw/char/escc.h | 2 +-
include/hw/char/pl011.h | 4 +-
include/hw/char/serial.h | 4 +-
include/hw/char/xilinx_uartlite.h | 2 +-
include/hw/cris/etraxfs.h | 2 +-
include/hw/devices.h | 2 +-
include/hw/i386/apic_internal.h | 2 +
include/hw/i386/ich9.h | 13 +
include/hw/i386/pc.h | 12 +-
include/hw/m68k/mcf.h | 4 +-
include/hw/ppc/spapr_vio.h | 2 +-
include/hw/qdev-core.h | 1 +
include/hw/qdev-properties.h | 2 +-
include/hw/sh4/sh.h | 2 +-
include/hw/sparc/grlib.h | 2 +-
include/hw/xen/xen.h | 2 +-
include/monitor/monitor.h | 2 +-
include/qemu/typedefs.h | 2 +-
include/sysemu/char.h | 155 +--
include/sysemu/replay.h | 13 +-
include/sysemu/sysemu.h | 5 +-
include/ui/console.h | 2 +
include/ui/gtk.h | 2 +-
include/ui/qemu-spice.h | 2 +-
memory.c | 89 +-
migration/savevm.c | 33 +-
monitor.c | 10 +-
net/colo-compare.c | 4 +-
net/filter-mirror.c | 4 +-
net/slirp.c | 2 +-
net/vhost-user.c | 10 +-
qdev-monitor.c | 1 +
qemu-char.c | 1914 ++++++++++++++++++++-----------------
qemu-options.hx | 12 +-
qmp.c | 2 +-
qom/cpu.c | 1 +
qtest.c | 2 +-
replay/replay-char.c | 8 +-
replay/replay-snapshot.c | 17 +
replay/replay.c | 5 +
spice-qemu-char.c | 231 +++--
stubs/monitor.c | 2 +-
stubs/replay.c | 4 +-
target/i386/cpu.c | 1 +
target/i386/cpu.h | 4 +
target/i386/kvm.c | 36 +-
target/i386/seg_helper.c | 1 +
tests/Makefile.include | 2 +-
tests/test-char.c | 10 +-
tests/vhost-user-test.c | 4 +-
translate-all.c | 2 +
ui/console.c | 111 ++-
ui/gtk.c | 86 +-
vl.c | 59 +-
xen-common-stub.c | 2 +-
xen-common.c | 4 +-
114 files changed, 2192 insertions(+), 1448 deletions(-)
create mode 100644 block/iscsi-opts.c
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PULL 18/41] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare
2017-01-27 19:35 [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Paolo Bonzini
@ 2017-01-27 19:35 ` Paolo Bonzini
2017-01-30 12:33 ` [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Laszlo Ersek
2017-01-30 13:24 ` Peter Maydell
2 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2017-01-27 19:35 UTC (permalink / raw)
To: qemu-devel; +Cc: Phil Dennis-Jordan
From: Phil Dennis-Jordan <phil@philjordan.eu>
This fixes timekeeping of x86-64 Darwin/OS X/macOS guests when using KVM.
Darwin/OS X/macOS for x86-64 uses the TSC for timekeeping; it normally calibrates this by querying various clock frequency scaling MSRs. Details depend on the exact CPU model detected. The local APIC timer frequency is extracted from (EFI) firmware.
This is problematic in the presence of virtualisation, as the MSRs in question are typically not handled by the hypervisor. VMWare (Fusion) advertises TSC and APIC frequency via a custom 0x40000010 CPUID leaf, in the eax and ebx registers respectively. This is documented at https://lwn.net/Articles/301888/ among other places.
Darwin/OS X/macOS looks for the generic 0x40000000 hypervisor leaf, and if this indicates via eax that leaf 0x40000010 might be available, that is in turn queried for the two frequencies.
This adds a CPU option "vmware-cpuid-freq" to enable the same behaviour when running Qemu with KVM acceleration, if the KVM TSC frequency can be determined, and it is stable. (invtsc or user-specified) The virtualised APIC bus cycle is hardcoded to 1GHz in KVM, so ebx of the CPUID leaf is also hardcoded to this value.
Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
Message-Id: <1484921496-11257-2-git-send-email-phil@philjordan.eu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.c | 1 +
target/i386/cpu.h | 4 ++++
target/i386/kvm.c | 36 ++++++++++++++++++++++++++++++------
3 files changed, 35 insertions(+), 6 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index cff23e1..e41375e 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3658,6 +3658,7 @@ static Property x86_cpu_properties[] = {
DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true),
DEFINE_PROP_BOOL("lmce", X86CPU, enable_lmce, false),
DEFINE_PROP_BOOL("l3-cache", X86CPU, enable_l3_cache, true),
+ DEFINE_PROP_BOOL("vmware-cpuid-freq", X86CPU, vmware_cpuid_freq, false),
DEFINE_PROP_END_OF_LIST()
};
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 10c5a35..4d788d5 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1214,6 +1214,10 @@ struct X86CPU {
bool host_features;
uint32_t apic_id;
+ /* Enables publishing of TSC increment and Local APIC bus frequencies to
+ * the guest OS in CPUID page 0x40000010, the same way that VMWare does. */
+ bool vmware_cpuid_freq;
+
/* if true the CPUID code directly forward host cache leaves to the guest */
bool cache_info_passthrough;
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 8e130cc..27fd050 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -982,12 +982,6 @@ int kvm_arch_init_vcpu(CPUState *cs)
}
}
- cpuid_data.cpuid.padding = 0;
- r = kvm_vcpu_ioctl(cs, KVM_SET_CPUID2, &cpuid_data);
- if (r) {
- goto fail;
- }
-
r = kvm_arch_set_tsc_khz(cs);
if (r < 0) {
goto fail;
@@ -1007,6 +1001,36 @@ int kvm_arch_init_vcpu(CPUState *cs)
}
}
+ if (cpu->vmware_cpuid_freq
+ /* Guests depend on 0x40000000 to detect this feature, so only expose
+ * it if KVM exposes leaf 0x40000000. (Conflicts with Hyper-V) */
+ && cpu->expose_kvm
+ && kvm_base == KVM_CPUID_SIGNATURE
+ /* TSC clock must be stable and known for this feature. */
+ && ((env->features[FEAT_8000_0007_EDX] & CPUID_APM_INVTSC)
+ || env->user_tsc_khz != 0)
+ && env->tsc_khz != 0) {
+
+ c = &cpuid_data.entries[cpuid_i++];
+ c->function = KVM_CPUID_SIGNATURE | 0x10;
+ c->eax = env->tsc_khz;
+ /* LAPIC resolution of 1ns (freq: 1GHz) is hardcoded in KVM's
+ * APIC_BUS_CYCLE_NS */
+ c->ebx = 1000000;
+ c->ecx = c->edx = 0;
+
+ c = cpuid_find_entry(&cpuid_data.cpuid, kvm_base, 0);
+ c->eax = MAX(c->eax, KVM_CPUID_SIGNATURE | 0x10);
+ }
+
+ cpuid_data.cpuid.nent = cpuid_i;
+
+ cpuid_data.cpuid.padding = 0;
+ r = kvm_vcpu_ioctl(cs, KVM_SET_CPUID2, &cpuid_data);
+ if (r) {
+ goto fail;
+ }
+
if (has_xsave) {
env->kvm_xsave_buf = qemu_memalign(4096, sizeof(struct kvm_xsave));
}
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27
2017-01-27 19:35 [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Paolo Bonzini
2017-01-27 19:35 ` [Qemu-devel] [PULL 18/41] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare Paolo Bonzini
@ 2017-01-30 12:33 ` Laszlo Ersek
2017-01-30 12:57 ` Peter Maydell
2017-01-30 13:24 ` Peter Maydell
2 siblings, 1 reply; 7+ messages in thread
From: Laszlo Ersek @ 2017-01-30 12:33 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, qemu-devel
Peter,
On 01/27/17 20:35, Paolo Bonzini wrote:
> The following changes since commit 29ba0cdc1fd1300f910d150c03a0f74236083bf7:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-01-27' into staging (2017-01-27 15:20:08 +0000)
>
> are available in the git repository at:
>
> git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 6da67de6803e93cbb7e93ac3497865832f8c00ea:
>
> memory: don't sign-extend 32-bit writes (2017-01-27 18:08:00 +0100)
>
Can you please pull this v2? I think it resolves the conflict you
pointed out in
<http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg06092.html>.
The pull request touches a sizeable and diverse set of files (cf. "misc"
in the subject); the more we wait with it the more likely another
conflict emerges. I have firmware patches that depend on my stuff
herein, so if you can find the time, please...
Thank you!
Laszlo
> ----------------------------------------------------------------
> * SCSI max_transfer support for scsi-generic (Eric)
> * x86 SMI broadcast (Laszlo)
> * Character device QOMification (Marc-André)
> * Record/replay improvements (Pavel)
> * iscsi fixes (Peter L.)
> * "info mtree -f" command (Peter Xu)
> * TSC clock rate reporting (Phil)
> * DEVICE_CATEGORY_CPU (Thomas)
> * Memory sign-extension fix (Ladi)
>
> ----------------------------------------------------------------
> Eric Farman (3):
> hw/scsi: Fix debug message of cdb structure in scsi-generic
> block: Fix target variable of BLKSECTGET ioctl
> block: get max_transfer limit for char (scsi-generic) devices
>
> Ladi Prosek (1):
> memory: don't sign-extend 32-bit writes
>
> Laszlo Ersek (3):
> hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg
> hw/isa/lpc_ich9: add broadcast SMI feature
> hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types
>
> Marc-André Lureau (20):
> tests: fix linking test-char on win32
> qemu-options: stdio is available on win32
> char: add qemu_chr_fe_add_watch() Returns description
> doc: fix spelling
> char: use a const CharDriver
> char: use a static array for backends
> char: move callbacks in CharDriver
> char: fold single-user functions in caller
> char: introduce generic qemu_chr_get_kind()
> char: use a feature bit for replay
> char: allocate CharDriverState as a single object
> bt: use qemu_chr_alloc()
> char: rename CharDriverState Chardev
> char: rename TCPChardev and NetChardev
> spice-char: improve error reporting
> char: use error_report()
> gtk: overwrite the console.c char driver
> baum: use a common prefix for chr callbacks
> vc: use a common prefix for chr callbacks
> chardev: qom-ify
>
> Pavel Dovgalyuk (7):
> icount: update instruction counter on apic patching
> replay: improve interrupt handling
> replay: don't use rtc clock on loadvm phase
> savevm: add public save_vmstate function
> replay: save/load initial state
> replay: exception replay fix
> apic: save apic_delivered flag
>
> Peter Lieven (2):
> block/iscsi: avoid data corruption with cache=writeback
> block/iscsi: statically link qemu_iscsi_opts
>
> Peter Xu (2):
> memory: tune mtree_print_mr() to dump mr type
> memory: hmp: add "-f" for "info mtree"
>
> Phil Dennis-Jordan (2):
> x86-KVM: Supply TSC and APIC clock rates to guest like VMWare
> pc: Enable vmware-cpuid-freq CPU option for 2.9+ machine types
>
> Thomas Huth (1):
> Introduce DEVICE_CATEGORY_CPU for CPU devices
>
> MAINTAINERS | 1 +
> backends/baum.c | 102 +-
> backends/msmouse.c | 77 +-
> backends/rng-egd.c | 4 +-
> backends/testdev.c | 53 +-
> block/Makefile.objs | 1 +
> block/file-posix.c | 19 +-
> block/iscsi-opts.c | 69 ++
> block/iscsi.c | 8 +-
> cpu-exec.c | 2 +-
> docs/replay.txt | 16 +
> exec.c | 2 +-
> gdbstub.c | 45 +-
> hmp-commands-info.hx | 6 +-
> hw/arm/fsl-imx25.c | 2 +-
> hw/arm/fsl-imx31.c | 2 +-
> hw/arm/fsl-imx6.c | 2 +-
> hw/arm/nseries.c | 2 +-
> hw/arm/omap2.c | 2 +-
> hw/arm/pxa2xx.c | 2 +-
> hw/arm/virt.c | 2 +-
> hw/bt/hci-csr.c | 64 +-
> hw/char/escc.c | 2 +-
> hw/char/exynos4210_uart.c | 2 +-
> hw/char/imx_serial.c | 2 +-
> hw/char/mcf_uart.c | 4 +-
> hw/char/omap_uart.c | 6 +-
> hw/char/parallel.c | 2 +-
> hw/char/serial-isa.c | 2 +-
> hw/char/serial.c | 4 +-
> hw/char/sh_serial.c | 2 +-
> hw/char/spapr_vty.c | 2 +-
> hw/char/virtio-console.c | 2 +-
> hw/core/qdev-properties-system.c | 4 +-
> hw/cpu/core.c | 8 +
> hw/display/milkymist-tmu2.c | 2 +-
> hw/display/sm501.c | 2 +-
> hw/i386/kvmvapic.c | 6 +
> hw/intc/apic_common.c | 33 +
> hw/isa/isa-bus.c | 2 +-
> hw/isa/lpc_ich9.c | 91 +-
> hw/isa/pc87312.c | 2 +-
> hw/lm32/lm32.h | 4 +-
> hw/lm32/milkymist-hw.h | 2 +-
> hw/mips/mips_malta.c | 4 +-
> hw/misc/ivshmem.c | 2 +-
> hw/misc/milkymist-pfpu.c | 2 +-
> hw/scsi/scsi-generic.c | 5 +-
> hw/timer/mc146818rtc.c | 15 +-
> hw/usb/ccid-card-passthru.c | 2 +-
> hw/usb/dev-serial.c | 6 +-
> hw/usb/redirect.c | 4 +-
> include/block/block.h | 1 +
> include/exec/memory.h | 2 +-
> include/hw/arm/exynos4210.h | 2 +-
> include/hw/arm/omap.h | 6 +-
> include/hw/bt.h | 4 +-
> include/hw/char/cadence_uart.h | 2 +-
> include/hw/char/escc.h | 2 +-
> include/hw/char/pl011.h | 4 +-
> include/hw/char/serial.h | 4 +-
> include/hw/char/xilinx_uartlite.h | 2 +-
> include/hw/cris/etraxfs.h | 2 +-
> include/hw/devices.h | 2 +-
> include/hw/i386/apic_internal.h | 2 +
> include/hw/i386/ich9.h | 13 +
> include/hw/i386/pc.h | 12 +-
> include/hw/m68k/mcf.h | 4 +-
> include/hw/ppc/spapr_vio.h | 2 +-
> include/hw/qdev-core.h | 1 +
> include/hw/qdev-properties.h | 2 +-
> include/hw/sh4/sh.h | 2 +-
> include/hw/sparc/grlib.h | 2 +-
> include/hw/xen/xen.h | 2 +-
> include/monitor/monitor.h | 2 +-
> include/qemu/typedefs.h | 2 +-
> include/sysemu/char.h | 155 +--
> include/sysemu/replay.h | 13 +-
> include/sysemu/sysemu.h | 5 +-
> include/ui/console.h | 2 +
> include/ui/gtk.h | 2 +-
> include/ui/qemu-spice.h | 2 +-
> memory.c | 89 +-
> migration/savevm.c | 33 +-
> monitor.c | 10 +-
> net/colo-compare.c | 4 +-
> net/filter-mirror.c | 4 +-
> net/slirp.c | 2 +-
> net/vhost-user.c | 10 +-
> qdev-monitor.c | 1 +
> qemu-char.c | 1914 ++++++++++++++++++++-----------------
> qemu-options.hx | 12 +-
> qmp.c | 2 +-
> qom/cpu.c | 1 +
> qtest.c | 2 +-
> replay/replay-char.c | 8 +-
> replay/replay-snapshot.c | 17 +
> replay/replay.c | 5 +
> spice-qemu-char.c | 231 +++--
> stubs/monitor.c | 2 +-
> stubs/replay.c | 4 +-
> target/i386/cpu.c | 1 +
> target/i386/cpu.h | 4 +
> target/i386/kvm.c | 36 +-
> target/i386/seg_helper.c | 1 +
> tests/Makefile.include | 2 +-
> tests/test-char.c | 10 +-
> tests/vhost-user-test.c | 4 +-
> translate-all.c | 2 +
> ui/console.c | 111 ++-
> ui/gtk.c | 86 +-
> vl.c | 59 +-
> xen-common-stub.c | 2 +-
> xen-common.c | 4 +-
> 114 files changed, 2192 insertions(+), 1448 deletions(-)
> create mode 100644 block/iscsi-opts.c
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27
2017-01-30 12:33 ` [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Laszlo Ersek
@ 2017-01-30 12:57 ` Peter Maydell
2017-01-30 13:29 ` Laszlo Ersek
0 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2017-01-30 12:57 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: Paolo Bonzini, QEMU Developers
On 30 January 2017 at 12:33, Laszlo Ersek <lersek@redhat.com> wrote:
> Peter,
>
> On 01/27/17 20:35, Paolo Bonzini wrote:
>> The following changes since commit 29ba0cdc1fd1300f910d150c03a0f74236083bf7:
>>
>> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-01-27' into staging (2017-01-27 15:20:08 +0000)
>>
>> are available in the git repository at:
>>
>> git://github.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to 6da67de6803e93cbb7e93ac3497865832f8c00ea:
>>
>> memory: don't sign-extend 32-bit writes (2017-01-27 18:08:00 +0100)
>>
>
> Can you please pull this v2?
I am currently processing it, yes. Paolo only sent it to the list
late on Friday evening, and I don't generally work weekends,
so it's not like this has been lying around for a long time...
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27
2017-01-27 19:35 [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Paolo Bonzini
2017-01-27 19:35 ` [Qemu-devel] [PULL 18/41] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare Paolo Bonzini
2017-01-30 12:33 ` [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Laszlo Ersek
@ 2017-01-30 13:24 ` Peter Maydell
2 siblings, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2017-01-30 13:24 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers
On 27 January 2017 at 19:35, Paolo Bonzini <pbonzini@redhat.com> wrote:
> The following changes since commit 29ba0cdc1fd1300f910d150c03a0f74236083bf7:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-01-27' into staging (2017-01-27 15:20:08 +0000)
>
> are available in the git repository at:
>
> git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 6da67de6803e93cbb7e93ac3497865832f8c00ea:
>
> memory: don't sign-extend 32-bit writes (2017-01-27 18:08:00 +0100)
>
> ----------------------------------------------------------------
> * SCSI max_transfer support for scsi-generic (Eric)
> * x86 SMI broadcast (Laszlo)
> * Character device QOMification (Marc-André)
> * Record/replay improvements (Pavel)
> * iscsi fixes (Peter L.)
> * "info mtree -f" command (Peter Xu)
> * TSC clock rate reporting (Phil)
> * DEVICE_CATEGORY_CPU (Thomas)
> * Memory sign-extension fix (Ladi)
>
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27
2017-01-30 12:57 ` Peter Maydell
@ 2017-01-30 13:29 ` Laszlo Ersek
2017-01-30 13:35 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Laszlo Ersek @ 2017-01-30 13:29 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, QEMU Developers
On 01/30/17 13:57, Peter Maydell wrote:
> On 30 January 2017 at 12:33, Laszlo Ersek <lersek@redhat.com> wrote:
>> Peter,
>>
>> On 01/27/17 20:35, Paolo Bonzini wrote:
>>> The following changes since commit 29ba0cdc1fd1300f910d150c03a0f74236083bf7:
>>>
>>> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-01-27' into staging (2017-01-27 15:20:08 +0000)
>>>
>>> are available in the git repository at:
>>>
>>> git://github.com/bonzini/qemu.git tags/for-upstream
>>>
>>> for you to fetch changes up to 6da67de6803e93cbb7e93ac3497865832f8c00ea:
>>>
>>> memory: don't sign-extend 32-bit writes (2017-01-27 18:08:00 +0100)
>>>
>>
>> Can you please pull this v2?
>
> I am currently processing it, yes. Paolo only sent it to the list
Apologies, I missed that.
> late on Friday evening, and I don't generally work weekends,
I didn't try to imply that you should have -- I also don't check my work
email over the weekend, on purpose. I check the occasional public list
archive, maybe.
> so it's not like this has been lying around for a long time...
Yeah I was conflicted whether I should ping you or not... The very first
version of the patches goes back to October 2015; I may have gotten
over-enthusiastic about the feature being finally merged, and possibly
made the wrong call. Sorry.
(BTW I know about <http://patchew.org/QEMU/>, and for the v1 pull req, I
did notice quickly enough the conflict ("Failed in applying to current
master"), even before reading your feedback on-list; but for v2, patchew
only says "Series not complete".)
It's difficult to ask politely in email... I tend to start with
apologizing and various disclaimers, saying "please" and "thank you"
profusely, but I've also been told that I should be more "assertive"...
Sigh.
Thank you anyway, and sorry about the poke. It was meant in good faith.
Laszlo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27
2017-01-30 13:29 ` Laszlo Ersek
@ 2017-01-30 13:35 ` Peter Maydell
0 siblings, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2017-01-30 13:35 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: Paolo Bonzini, QEMU Developers
On 30 January 2017 at 13:29, Laszlo Ersek <lersek@redhat.com> wrote:
> Yeah I was conflicted whether I should ping you or not... The very first
> version of the patches goes back to October 2015; I may have gotten
> over-enthusiastic about the feature being finally merged, and possibly
> made the wrong call. Sorry.
> It's difficult to ask politely in email... I tend to start with
> apologizing and various disclaimers, saying "please" and "thank you"
> profusely, but I've also been told that I should be more "assertive"...
> Sigh.
>
> Thank you anyway, and sorry about the poke. It was meant in good faith.
No problem; I should probably have been a bit clearer that I
wasn't strongly objecting to being nudged here, merely noting
that it wasn't really necessary just yet. Sorry for being
unnecessarily grumpy.
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-30 13:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-27 19:35 [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Paolo Bonzini
2017-01-27 19:35 ` [Qemu-devel] [PULL 18/41] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare Paolo Bonzini
2017-01-30 12:33 ` [Qemu-devel] [PULL v2 00/41] Misc patches for 2017-01-27 Laszlo Ersek
2017-01-30 12:57 ` Peter Maydell
2017-01-30 13:29 ` Laszlo Ersek
2017-01-30 13:35 ` Peter Maydell
2017-01-30 13:24 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.