From: Rob Herring <robh@kernel.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Mark Rutland" <mark.rutland@arm.com>,
"Tsahee Zidenberg" <tsahee@annapurnalabs.com>,
"Antoine Tenart" <antoine.tenart@free-electrons.com>,
"Russell King" <linux@armlinux.org.uk>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Simon Horman" <horms@verge.net.au>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Chen-Yu Tsai" <wens@csie.org>,
arm@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC
Date: Fri, 27 Jan 2017 14:30:01 -0600 [thread overview]
Message-ID: <20170127203001.qvlgzzrh5hx2pykf@rob-hp-laptop> (raw)
In-Reply-To: <1485186974-13678-2-git-send-email-marc.zyngier@arm.com>
On Mon, Jan 23, 2017 at 03:56:13PM +0000, Marc Zyngier wrote:
> The joys of copy/paste: the example of a virtualization capable GIC
> in the DT binding was wrong, and propagated to dozens of platforms.
> By having a GICC region that is only 4kB (instead of 8kB), we
> end-up not being able to access the GICC_DIR register which is on
> the second page.
>
> Oh well. Let's fix the source of the crap before tackling individual
> offenders. While we're at it, also fix the compatibility string to
> mention "arm,gic-400", which is the name of the actual implementation
> of the GICv2 spec.
"While we're at it", code for should be in a separate patch. :) I
wouldn't really care here, but you are not fixing anything...
>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> index 5393e2a..a3d51ed 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> @@ -107,11 +107,11 @@ Required properties:
> Example:
>
> interrupt-controller@2c001000 {
> - compatible = "arm,cortex-a15-gic";
> + compatible = "arm,gic-400";
Which one is correct really depends on the platform. The A15 can have an
internal or external (gic-400) GIC. The former string is correct for an
A15 with an internal GIC. One such platform is Calxeda midway.
Arguably, we should not have arm,gic-400 by itself, but have an SoC
specific compatible in case it was integrated in interesting ways.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Tony Lindgren" <tony@atomide.com>,
arm@kernel.org, "Magnus Damm" <magnus.damm@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Kukjin Kim" <kgene@kernel.org>,
"Tsahee Zidenberg" <tsahee@annapurnalabs.com>,
devicetree@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
"Simon Horman" <horms@verge.net.au>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Sascha Hauer" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Antoine Tenart" <antoine.tenart@free-electrons.com>,
linux-kernel@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
"Fabio Estevam" <fabio.estevam@nxp.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC
Date: Fri, 27 Jan 2017 14:30:01 -0600 [thread overview]
Message-ID: <20170127203001.qvlgzzrh5hx2pykf@rob-hp-laptop> (raw)
In-Reply-To: <1485186974-13678-2-git-send-email-marc.zyngier@arm.com>
On Mon, Jan 23, 2017 at 03:56:13PM +0000, Marc Zyngier wrote:
> The joys of copy/paste: the example of a virtualization capable GIC
> in the DT binding was wrong, and propagated to dozens of platforms.
> By having a GICC region that is only 4kB (instead of 8kB), we
> end-up not being able to access the GICC_DIR register which is on
> the second page.
>
> Oh well. Let's fix the source of the crap before tackling individual
> offenders. While we're at it, also fix the compatibility string to
> mention "arm,gic-400", which is the name of the actual implementation
> of the GICv2 spec.
"While we're at it", code for should be in a separate patch. :) I
wouldn't really care here, but you are not fixing anything...
>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> index 5393e2a..a3d51ed 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> @@ -107,11 +107,11 @@ Required properties:
> Example:
>
> interrupt-controller@2c001000 {
> - compatible = "arm,cortex-a15-gic";
> + compatible = "arm,gic-400";
Which one is correct really depends on the platform. The A15 can have an
internal or external (gic-400) GIC. The former string is correct for an
A15 with an internal GIC. One such platform is Calxeda midway.
Arguably, we should not have arm,gic-400 by itself, but have an SoC
specific compatible in case it was integrated in interesting ways.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC
Date: Fri, 27 Jan 2017 14:30:01 -0600 [thread overview]
Message-ID: <20170127203001.qvlgzzrh5hx2pykf@rob-hp-laptop> (raw)
In-Reply-To: <1485186974-13678-2-git-send-email-marc.zyngier@arm.com>
On Mon, Jan 23, 2017 at 03:56:13PM +0000, Marc Zyngier wrote:
> The joys of copy/paste: the example of a virtualization capable GIC
> in the DT binding was wrong, and propagated to dozens of platforms.
> By having a GICC region that is only 4kB (instead of 8kB), we
> end-up not being able to access the GICC_DIR register which is on
> the second page.
>
> Oh well. Let's fix the source of the crap before tackling individual
> offenders. While we're at it, also fix the compatibility string to
> mention "arm,gic-400", which is the name of the actual implementation
> of the GICv2 spec.
"While we're at it", code for should be in a separate patch. :) I
wouldn't really care here, but you are not fixing anything...
>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> index 5393e2a..a3d51ed 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> @@ -107,11 +107,11 @@ Required properties:
> Example:
>
> interrupt-controller at 2c001000 {
> - compatible = "arm,cortex-a15-gic";
> + compatible = "arm,gic-400";
Which one is correct really depends on the platform. The A15 can have an
internal or external (gic-400) GIC. The former string is correct for an
A15 with an internal GIC. One such platform is Calxeda midway.
Arguably, we should not have arm,gic-400 by itself, but have an SoC
specific compatible in case it was integrated in interesting ways.
Rob
next prev parent reply other threads:[~2017-01-27 20:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 15:56 [PATCH v2 0/2] ARM: DTS: Fix broken GICv2 register maps Marc Zyngier
2017-01-23 15:56 ` Marc Zyngier
2017-01-23 15:56 ` Marc Zyngier
2017-01-23 15:56 ` [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC Marc Zyngier
2017-01-23 15:56 ` [PATCH v2 1/2] dt-bindings: arm, gic: " Marc Zyngier
2017-01-23 15:56 ` [PATCH v2 1/2] dt-bindings: arm,gic: " Marc Zyngier
2017-01-27 20:30 ` Rob Herring [this message]
2017-01-27 20:30 ` Rob Herring
2017-01-27 20:30 ` Rob Herring
2017-01-29 22:51 ` Olof Johansson
2017-01-29 22:51 ` Olof Johansson
2017-01-29 22:51 ` Olof Johansson
2017-01-30 8:41 ` Marc Zyngier
2017-01-30 8:41 ` Marc Zyngier
2017-01-30 8:41 ` Marc Zyngier
2017-01-23 15:56 ` [PATCH v2 2/2] ARM: DTS: Fix register map for " Marc Zyngier
2017-01-23 15:56 ` Marc Zyngier
2017-01-23 15:56 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127203001.qvlgzzrh5hx2pykf@rob-hp-laptop \
--to=robh@kernel.org \
--cc=antoine.tenart@free-electrons.com \
--cc=arm@kernel.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=heiko@sntech.de \
--cc=horms@verge.net.au \
--cc=jason@lakedaemon.net \
--cc=javier@osg.samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=shawnguo@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=tsahee@annapurnalabs.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.