From: Jason Cooper <jason@lakedaemon.net>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: mvebu: Handle changes to the bridge windows while enabled
Date: Mon, 30 Jan 2017 14:34:18 +0000 [thread overview]
Message-ID: <20170130143418.GB25924@io.lakedaemon.net> (raw)
In-Reply-To: <20170128211728.GJ20550@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Sat, Jan 28, 2017 at 03:17:28PM -0600, Bjorn Helgaas wrote:
> On Wed, Jan 11, 2017 at 12:30:55PM -0600, Bjorn Helgaas wrote:
> > On Mon, Dec 12, 2016 at 11:30:20AM -0700, Jason Gunthorpe wrote:
> > > The PCI core will write to the bridge window config multiple times
> > > while they are enabled. This can lead to mbus failures like:
> > >
> > > mvebu_mbus: cannot add window '4:e8', conflicts with another window
> > > mvebu-pcie mbus:pex@e0000000: Could not create MBus window at [mem 0xe0000000-0xe00fffff]: -22
> > >
> > > For me this is happening during a hotplug cycle. The PCI core is
> > > not changing the values, just writing them twice while active.
> > >
> > > The patch addresses the general case of any change to an active window,
> > > but not atomically. The code is slightly refactored so io and mem
> > > can share more of the window logic.
> >
> > Looks good to me, but I'm waiting for an ack from Thomas or Jason (listed
> > as maintainers and already cc'd).
>
> Ping, Thomas, Jason C?
>
> > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > > ---
> > > drivers/pci/host/pci-mvebu.c | 101 +++++++++++++++++++++++++------------------
> > > 1 file changed, 60 insertions(+), 41 deletions(-)
Sorry, been on travel and I think Thomas is on holiday.
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
WARNING: multiple messages have this Message-ID (diff)
From: Jason Cooper <jason@lakedaemon.net>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: mvebu: Handle changes to the bridge windows while enabled
Date: Mon, 30 Jan 2017 14:34:18 +0000 [thread overview]
Message-ID: <20170130143418.GB25924@io.lakedaemon.net> (raw)
In-Reply-To: <20170128211728.GJ20550@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Sat, Jan 28, 2017 at 03:17:28PM -0600, Bjorn Helgaas wrote:
> On Wed, Jan 11, 2017 at 12:30:55PM -0600, Bjorn Helgaas wrote:
> > On Mon, Dec 12, 2016 at 11:30:20AM -0700, Jason Gunthorpe wrote:
> > > The PCI core will write to the bridge window config multiple times
> > > while they are enabled. This can lead to mbus failures like:
> > >
> > > mvebu_mbus: cannot add window '4:e8', conflicts with another window
> > > mvebu-pcie mbus:pex@e0000000: Could not create MBus window at [mem 0xe0000000-0xe00fffff]: -22
> > >
> > > For me this is happening during a hotplug cycle. The PCI core is
> > > not changing the values, just writing them twice while active.
> > >
> > > The patch addresses the general case of any change to an active window,
> > > but not atomically. The code is slightly refactored so io and mem
> > > can share more of the window logic.
> >
> > Looks good to me, but I'm waiting for an ack from Thomas or Jason (listed
> > as maintainers and already cc'd).
>
> Ping, Thomas, Jason C?
>
> > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > > ---
> > > drivers/pci/host/pci-mvebu.c | 101 +++++++++++++++++++++++++------------------
> > > 1 file changed, 60 insertions(+), 41 deletions(-)
Sorry, been on travel and I think Thomas is on holiday.
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: mvebu: Handle changes to the bridge windows while enabled
Date: Mon, 30 Jan 2017 14:34:18 +0000 [thread overview]
Message-ID: <20170130143418.GB25924@io.lakedaemon.net> (raw)
In-Reply-To: <20170128211728.GJ20550@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Sat, Jan 28, 2017 at 03:17:28PM -0600, Bjorn Helgaas wrote:
> On Wed, Jan 11, 2017 at 12:30:55PM -0600, Bjorn Helgaas wrote:
> > On Mon, Dec 12, 2016 at 11:30:20AM -0700, Jason Gunthorpe wrote:
> > > The PCI core will write to the bridge window config multiple times
> > > while they are enabled. This can lead to mbus failures like:
> > >
> > > mvebu_mbus: cannot add window '4:e8', conflicts with another window
> > > mvebu-pcie mbus:pex at e0000000: Could not create MBus window at [mem 0xe0000000-0xe00fffff]: -22
> > >
> > > For me this is happening during a hotplug cycle. The PCI core is
> > > not changing the values, just writing them twice while active.
> > >
> > > The patch addresses the general case of any change to an active window,
> > > but not atomically. The code is slightly refactored so io and mem
> > > can share more of the window logic.
> >
> > Looks good to me, but I'm waiting for an ack from Thomas or Jason (listed
> > as maintainers and already cc'd).
>
> Ping, Thomas, Jason C?
>
> > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > > ---
> > > drivers/pci/host/pci-mvebu.c | 101 +++++++++++++++++++++++++------------------
> > > 1 file changed, 60 insertions(+), 41 deletions(-)
Sorry, been on travel and I think Thomas is on holiday.
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
next prev parent reply other threads:[~2017-01-30 14:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 18:30 [PATCH] PCI: mvebu: Handle changes to the bridge windows while enabled Jason Gunthorpe
2016-12-12 18:30 ` Jason Gunthorpe
2017-01-11 18:30 ` Bjorn Helgaas
2017-01-11 18:30 ` Bjorn Helgaas
2017-01-11 18:30 ` Bjorn Helgaas
2017-01-28 21:17 ` Bjorn Helgaas
2017-01-28 21:17 ` Bjorn Helgaas
2017-01-28 21:17 ` Bjorn Helgaas
2017-01-30 14:34 ` Jason Cooper [this message]
2017-01-30 14:34 ` Jason Cooper
2017-01-30 14:34 ` Jason Cooper
2017-01-30 15:41 ` Bjorn Helgaas
2017-01-30 15:41 ` Bjorn Helgaas
2017-01-30 15:41 ` Bjorn Helgaas
2017-01-30 16:51 ` Jason Gunthorpe
2017-01-30 16:51 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130143418.GB25924@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=bhelgaas@google.com \
--cc=gregory.clement@free-electrons.com \
--cc=helgaas@kernel.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.