From: Mel Gorman <mgorman@suse.de>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, vbabka@suse.cz, minchan@kernel.org,
aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com,
srikar@linux.vnet.ibm.com, haren@linux.vnet.ibm.com,
jglisse@redhat.com, dave.hansen@intel.com,
dan.j.williams@intel.com
Subject: Re: [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init()
Date: Mon, 30 Jan 2017 20:30:03 +0000 [thread overview]
Message-ID: <20170130203003.dm2ydoi3e6cbbwcj@suse.de> (raw)
In-Reply-To: <20170130033602.12275-6-khandual@linux.vnet.ibm.com>
On Mon, Jan 30, 2017 at 09:05:46AM +0530, Anshuman Khandual wrote:
> Currently cpusets_enabled() wrongfully returns 0 even if we have a root
> cpuset configured on the system. This got missed when jump level was
> introduced in place of number_of_cpusets with the commit 664eeddeef65
> ("mm: page_alloc: use jump labels to avoid checking number_of_cpusets")
> . This fixes the problem so that cpusets_enabled() returns positive even
> for the root cpuset.
>
> Fixes: 664eeddeef65 ("mm: page_alloc: use jump labels to avoid")
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Superficially, this appears to always activate the cpuset_enabled
branch() when it doesn't really make sense that the root cpuset be
restricted. I strongly suspect it should be altered to cpuset_inc only
if the root cpuset is configured to isolate memory.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, vbabka@suse.cz, minchan@kernel.org,
aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com,
srikar@linux.vnet.ibm.com, haren@linux.vnet.ibm.com,
jglisse@redhat.com, dave.hansen@intel.com,
dan.j.williams@intel.com
Subject: Re: [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init()
Date: Mon, 30 Jan 2017 20:30:03 +0000 [thread overview]
Message-ID: <20170130203003.dm2ydoi3e6cbbwcj@suse.de> (raw)
In-Reply-To: <20170130033602.12275-6-khandual@linux.vnet.ibm.com>
On Mon, Jan 30, 2017 at 09:05:46AM +0530, Anshuman Khandual wrote:
> Currently cpusets_enabled() wrongfully returns 0 even if we have a root
> cpuset configured on the system. This got missed when jump level was
> introduced in place of number_of_cpusets with the commit 664eeddeef65
> ("mm: page_alloc: use jump labels to avoid checking number_of_cpusets")
> . This fixes the problem so that cpusets_enabled() returns positive even
> for the root cpuset.
>
> Fixes: 664eeddeef65 ("mm: page_alloc: use jump labels to avoid")
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Superficially, this appears to always activate the cpuset_enabled
branch() when it doesn't really make sense that the root cpuset be
restricted. I strongly suspect it should be altered to cpuset_inc only
if the root cpuset is configured to isolate memory.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-30 20:43 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 3:35 [RFC V2 00/12] Define coherent device memory node Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 01/12] mm: Define coherent device memory (CDM) node Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 02/12] mm: Isolate HugeTLB allocations away from CDM nodes Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 17:19 ` Dave Hansen
2017-01-30 17:19 ` Dave Hansen
2017-01-31 1:03 ` Anshuman Khandual
2017-01-31 1:03 ` Anshuman Khandual
2017-01-31 1:37 ` Dave Hansen
2017-01-31 1:37 ` Dave Hansen
2017-02-01 13:59 ` Anshuman Khandual
2017-02-01 13:59 ` Anshuman Khandual
2017-02-01 19:01 ` Dave Hansen
2017-02-01 19:01 ` Dave Hansen
2017-01-30 3:35 ` [RFC V2 03/12] mm: Change generic FALLBACK zonelist creation process Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 17:34 ` Dave Hansen
2017-01-30 17:34 ` Dave Hansen
2017-01-31 1:36 ` Anshuman Khandual
2017-01-31 1:36 ` Anshuman Khandual
2017-01-31 1:57 ` Dave Hansen
2017-01-31 1:57 ` Dave Hansen
2017-01-31 7:25 ` John Hubbard
2017-01-31 7:25 ` John Hubbard
2017-01-31 18:04 ` Dave Hansen
2017-01-31 18:04 ` Dave Hansen
2017-01-31 19:14 ` David Nellans
2017-01-31 19:14 ` David Nellans
2017-02-01 6:56 ` Anshuman Khandual
2017-02-01 6:56 ` Anshuman Khandual
2017-02-01 6:46 ` Anshuman Khandual
2017-02-01 6:46 ` Anshuman Khandual
2017-02-01 6:40 ` Anshuman Khandual
2017-02-01 6:40 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 04/12] mm: Change mbind(MPOL_BIND) implementation for CDM nodes Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 17:36 ` Dave Hansen
2017-01-30 17:36 ` Dave Hansen
2017-01-30 20:30 ` Mel Gorman [this message]
2017-01-30 20:30 ` Mel Gorman
2017-01-31 14:22 ` [RFC] cpuset: Enable changing of top_cpuset's mems_allowed nodemask Anshuman Khandual
2017-01-31 14:22 ` Anshuman Khandual
2017-01-31 16:00 ` Mel Gorman
2017-01-31 16:00 ` Mel Gorman
2017-02-01 7:31 ` Anshuman Khandual
2017-02-01 7:31 ` Anshuman Khandual
2017-02-01 8:53 ` Michal Hocko
2017-02-01 8:53 ` Michal Hocko
2017-02-01 9:18 ` Mel Gorman
2017-02-01 9:18 ` Mel Gorman
2017-01-31 14:36 ` [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() Vlastimil Babka
2017-01-31 14:36 ` Vlastimil Babka
2017-01-31 15:30 ` Anshuman Khandual
2017-01-31 15:30 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 06/12] mm: Exclude CDM nodes from task->mems_allowed and root cpuset Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 07/12] mm: Ignore cpuset enforcement when allocation flag has __GFP_THISNODE Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 08/12] mm: Add new VMA flag VM_CDM Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 18:52 ` Jerome Glisse
2017-01-30 18:52 ` Jerome Glisse
2017-01-31 4:22 ` Anshuman Khandual
2017-01-31 4:22 ` Anshuman Khandual
2017-01-31 6:05 ` Jerome Glisse
2017-01-31 6:05 ` Jerome Glisse
2017-01-30 3:35 ` [RFC V2 09/12] mm: Exclude CDM marked VMAs from auto NUMA Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 10/12] mm: Ignore madvise(MADV_MERGEABLE) request for VM_CDM marked VMAs Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 11/12] mm: Tag VMA with VM_CDM flag during page fault Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 17:51 ` Dave Hansen
2017-01-30 17:51 ` Dave Hansen
2017-01-31 5:10 ` Anshuman Khandual
2017-01-31 5:10 ` Anshuman Khandual
2017-01-31 17:54 ` Dave Hansen
2017-01-31 17:54 ` Dave Hansen
2017-01-30 3:35 ` [RFC V2 12/12] mm: Tag VMA with VM_CDM flag explicitly during mbind(MPOL_BIND) Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 17:54 ` Dave Hansen
2017-01-30 17:54 ` Dave Hansen
2017-01-31 4:36 ` Anshuman Khandual
2017-01-31 4:36 ` Anshuman Khandual
2017-02-07 18:07 ` Dave Hansen
2017-02-07 18:07 ` Dave Hansen
2017-02-08 14:13 ` Anshuman Khandual
2017-02-08 14:13 ` Anshuman Khandual
2017-02-08 15:04 ` Jerome Glisse
2017-02-08 15:04 ` Jerome Glisse
2017-01-30 3:35 ` [DEBUG 13/21] powerpc/mm: Identify coherent device memory nodes during platform init Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 14/21] powerpc/mm: Create numa nodes for hotplug memory Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 15/21] powerpc/mm: Enable CONFIG_MOVABLE_NODE for PPC64 platform Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 16/21] mm: Enable CONFIG_MOVABLE_NODE on powerpc Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 17/21] mm: Export definition of 'zone_names' array through mmzone.h Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 18/21] mm: Add debugfs interface to dump each node's zonelist information Anshuman Khandual
2017-01-30 3:35 ` Anshuman Khandual
2017-01-30 3:36 ` [DEBUG 19/21] mm: Add migrate_virtual_range migration interface Anshuman Khandual
2017-01-30 3:36 ` Anshuman Khandual
2017-01-30 3:36 ` [DEBUG 20/21] drivers: Add two drivers for coherent device memory tests Anshuman Khandual
2017-01-30 3:36 ` Anshuman Khandual
2017-01-30 3:36 ` [DEBUG 21/21] selftests/powerpc: Add a script to perform random VMA migrations Anshuman Khandual
2017-01-30 3:36 ` Anshuman Khandual
2017-01-31 5:48 ` [RFC V2 00/12] Define coherent device memory node Anshuman Khandual
2017-01-31 5:48 ` Anshuman Khandual
2017-01-31 6:15 ` Jerome Glisse
2017-01-31 6:15 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130203003.dm2ydoi3e6cbbwcj@suse.de \
--to=mgorman@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=haren@linux.vnet.ibm.com \
--cc=jglisse@redhat.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.