[PATCH xf86-video-ati] Don't handle Option "SwapbuffersWait" at all with glamor

[PATCH xf86-video-ati] Don't handle Option "SwapbuffersWait" at all with glamor

[Michel Dänzer]

From: Michel Dänzer <michel.daenzer@amd.com>

It never had any effect with glamor.

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 src/radeon_kms.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/radeon_kms.c b/src/radeon_kms.c
index 446852564..58efd6ee5 100644
--- a/src/radeon_kms.c
+++ b/src/radeon_kms.c
@@ -1801,10 +1801,12 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int flags)
 	}
     }
 
-    info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
-						 OPTION_SWAPBUFFERS_WAIT, TRUE);
-    xf86DrvMsg(pScrn->scrnIndex, X_INFO,
-	       "SwapBuffers wait for vsync: %sabled\n", info->swapBuffersWait ? "en" : "dis");
+    if (!info->use_glamor) {
+	info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
+						     OPTION_SWAPBUFFERS_WAIT, TRUE);
+	xf86DrvMsg(pScrn->scrnIndex, X_INFO,
+		   "SwapBuffers wait for vsync: %sabled\n", info->swapBuffersWait ? "en" : "dis");
+    }
 
     if (xf86ReturnOptValBool(info->Options, OPTION_DELETE_DP12, FALSE)) {
         info->drmmode.delete_dp_12_displays = TRUE;
-- 
2.11.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH xf86-video-ati] Don't handle Option "SwapbuffersWait" at all with glamor

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Tuesday, January 31, 2017 2:28 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-ati] Don't handle Option "SwapbuffersWait" at all
> with glamor
> 
> From: Michel Dänzer <michel.daenzer@amd.com>
> 
> It never had any effect with glamor.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>

Good catch!

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  src/radeon_kms.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/src/radeon_kms.c b/src/radeon_kms.c
> index 446852564..58efd6ee5 100644
> --- a/src/radeon_kms.c
> +++ b/src/radeon_kms.c
> @@ -1801,10 +1801,12 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int
> flags)
>  	}
>      }
> 
> -    info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
> -
> OPTION_SWAPBUFFERS_WAIT, TRUE);
> -    xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> -	       "SwapBuffers wait for vsync: %sabled\n", info->swapBuffersWait
> ? "en" : "dis");
> +    if (!info->use_glamor) {
> +	info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
> +
> OPTION_SWAPBUFFERS_WAIT, TRUE);
> +	xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> +		   "SwapBuffers wait for vsync: %sabled\n", info-
> >swapBuffersWait ? "en" : "dis");
> +    }
> 
>      if (xf86ReturnOptValBool(info->Options, OPTION_DELETE_DP12, FALSE)) {
>          info->drmmode.delete_dp_12_displays = TRUE;
> --
> 2.11.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx