All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc
@ 2017-01-31  6:18 Dhinakaran Pandiyan
  2017-01-31  6:55 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-01-31  8:34 ` [PATCH] " Daniel Vetter
  0 siblings, 2 replies; 3+ messages in thread
From: Dhinakaran Pandiyan @ 2017-01-31  6:18 UTC (permalink / raw)
  To: dri-devel; +Cc: Daniel Vetter, intel-gfx, Dhinakaran Pandiyan, Daniel Stone

drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state
but documentation claims otherwise, fix that.

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 drivers/gpu/drm/drm_atomic.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 78b54df..25944ab 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -322,9 +322,8 @@ static s32 __user *get_out_fence_for_crtc(struct drm_atomic_state *state,
  * @state: the CRTC whose incoming state to update
  * @mode: kernel-internal mode to use for the CRTC, or NULL to disable
  *
- * Set a mode (originating from the kernel) on the desired CRTC state. Does
- * not change any other state properties, including enable, active, or
- * mode_changed.
+ * Set a mode (originating from the kernel) on the desired CRTC state and update
+ * the enable property.
  *
  * RETURNS:
  * Zero on success, error code on failure. Cannot return -EDEADLK.
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc
  2017-01-31  6:18 [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc Dhinakaran Pandiyan
@ 2017-01-31  6:55 ` Patchwork
  2017-01-31  8:34 ` [PATCH] " Daniel Vetter
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-01-31  6:55 UTC (permalink / raw)
  To: Pandiyan, Dhinakaran; +Cc: intel-gfx

== Series Details ==

Series: drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc
URL   : https://patchwork.freedesktop.org/series/18813/
State : success

== Summary ==

Series 18813v1 drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc
https://patchwork.freedesktop.org/api/1.0/series/18813/revisions/1/mbox/

Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                dmesg-warn -> PASS       (fi-snb-2520m)
Test kms_force_connector_basic:
        Subgroup force-connector-state:
                dmesg-warn -> PASS       (fi-snb-2520m)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a:
                dmesg-warn -> PASS       (fi-snb-2520m)

fi-bdw-5557u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-bsw-n3050     total:246  pass:207  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-j4205     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-bxt-t5700     total:78   pass:65   dwarn:0   dfail:0   fail:0   skip:12 
fi-byt-j1900     total:246  pass:219  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
fi-hsw-4770r     total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
fi-ivb-3520m     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
fi-ivb-3770      total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
fi-kbl-7500u     total:246  pass:223  dwarn:0   dfail:0   fail:2   skip:21 
fi-skl-6260u     total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13 
fi-skl-6700hq    total:246  pass:226  dwarn:0   dfail:0   fail:0   skip:20 
fi-skl-6700k     total:246  pass:221  dwarn:4   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13 
fi-snb-2520m     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-snb-2600      total:246  pass:214  dwarn:0   dfail:0   fail:0   skip:32 

123d798c350471aba7e0625c154c6d9e395756c8 drm-tip: 2017y-01m-30d-21h-14m-37s UTC integration manifest
0ca768a drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3648/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc
  2017-01-31  6:18 [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc Dhinakaran Pandiyan
  2017-01-31  6:55 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-01-31  8:34 ` Daniel Vetter
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2017-01-31  8:34 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: Daniel Vetter, intel-gfx, Daniel Stone, dri-devel

On Mon, Jan 30, 2017 at 10:18:38PM -0800, Dhinakaran Pandiyan wrote:
> drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state
> but documentation claims otherwise, fix that.
> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Indeed, thanks for the fix, applied to drm-misc.
-Daniel
> ---
>  drivers/gpu/drm/drm_atomic.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 78b54df..25944ab 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -322,9 +322,8 @@ static s32 __user *get_out_fence_for_crtc(struct drm_atomic_state *state,
>   * @state: the CRTC whose incoming state to update
>   * @mode: kernel-internal mode to use for the CRTC, or NULL to disable
>   *
> - * Set a mode (originating from the kernel) on the desired CRTC state. Does
> - * not change any other state properties, including enable, active, or
> - * mode_changed.
> + * Set a mode (originating from the kernel) on the desired CRTC state and update
> + * the enable property.
>   *
>   * RETURNS:
>   * Zero on success, error code on failure. Cannot return -EDEADLK.
> -- 
> 2.7.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-31  8:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-31  6:18 [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc Dhinakaran Pandiyan
2017-01-31  6:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-01-31  8:34 ` [PATCH] " Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.