* [PATCH] drm/i915: Release the forgotten connector reference
@ 2017-02-01 19:58 Chris Wilson
2017-02-01 20:23 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Chris Wilson @ 2017-02-01 19:58 UTC (permalink / raw)
To: intel-gfx
The reference was gained in
intel_modeset_update_connector_atomic_state() [called from
intel_modeset_setup_hw_state()] and is never lost if no client ever
performs a modeset.
[ 649.836069] WARNING: CPU: 6 PID: 8865 at drivers/gpu/drm/drm_mode_config.c:424 drm_mode_config_cleanup+0x21b/0x290 [drm]
[ 649.836078] Modules linked in: i915(-) intel_gtt drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm
[ 649.836099] CPU: 6 PID: 8865 Comm: drv_selftest Not tainted 4.10.0-rc6+ #908
[ 649.836106] Hardware name: Intel Corporation 2012 Client Platform/Emerald Lake 2, BIOS ACRVMBY1.86C.0078.P00.1201161002 01/16/2012
[ 649.836114] Call Trace:
[ 649.836125] dump_stack+0x4d/0x6f
[ 649.836136] __warn+0xc1/0xe0
[ 649.836144] warn_slowpath_null+0x18/0x20
[ 649.836163] drm_mode_config_cleanup+0x21b/0x290 [drm]
[ 649.836213] intel_modeset_cleanup+0x59/0xa0 [i915]
[ 649.836242] i915_driver_unload+0x84/0x170 [i915]
[ 649.836277] i915_pci_remove+0x14/0x20 [i915]
[ 649.836287] pci_device_remove+0x28/0x60
[ 649.836301] device_release_driver_internal+0x132/0x1d0
[ 649.836313] driver_detach+0x3a/0x80
[ 649.836324] bus_remove_driver+0x47/0xa0
[ 649.836335] driver_unregister+0x27/0x50
[ 649.836344] pci_unregister_driver+0x34/0xa0
[ 649.836387] i915_exit+0x1a/0x71 [i915]
[ 649.836401] SyS_delete_module+0x173/0x1c0
[ 649.836413] entry_SYSCALL_64_fastpath+0x17/0x98
[ 649.836422] RIP: 0033:0x7f8d5a841ee7
[ 649.836432] RSP: 002b:00007fff89161a28 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
[ 649.836448] RAX: ffffffffffffffda RBX: 000055f6cd1db5c0 RCX: 00007f8d5a841ee7
[ 649.836458] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 000055f6cd1da7b8
[ 649.836467] RBP: 00007f8d5aaee440 R08: 0000000000000000 R09: 00007fff89161a58
[ 649.836476] R10: 0000000000000062 R11: 0000000000000206 R12: 0000000000000000
[ 649.836486] R13: 000055f6cd1d9010 R14: 000000000000003a R15: 00007fff891609f0
[ 649.836514] ---[ end trace 0e529da316e2a3d1 ]---
[ 649.836536] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector VGA-1 leaked!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_display.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b44e9466d394..801ff845a2f3 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -17301,10 +17301,18 @@ void intel_connector_unregister(struct drm_connector *connector)
void intel_modeset_cleanup(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = to_i915(dev);
+ struct intel_connector *connector;
flush_work(&dev_priv->atomic_helper.free_work);
WARN_ON(!llist_empty(&dev_priv->atomic_helper.free_list));
+ for_each_intel_connector(dev, connector) {
+ if (connector->base.state->crtc) {
+ drm_connector_unreference(&connector->base);
+ connector->base.state->crtc = NULL;
+ }
+ }
+
intel_disable_gt_powersave(dev_priv);
/*
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Release the forgotten connector reference
2017-02-01 19:58 [PATCH] drm/i915: Release the forgotten connector reference Chris Wilson
@ 2017-02-01 20:23 ` Patchwork
2017-02-02 8:08 ` [PATCH] " Joonas Lahtinen
2017-02-02 8:20 ` Chris Wilson
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-02-01 20:23 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Release the forgotten connector reference
URL : https://patchwork.freedesktop.org/series/18944/
State : success
== Summary ==
Series 18944v1 drm/i915: Release the forgotten connector reference
https://patchwork.freedesktop.org/api/1.0/series/18944/revisions/1/mbox/
fi-bdw-5557u total:247 pass:233 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:247 pass:208 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:247 pass:225 dwarn:0 dfail:0 fail:0 skip:22
fi-bxt-t5700 total:78 pass:65 dwarn:0 dfail:0 fail:0 skip:12
fi-byt-j1900 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
fi-hsw-4770r total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
fi-ivb-3520m total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-ivb-3770 total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-kbl-7500u total:247 pass:224 dwarn:0 dfail:0 fail:2 skip:21
fi-skl-6260u total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:247 pass:227 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:247 pass:222 dwarn:4 dfail:0 fail:0 skip:21
fi-skl-6770hq total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
fi-snb-2600 total:247 pass:215 dwarn:0 dfail:0 fail:0 skip:32
a0cc425b0034c42eb3830f7dd612ac2a132a874c drm-tip: 2017y-02m-01d-17h-17m-34s UTC integration manifest
7a649d7 drm/i915: Release the forgotten connector reference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3669/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Release the forgotten connector reference
2017-02-01 19:58 [PATCH] drm/i915: Release the forgotten connector reference Chris Wilson
2017-02-01 20:23 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-02-02 8:08 ` Joonas Lahtinen
2017-02-02 8:16 ` Chris Wilson
2017-02-02 8:20 ` Chris Wilson
2 siblings, 1 reply; 7+ messages in thread
From: Joonas Lahtinen @ 2017-02-02 8:08 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On ke, 2017-02-01 at 19:58 +0000, Chris Wilson wrote:
> The reference was gained in
> intel_modeset_update_connector_atomic_state() [called from
> intel_modeset_setup_hw_state()] and is never lost if no client ever
> performs a modeset.
>
> [ 649.836069] WARNING: CPU: 6 PID: 8865 at drivers/gpu/drm/drm_mode_config.c:424 drm_mode_config_cleanup+0x21b/0x290 [drm]
> [ 649.836078] Modules linked in: i915(-) intel_gtt drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm
> [ 649.836099] CPU: 6 PID: 8865 Comm: drv_selftest Not tainted 4.10.0-rc6+ #908
> [ 649.836106] Hardware name: Intel Corporation 2012 Client Platform/Emerald Lake 2, BIOS ACRVMBY1.86C.0078.P00.1201161002 01/16/2012
> [ 649.836114] Call Trace:
> [ 649.836125] dump_stack+0x4d/0x6f
> [ 649.836136] __warn+0xc1/0xe0
> [ 649.836144] warn_slowpath_null+0x18/0x20
> [ 649.836163] drm_mode_config_cleanup+0x21b/0x290 [drm]
> [ 649.836213] intel_modeset_cleanup+0x59/0xa0 [i915]
> [ 649.836242] i915_driver_unload+0x84/0x170 [i915]
> [ 649.836277] i915_pci_remove+0x14/0x20 [i915]
> [ 649.836287] pci_device_remove+0x28/0x60
> [ 649.836301] device_release_driver_internal+0x132/0x1d0
> [ 649.836313] driver_detach+0x3a/0x80
> [ 649.836324] bus_remove_driver+0x47/0xa0
> [ 649.836335] driver_unregister+0x27/0x50
> [ 649.836344] pci_unregister_driver+0x34/0xa0
> [ 649.836387] i915_exit+0x1a/0x71 [i915]
> [ 649.836401] SyS_delete_module+0x173/0x1c0
> [ 649.836413] entry_SYSCALL_64_fastpath+0x17/0x98
> [ 649.836422] RIP: 0033:0x7f8d5a841ee7
> [ 649.836432] RSP: 002b:00007fff89161a28 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
> [ 649.836448] RAX: ffffffffffffffda RBX: 000055f6cd1db5c0 RCX: 00007f8d5a841ee7
> [ 649.836458] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 000055f6cd1da7b8
> [ 649.836467] RBP: 00007f8d5aaee440 R08: 0000000000000000 R09: 00007fff89161a58
> [ 649.836476] R10: 0000000000000062 R11: 0000000000000206 R12: 0000000000000000
> [ 649.836486] R13: 000055f6cd1d9010 R14: 000000000000003a R15: 00007fff891609f0
> [ 649.836514] ---[ end trace 0e529da316e2a3d1 ]---
> [ 649.836536] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector VGA-1 leaked!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Release the forgotten connector reference
2017-02-02 8:08 ` [PATCH] " Joonas Lahtinen
@ 2017-02-02 8:16 ` Chris Wilson
2017-02-02 11:35 ` Daniel Vetter
0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2017-02-02 8:16 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
On Thu, Feb 02, 2017 at 10:08:57AM +0200, Joonas Lahtinen wrote:
> On ke, 2017-02-01 at 19:58 +0000, Chris Wilson wrote:
> > The reference was gained in
> > intel_modeset_update_connector_atomic_state() [called from
> > intel_modeset_setup_hw_state()] and is never lost if no client ever
> > performs a modeset.
> >
> > [ 649.836069] WARNING: CPU: 6 PID: 8865 at drivers/gpu/drm/drm_mode_config.c:424 drm_mode_config_cleanup+0x21b/0x290 [drm]
> > [ 649.836078] Modules linked in: i915(-) intel_gtt drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm
> > [ 649.836099] CPU: 6 PID: 8865 Comm: drv_selftest Not tainted 4.10.0-rc6+ #908
> > [ 649.836106] Hardware name: Intel Corporation 2012 Client Platform/Emerald Lake 2, BIOS ACRVMBY1.86C.0078.P00.1201161002 01/16/2012
> > [ 649.836114] Call Trace:
> > [ 649.836125] dump_stack+0x4d/0x6f
> > [ 649.836136] __warn+0xc1/0xe0
> > [ 649.836144] warn_slowpath_null+0x18/0x20
> > [ 649.836163] drm_mode_config_cleanup+0x21b/0x290 [drm]
> > [ 649.836213] intel_modeset_cleanup+0x59/0xa0 [i915]
> > [ 649.836242] i915_driver_unload+0x84/0x170 [i915]
> > [ 649.836277] i915_pci_remove+0x14/0x20 [i915]
> > [ 649.836287] pci_device_remove+0x28/0x60
> > [ 649.836301] device_release_driver_internal+0x132/0x1d0
> > [ 649.836313] driver_detach+0x3a/0x80
> > [ 649.836324] bus_remove_driver+0x47/0xa0
> > [ 649.836335] driver_unregister+0x27/0x50
> > [ 649.836344] pci_unregister_driver+0x34/0xa0
> > [ 649.836387] i915_exit+0x1a/0x71 [i915]
> > [ 649.836401] SyS_delete_module+0x173/0x1c0
> > [ 649.836413] entry_SYSCALL_64_fastpath+0x17/0x98
> > [ 649.836422] RIP: 0033:0x7f8d5a841ee7
> > [ 649.836432] RSP: 002b:00007fff89161a28 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
> > [ 649.836448] RAX: ffffffffffffffda RBX: 000055f6cd1db5c0 RCX: 00007f8d5a841ee7
> > [ 649.836458] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 000055f6cd1da7b8
> > [ 649.836467] RBP: 00007f8d5aaee440 R08: 0000000000000000 R09: 00007fff89161a58
> > [ 649.836476] R10: 0000000000000062 R11: 0000000000000206 R12: 0000000000000000
> > [ 649.836486] R13: 000055f6cd1d9010 R14: 000000000000003a R15: 00007fff891609f0
> > [ 649.836514] ---[ end trace 0e529da316e2a3d1 ]---
> > [ 649.836536] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector VGA-1 leaked!
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
I'm hoping that this won't be required after Maarten's force disable all
CRTC on unload. We will see.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Release the forgotten connector reference
2017-02-01 19:58 [PATCH] drm/i915: Release the forgotten connector reference Chris Wilson
2017-02-01 20:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-02 8:08 ` [PATCH] " Joonas Lahtinen
@ 2017-02-02 8:20 ` Chris Wilson
2 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2017-02-02 8:20 UTC (permalink / raw)
To: intel-gfx
On Wed, Feb 01, 2017 at 07:58:31PM +0000, Chris Wilson wrote:
> The reference was gained in
> intel_modeset_update_connector_atomic_state() [called from
> intel_modeset_setup_hw_state()] and is never lost if no client ever
> performs a modeset.
>
> [ 649.836069] WARNING: CPU: 6 PID: 8865 at drivers/gpu/drm/drm_mode_config.c:424 drm_mode_config_cleanup+0x21b/0x290 [drm]
> [ 649.836078] Modules linked in: i915(-) intel_gtt drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm
> [ 649.836099] CPU: 6 PID: 8865 Comm: drv_selftest Not tainted 4.10.0-rc6+ #908
> [ 649.836106] Hardware name: Intel Corporation 2012 Client Platform/Emerald Lake 2, BIOS ACRVMBY1.86C.0078.P00.1201161002 01/16/2012
> [ 649.836114] Call Trace:
> [ 649.836125] dump_stack+0x4d/0x6f
> [ 649.836136] __warn+0xc1/0xe0
> [ 649.836144] warn_slowpath_null+0x18/0x20
> [ 649.836163] drm_mode_config_cleanup+0x21b/0x290 [drm]
> [ 649.836213] intel_modeset_cleanup+0x59/0xa0 [i915]
> [ 649.836242] i915_driver_unload+0x84/0x170 [i915]
> [ 649.836277] i915_pci_remove+0x14/0x20 [i915]
> [ 649.836287] pci_device_remove+0x28/0x60
> [ 649.836301] device_release_driver_internal+0x132/0x1d0
> [ 649.836313] driver_detach+0x3a/0x80
> [ 649.836324] bus_remove_driver+0x47/0xa0
> [ 649.836335] driver_unregister+0x27/0x50
> [ 649.836344] pci_unregister_driver+0x34/0xa0
> [ 649.836387] i915_exit+0x1a/0x71 [i915]
> [ 649.836401] SyS_delete_module+0x173/0x1c0
> [ 649.836413] entry_SYSCALL_64_fastpath+0x17/0x98
> [ 649.836422] RIP: 0033:0x7f8d5a841ee7
> [ 649.836432] RSP: 002b:00007fff89161a28 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
> [ 649.836448] RAX: ffffffffffffffda RBX: 000055f6cd1db5c0 RCX: 00007f8d5a841ee7
> [ 649.836458] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 000055f6cd1da7b8
> [ 649.836467] RBP: 00007f8d5aaee440 R08: 0000000000000000 R09: 00007fff89161a58
> [ 649.836476] R10: 0000000000000062 R11: 0000000000000206 R12: 0000000000000000
> [ 649.836486] R13: 000055f6cd1d9010 R14: 000000000000003a R15: 00007fff891609f0
> [ 649.836514] ---[ end trace 0e529da316e2a3d1 ]---
> [ 649.836536] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector VGA-1 leaked!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95004
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Release the forgotten connector reference
2017-02-02 8:16 ` Chris Wilson
@ 2017-02-02 11:35 ` Daniel Vetter
2017-02-02 12:28 ` Chris Wilson
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Vetter @ 2017-02-02 11:35 UTC (permalink / raw)
To: Chris Wilson, Joonas Lahtinen, intel-gfx
On Thu, Feb 02, 2017 at 08:16:23AM +0000, Chris Wilson wrote:
> On Thu, Feb 02, 2017 at 10:08:57AM +0200, Joonas Lahtinen wrote:
> > On ke, 2017-02-01 at 19:58 +0000, Chris Wilson wrote:
> > > The reference was gained in
> > > intel_modeset_update_connector_atomic_state() [called from
> > > intel_modeset_setup_hw_state()] and is never lost if no client ever
> > > performs a modeset.
> > >
> > > [ 649.836069] WARNING: CPU: 6 PID: 8865 at drivers/gpu/drm/drm_mode_config.c:424 drm_mode_config_cleanup+0x21b/0x290 [drm]
> > > [ 649.836078] Modules linked in: i915(-) intel_gtt drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm
> > > [ 649.836099] CPU: 6 PID: 8865 Comm: drv_selftest Not tainted 4.10.0-rc6+ #908
> > > [ 649.836106] Hardware name: Intel Corporation 2012 Client Platform/Emerald Lake 2, BIOS ACRVMBY1.86C.0078.P00.1201161002 01/16/2012
> > > [ 649.836114] Call Trace:
> > > [ 649.836125] dump_stack+0x4d/0x6f
> > > [ 649.836136] __warn+0xc1/0xe0
> > > [ 649.836144] warn_slowpath_null+0x18/0x20
> > > [ 649.836163] drm_mode_config_cleanup+0x21b/0x290 [drm]
> > > [ 649.836213] intel_modeset_cleanup+0x59/0xa0 [i915]
> > > [ 649.836242] i915_driver_unload+0x84/0x170 [i915]
> > > [ 649.836277] i915_pci_remove+0x14/0x20 [i915]
> > > [ 649.836287] pci_device_remove+0x28/0x60
> > > [ 649.836301] device_release_driver_internal+0x132/0x1d0
> > > [ 649.836313] driver_detach+0x3a/0x80
> > > [ 649.836324] bus_remove_driver+0x47/0xa0
> > > [ 649.836335] driver_unregister+0x27/0x50
> > > [ 649.836344] pci_unregister_driver+0x34/0xa0
> > > [ 649.836387] i915_exit+0x1a/0x71 [i915]
> > > [ 649.836401] SyS_delete_module+0x173/0x1c0
> > > [ 649.836413] entry_SYSCALL_64_fastpath+0x17/0x98
> > > [ 649.836422] RIP: 0033:0x7f8d5a841ee7
> > > [ 649.836432] RSP: 002b:00007fff89161a28 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
> > > [ 649.836448] RAX: ffffffffffffffda RBX: 000055f6cd1db5c0 RCX: 00007f8d5a841ee7
> > > [ 649.836458] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 000055f6cd1da7b8
> > > [ 649.836467] RBP: 00007f8d5aaee440 R08: 0000000000000000 R09: 00007fff89161a58
> > > [ 649.836476] R10: 0000000000000062 R11: 0000000000000206 R12: 0000000000000000
> > > [ 649.836486] R13: 000055f6cd1d9010 R14: 000000000000003a R15: 00007fff891609f0
> > > [ 649.836514] ---[ end trace 0e529da316e2a3d1 ]---
> > > [ 649.836536] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector VGA-1 leaked!
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> I'm hoping that this won't be required after Maarten's force disable all
> CRTC on unload. We will see.
Yeah, I think landing that would be better, but if this is annoying CI or
something like that, I'm ok with merging already with a FIXME comment
added.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Release the forgotten connector reference
2017-02-02 11:35 ` Daniel Vetter
@ 2017-02-02 12:28 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2017-02-02 12:28 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On Thu, Feb 02, 2017 at 12:35:26PM +0100, Daniel Vetter wrote:
> On Thu, Feb 02, 2017 at 08:16:23AM +0000, Chris Wilson wrote:
> > On Thu, Feb 02, 2017 at 10:08:57AM +0200, Joonas Lahtinen wrote:
> > > On ke, 2017-02-01 at 19:58 +0000, Chris Wilson wrote:
> > > > The reference was gained in
> > > > intel_modeset_update_connector_atomic_state() [called from
> > > > intel_modeset_setup_hw_state()] and is never lost if no client ever
> > > > performs a modeset.
> > > >
> > > > [ 649.836069] WARNING: CPU: 6 PID: 8865 at drivers/gpu/drm/drm_mode_config.c:424 drm_mode_config_cleanup+0x21b/0x290 [drm]
> > > > [ 649.836078] Modules linked in: i915(-) intel_gtt drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm
> > > > [ 649.836099] CPU: 6 PID: 8865 Comm: drv_selftest Not tainted 4.10.0-rc6+ #908
> > > > [ 649.836106] Hardware name: Intel Corporation 2012 Client Platform/Emerald Lake 2, BIOS ACRVMBY1.86C.0078.P00.1201161002 01/16/2012
> > > > [ 649.836114] Call Trace:
> > > > [ 649.836125] dump_stack+0x4d/0x6f
> > > > [ 649.836136] __warn+0xc1/0xe0
> > > > [ 649.836144] warn_slowpath_null+0x18/0x20
> > > > [ 649.836163] drm_mode_config_cleanup+0x21b/0x290 [drm]
> > > > [ 649.836213] intel_modeset_cleanup+0x59/0xa0 [i915]
> > > > [ 649.836242] i915_driver_unload+0x84/0x170 [i915]
> > > > [ 649.836277] i915_pci_remove+0x14/0x20 [i915]
> > > > [ 649.836287] pci_device_remove+0x28/0x60
> > > > [ 649.836301] device_release_driver_internal+0x132/0x1d0
> > > > [ 649.836313] driver_detach+0x3a/0x80
> > > > [ 649.836324] bus_remove_driver+0x47/0xa0
> > > > [ 649.836335] driver_unregister+0x27/0x50
> > > > [ 649.836344] pci_unregister_driver+0x34/0xa0
> > > > [ 649.836387] i915_exit+0x1a/0x71 [i915]
> > > > [ 649.836401] SyS_delete_module+0x173/0x1c0
> > > > [ 649.836413] entry_SYSCALL_64_fastpath+0x17/0x98
> > > > [ 649.836422] RIP: 0033:0x7f8d5a841ee7
> > > > [ 649.836432] RSP: 002b:00007fff89161a28 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
> > > > [ 649.836448] RAX: ffffffffffffffda RBX: 000055f6cd1db5c0 RCX: 00007f8d5a841ee7
> > > > [ 649.836458] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 000055f6cd1da7b8
> > > > [ 649.836467] RBP: 00007f8d5aaee440 R08: 0000000000000000 R09: 00007fff89161a58
> > > > [ 649.836476] R10: 0000000000000062 R11: 0000000000000206 R12: 0000000000000000
> > > > [ 649.836486] R13: 000055f6cd1d9010 R14: 000000000000003a R15: 00007fff891609f0
> > > > [ 649.836514] ---[ end trace 0e529da316e2a3d1 ]---
> > > > [ 649.836536] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector VGA-1 leaked!
> > > >
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > >
> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >
> > I'm hoping that this won't be required after Maarten's force disable all
> > CRTC on unload. We will see.
>
> Yeah, I think landing that would be better, but if this is annoying CI or
> something like that, I'm ok with merging already with a FIXME comment
> added.
By itself the first force disable CRTCs on unload wasn't enough, but
Maarten has a second patch to apply more force that does. This patch is
not required.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-02-02 12:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-01 19:58 [PATCH] drm/i915: Release the forgotten connector reference Chris Wilson
2017-02-01 20:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-02 8:08 ` [PATCH] " Joonas Lahtinen
2017-02-02 8:16 ` Chris Wilson
2017-02-02 11:35 ` Daniel Vetter
2017-02-02 12:28 ` Chris Wilson
2017-02-02 8:20 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.