From: Andrew Lunn <andrew@lunn.ch> To: Lukasz Majewski <lukma@denx.de> Cc: "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "David S. Miller" <davem@davemloft.net>, "Florian Fainelli" <f.fainelli@gmail.com>, jbrunet <jbrunet@baylibre.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Martin Blumenstingl" <martin.blumenstingl@googlemail.com>, "Jon Mason" <jon.mason@broadcom.com>, "Fabio Estevam" <fabio.estevam@nxp.com> Subject: Re: [PATCH] Documentation: devicetree: Add PHY no lane swap binding Date: Sat, 4 Feb 2017 18:23:29 +0100 [thread overview] Message-ID: <20170204172329.GA8364@lunn.ch> (raw) In-Reply-To: <1486223267-11875-1-git-send-email-lukma@denx.de> On Sat, Feb 04, 2017 at 04:47:47PM +0100, Lukasz Majewski wrote: > Add the documentation to avoid PHY lane swapping. This is a boolean > entry to notify the phy device drivers that the TX/RX lanes NO need that the TX/RX lanes should not be swapped. > to be swapped. > The use case for this binding mostly happens after wrong HW > configuration of PHY IC during bootstrap. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > Documentation/devicetree/bindings/net/phy.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt > index fb5056b..5e25bc9 100644 > --- a/Documentation/devicetree/bindings/net/phy.txt > +++ b/Documentation/devicetree/bindings/net/phy.txt > @@ -39,6 +39,10 @@ Optional Properties: > - enet-phy-lane-swap: If set, indicates the PHY will swap the TX/RX lanes to > compensate for the board being designed with the lanes swapped. > > +- enet-phy-lane-no-swap: If set, indicates that PHY will disable swap of the > + TX/RX lanes. This binding allows the PHY to work correcly after e.g. wrong > + bootstrap configuration caused by issues in PCB layout design. > + We are leaving it undefined what it means if neither enet-phy-lane-no-swap nor enet-phy-lane-swap properties are present. Do we want to define this? That the swap should be left untouched by the driver? Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> To: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org> Cc: "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, "Florian Fainelli" <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, jbrunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, "Martin Blumenstingl" <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>, "Jon Mason" <jon.mason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>, "Fabio Estevam" <fabio.estevam-3arQi8VN3Tc@public.gmane.org> Subject: Re: [PATCH] Documentation: devicetree: Add PHY no lane swap binding Date: Sat, 4 Feb 2017 18:23:29 +0100 [thread overview] Message-ID: <20170204172329.GA8364@lunn.ch> (raw) In-Reply-To: <1486223267-11875-1-git-send-email-lukma-ynQEQJNshbs@public.gmane.org> On Sat, Feb 04, 2017 at 04:47:47PM +0100, Lukasz Majewski wrote: > Add the documentation to avoid PHY lane swapping. This is a boolean > entry to notify the phy device drivers that the TX/RX lanes NO need that the TX/RX lanes should not be swapped. > to be swapped. > The use case for this binding mostly happens after wrong HW > configuration of PHY IC during bootstrap. > > Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org> > --- > Documentation/devicetree/bindings/net/phy.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt > index fb5056b..5e25bc9 100644 > --- a/Documentation/devicetree/bindings/net/phy.txt > +++ b/Documentation/devicetree/bindings/net/phy.txt > @@ -39,6 +39,10 @@ Optional Properties: > - enet-phy-lane-swap: If set, indicates the PHY will swap the TX/RX lanes to > compensate for the board being designed with the lanes swapped. > > +- enet-phy-lane-no-swap: If set, indicates that PHY will disable swap of the > + TX/RX lanes. This binding allows the PHY to work correcly after e.g. wrong > + bootstrap configuration caused by issues in PCB layout design. > + We are leaving it undefined what it means if neither enet-phy-lane-no-swap nor enet-phy-lane-swap properties are present. Do we want to define this? That the swap should be left untouched by the driver? Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-04 17:23 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-04 15:47 [PATCH] Documentation: devicetree: Add PHY no lane swap binding Lukasz Majewski 2017-02-04 17:23 ` Andrew Lunn [this message] 2017-02-04 17:23 ` Andrew Lunn 2017-02-04 21:38 ` Florian Fainelli 2017-02-06 14:15 ` Lukasz Majewski 2017-02-06 14:38 ` Andrew Lunn 2017-02-06 17:58 ` Florian Fainelli 2017-02-06 17:58 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170204172329.GA8364@lunn.ch \ --to=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=jbrunet@baylibre.com \ --cc=jon.mason@broadcom.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lukma@denx.de \ --cc=mark.rutland@arm.com \ --cc=martin.blumenstingl@googlemail.com \ --cc=netdev@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.