From: Sakari Ailus <sakari.ailus@iki.fi> To: Pavel Machek <pavel@ucw.cz> Cc: laurent.pinchart@ideasonboard.com, robh+dt@kernel.org, devicetree@vger.kernel.org, ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org, galak@codeaurora.org, mchehab@osg.samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] devicetree: Add video bus switch Date: Sun, 5 Feb 2017 00:33:50 +0200 [thread overview] Message-ID: <20170204223350.GF12291@valkosipuli.retiisi.org.uk> (raw) In-Reply-To: <20170204215610.GA9243@amd> Hi Pavel, On Sat, Feb 04, 2017 at 10:56:10PM +0100, Pavel Machek wrote: > Hi! > > > > > > +Required properties > > > > > +=================== > > > > > + > > > > > +compatible : must contain "video-bus-switch" > > > > > > > > How generic is this? Should we have e.g. nokia,video-bus-switch? And if so, > > > > change the file name accordingly. > > > > > > Generic for "single GPIO controls the switch", AFAICT. But that should > > > be common enough... > > > > Um, yes. Then... how about: video-bus-switch-gpio? No Nokia prefix. > > Ok, done. I also fixed the english a bit. > > > > > > +reg : The interface: > > > > > + 0 - port for image signal processor > > > > > + 1 - port for first camera sensor > > > > > + 2 - port for second camera sensor > > > > > > > > I'd say this must be pretty much specific to the one in N900. You could have > > > > more ports. Or you could say that ports beyond 0 are camera sensors. I guess > > > > this is good enough for now though, it can be changed later on with the > > > > source if a need arises. > > > > > > Well, I'd say that selecting between two sensors is going to be the > > > common case. If someone needs more than two, it will no longer be > > > simple GPIO, so we'll have some fixing to do. > > > > It could be two GPIOs --- that's how the GPIO I2C mux works. > > > > But I'd be surprised if someone ever uses something like that > > again. ;-) > > I'd say.. lets handle that when we see hardware like that. Yes. :-) > > > > > Btw. was it still considered a problem that the endpoint properties for the > > > > sensors can be different? With the g_routing() pad op which is to be added, > > > > the ISP driver (should actually go to a framework somewhere) could parse the > > > > graph and find the proper endpoint there. > > > > > > I don't know about g_routing. I added g_endpoint_config method that > > > passes the configuration, and that seems to work for me. > > > > > > I don't see g_routing in next-20170201 . Is there place to look? > > > > I think there was a patch by Laurent to LMML quite some time ago. I suppose > > that set will be repicked soonish. > > > > I don't really object using g_endpoint_config() as a temporary solution; I'd > > like to have Laurent's opinion on that though. Another option is to wait, > > but we've already waited a looong time (as in total). > > Laurent, do you have some input here? We have simple "2 cameras > connected to one signal processor" situation here. We need some way of > passing endpoint configuration from the sensors through the switch. I > did this: > > > > @@ -415,6 +416,8 @@ struct v4l2_subdev_video_ops { > > > const struct v4l2_mbus_config *cfg); > > > int (*s_rx_buffer)(struct v4l2_subdev *sd, void *buf, > > > unsigned int *size); > > > + int (*g_endpoint_config)(struct v4l2_subdev *sd, > > > + struct v4l2_of_endpoint *cfg); > > Google of g_routing tells me: > > 9) Highly reconfigurable hardware - Julien Beraud > > - 44 sub-devices connected with an interconnect. > - As long as formats match, any sub-device could be connected to any > - other sub-device through a link. > - The result is 44 * 44 links at worst. > - A switch sub-device proposed as the solution to model the > - interconnect. The sub-devices are connected to the switch > - sub-devices through the hardware links that connect to the > - interconnect. > - The switch would be controlled through new IOCTLs S_ROUTING and > - G_ROUTING. > - Patches available: > http://git.linuxtv.org/cgit.cgi/pinchartl/media.git/log/?h=xilinx-wip > > but the patches are from 2005. So I guess I'll need some guidance here... Yeah, that's where it began (2015?), but right now I can only suggest to wait until there's more. My estimate is within next couple of weeks / months. But it won't be years. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org> To: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> Cc: laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] devicetree: Add video bus switch Date: Sun, 5 Feb 2017 00:33:50 +0200 [thread overview] Message-ID: <20170204223350.GF12291@valkosipuli.retiisi.org.uk> (raw) In-Reply-To: <20170204215610.GA9243@amd> Hi Pavel, On Sat, Feb 04, 2017 at 10:56:10PM +0100, Pavel Machek wrote: > Hi! > > > > > > +Required properties > > > > > +=================== > > > > > + > > > > > +compatible : must contain "video-bus-switch" > > > > > > > > How generic is this? Should we have e.g. nokia,video-bus-switch? And if so, > > > > change the file name accordingly. > > > > > > Generic for "single GPIO controls the switch", AFAICT. But that should > > > be common enough... > > > > Um, yes. Then... how about: video-bus-switch-gpio? No Nokia prefix. > > Ok, done. I also fixed the english a bit. > > > > > > +reg : The interface: > > > > > + 0 - port for image signal processor > > > > > + 1 - port for first camera sensor > > > > > + 2 - port for second camera sensor > > > > > > > > I'd say this must be pretty much specific to the one in N900. You could have > > > > more ports. Or you could say that ports beyond 0 are camera sensors. I guess > > > > this is good enough for now though, it can be changed later on with the > > > > source if a need arises. > > > > > > Well, I'd say that selecting between two sensors is going to be the > > > common case. If someone needs more than two, it will no longer be > > > simple GPIO, so we'll have some fixing to do. > > > > It could be two GPIOs --- that's how the GPIO I2C mux works. > > > > But I'd be surprised if someone ever uses something like that > > again. ;-) > > I'd say.. lets handle that when we see hardware like that. Yes. :-) > > > > > Btw. was it still considered a problem that the endpoint properties for the > > > > sensors can be different? With the g_routing() pad op which is to be added, > > > > the ISP driver (should actually go to a framework somewhere) could parse the > > > > graph and find the proper endpoint there. > > > > > > I don't know about g_routing. I added g_endpoint_config method that > > > passes the configuration, and that seems to work for me. > > > > > > I don't see g_routing in next-20170201 . Is there place to look? > > > > I think there was a patch by Laurent to LMML quite some time ago. I suppose > > that set will be repicked soonish. > > > > I don't really object using g_endpoint_config() as a temporary solution; I'd > > like to have Laurent's opinion on that though. Another option is to wait, > > but we've already waited a looong time (as in total). > > Laurent, do you have some input here? We have simple "2 cameras > connected to one signal processor" situation here. We need some way of > passing endpoint configuration from the sensors through the switch. I > did this: > > > > @@ -415,6 +416,8 @@ struct v4l2_subdev_video_ops { > > > const struct v4l2_mbus_config *cfg); > > > int (*s_rx_buffer)(struct v4l2_subdev *sd, void *buf, > > > unsigned int *size); > > > + int (*g_endpoint_config)(struct v4l2_subdev *sd, > > > + struct v4l2_of_endpoint *cfg); > > Google of g_routing tells me: > > 9) Highly reconfigurable hardware - Julien Beraud > > - 44 sub-devices connected with an interconnect. > - As long as formats match, any sub-device could be connected to any > - other sub-device through a link. > - The result is 44 * 44 links at worst. > - A switch sub-device proposed as the solution to model the > - interconnect. The sub-devices are connected to the switch > - sub-devices through the hardware links that connect to the > - interconnect. > - The switch would be controlled through new IOCTLs S_ROUTING and > - G_ROUTING. > - Patches available: > http://git.linuxtv.org/cgit.cgi/pinchartl/media.git/log/?h=xilinx-wip > > but the patches are from 2005. So I guess I'll need some guidance here... Yeah, that's where it began (2015?), but right now I can only suggest to wait until there's more. My estimate is within next couple of weeks / months. But it won't be years. -- Kind regards, Sakari Ailus e-mail: sakari.ailus-X3B1VOXEql0@public.gmane.org XMPP: sailus-PCDdDYkjdNMDXYZnReoRVg@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-04 22:34 UTC|newest] Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-23 20:03 [PATCH v4] media: Driver for Toshiba et8ek8 5MP sensor Pavel Machek 2016-10-23 20:19 ` Sakari Ailus 2016-10-23 20:33 ` Pavel Machek 2016-10-31 22:54 ` Sakari Ailus 2016-11-01 6:36 ` Ivaylo Dimitrov 2016-11-01 20:11 ` Sakari Ailus 2016-11-01 22:14 ` Ivaylo Dimitrov 2016-11-02 8:15 ` Pavel Machek 2016-11-02 8:16 ` Ivaylo Dimitrov 2016-11-01 15:39 ` Pavel Machek 2016-11-01 20:08 ` Sakari Ailus 2016-11-03 8:14 ` Pavel Machek 2016-11-03 22:48 ` Sebastian Reichel 2016-11-03 23:05 ` Sakari Ailus 2016-11-03 23:40 ` Ivaylo Dimitrov 2016-11-04 0:05 ` Sebastian Reichel 2016-11-14 21:58 ` Sakari Ailus 2016-11-15 0:53 ` Sebastian Reichel 2016-11-15 10:54 ` Pavel Machek 2016-11-15 22:55 ` Sakari Ailus 2016-10-23 20:40 ` Pavel Machek 2016-10-31 22:58 ` Sakari Ailus 2016-11-02 0:45 ` Laurent Pinchart 2016-10-23 20:47 ` Pavel Machek 2016-12-13 21:05 ` Pavel Machek 2016-12-18 21:56 ` Sakari Ailus 2016-11-19 23:29 ` Sakari Ailus 2016-11-20 10:02 ` Pavel Machek 2016-11-20 15:20 ` Pavel Machek 2016-11-20 15:21 ` Pavel Machek 2016-11-20 15:31 ` Pavel Machek 2016-12-14 12:24 ` [PATCH v5] " Pavel Machek 2016-12-14 13:03 ` Pali Rohár 2016-12-14 15:52 ` Ivaylo Dimitrov 2016-12-14 20:12 ` Pavel Machek 2016-12-14 22:07 ` Pali Rohár 2016-12-14 22:35 ` Pavel Machek 2016-12-18 22:01 ` Sakari Ailus 2016-12-20 12:37 ` Pavel Machek 2016-12-20 14:01 ` Sakari Ailus 2016-12-20 22:42 ` Pavel Machek 2016-12-21 13:42 ` Sakari Ailus 2016-12-21 22:42 ` Pavel Machek 2016-12-21 23:29 ` Sakari Ailus 2016-12-22 9:34 ` Pavel Machek 2016-12-22 10:01 ` [PATCH v6] " Pavel Machek 2016-12-22 13:39 ` [RFC/PATCH] media: Add video bus switch Pavel Machek 2016-12-22 14:32 ` Sebastian Reichel 2016-12-22 20:53 ` Pavel Machek 2016-12-22 23:11 ` Sebastian Reichel 2016-12-22 22:42 ` Pavel Machek 2016-12-22 23:40 ` Sebastian Reichel 2016-12-23 11:42 ` Pavel Machek 2016-12-23 18:53 ` Ivaylo Dimitrov 2016-12-23 20:56 ` Pavel Machek 2016-12-24 14:26 ` Pavel Machek 2016-12-24 14:43 ` Pavel Machek 2016-12-24 15:20 ` [PATCH] " Pavel Machek 2016-12-24 18:35 ` kbuild test robot 2017-01-12 11:17 ` Pavel Machek 2017-02-03 22:25 ` Sakari Ailus 2017-02-05 22:16 ` Pavel Machek 2017-02-05 22:44 ` Sakari Ailus 2017-02-03 12:35 ` [PATCH] devicetree: " Pavel Machek 2017-02-03 12:35 ` Pavel Machek 2017-02-03 13:07 ` Sakari Ailus 2017-02-03 21:06 ` Pavel Machek 2017-02-03 21:34 ` Sakari Ailus 2017-02-04 21:56 ` Pavel Machek 2017-02-04 22:33 ` Sakari Ailus [this message] 2017-02-04 22:33 ` Sakari Ailus 2017-02-05 21:12 ` Pavel Machek 2017-02-05 23:40 ` Sebastian Reichel 2017-02-05 23:40 ` Sebastian Reichel 2017-02-06 9:37 ` [PATCH] media: add operation to get configuration of "the other side" of the link Pavel Machek 2017-12-19 15:43 ` Sakari Ailus 2017-12-20 17:54 ` [PATCH] devicetree: Add video bus switch Laurent Pinchart 2017-12-20 17:54 ` Laurent Pinchart 2017-12-21 9:05 ` Sakari Ailus 2017-12-21 9:05 ` Sakari Ailus 2017-12-21 16:36 ` Ivaylo Dimitrov 2017-12-21 16:36 ` Ivaylo Dimitrov 2017-12-22 9:24 ` Pavel Machek 2017-12-22 9:24 ` Pavel Machek 2017-02-03 13:32 ` Pali Rohár 2017-02-03 21:07 ` Pavel Machek 2017-02-03 21:07 ` Pavel Machek 2017-02-04 1:04 ` Sebastian Reichel 2017-02-04 1:04 ` Sebastian Reichel 2017-02-08 21:36 ` Rob Herring 2017-02-08 22:30 ` Pavel Machek 2017-02-09 23:02 ` Rob Herring 2017-02-09 23:03 ` Rob Herring 2017-02-10 19:54 ` Pavel Machek 2017-02-10 19:54 ` Pavel Machek 2017-02-10 22:17 ` Sakari Ailus 2017-02-10 22:17 ` Sakari Ailus 2017-02-13 9:54 ` Pavel Machek 2017-02-13 9:54 ` Pavel Machek 2017-02-13 10:20 ` Sakari Ailus 2017-02-13 10:20 ` Sakari Ailus 2017-03-02 8:54 ` Pavel Machek 2017-02-08 22:34 ` Pavel Machek 2017-02-09 22:58 ` Rob Herring 2017-02-10 21:17 ` Pavel Machek 2017-02-10 21:17 ` Pavel Machek 2016-12-27 9:26 ` [PATCH v6] media: Driver for Toshiba et8ek8 5MP sensor Sakari Ailus 2016-12-27 20:45 ` Pavel Machek 2016-12-27 20:59 ` [PATCH] mark myself as mainainer for camera on N900 Pavel Machek 2016-12-27 23:57 ` Sebastian Reichel 2017-01-25 13:48 ` Sakari Ailus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170204223350.GF12291@valkosipuli.retiisi.org.uk \ --to=sakari.ailus@iki.fi \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ivo.g.dimitrov.75@gmail.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@osg.samsung.com \ --cc=pali.rohar@gmail.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --cc=sre@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.