All of lore.kernel.org
 help / color / mirror / Atom feed
* [bug report] clk: sunxi-ng: Add A80 CCU
@ 2017-02-06 13:47 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-02-06 13:47 UTC (permalink / raw)
  To: wens; +Cc: linux-clk

Hello Chen-Yu Tsai,

The patch b8eb71dcdd08: "clk: sunxi-ng: Add A80 CCU" from Jan 28,
2017, leads to the following static checker warning:

	drivers/clk/sunxi-ng/ccu-sun9i-a80.c:1205 sun9i_a80_ccu_probe()
	warn: odd binop '0x10000 & 0x40000'

drivers/clk/sunxi-ng/ccu-sun9i-a80.c
  1192  static int sun9i_a80_ccu_probe(struct platform_device *pdev)
  1193  {
  1194          struct resource *res;
  1195          void __iomem *reg;
  1196          u32 val;
  1197  
  1198          res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
  1199          reg = devm_ioremap_resource(&pdev->dev, res);
  1200          if (IS_ERR(reg))
  1201                  return PTR_ERR(reg);
  1202  
  1203          /* Enforce d1 = 0, d2 = 0 for Audio PLL */
  1204          val = readl(reg + SUN9I_A80_PLL_AUDIO_REG);
  1205          val &= (BIT(16) & BIT(18));

This line just sets "val" to zero.  Not sure what was intended.

  1206          writel(val, reg + SUN9I_A80_PLL_AUDIO_REG);
  1207  
  1208          return sunxi_ccu_probe(pdev->dev.of_node, reg, &sun9i_a80_ccu_desc);
  1209  }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-06 13:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 13:47 [bug report] clk: sunxi-ng: Add A80 CCU Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.