All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	<linux-fsdevel@vger.kernel.org>
Cc: <linux-mm@kvack.org>, Dave Chinner <david@fromorbit.com>,
	djwong@kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.cz>,
	Jan Kara <jack@suse.cz>,
	ceph-devel@vger.kernel.org, cluster-devel@redhat.com,
	linux-nfs@vger.kernel.org, logfs@logfs.org,
	linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	reiserfs-devel@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-afs@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: [PATCH 6/6] jbd2: make the whole kjournald2 kthread NOFS safe
Date: Mon,  6 Feb 2017 15:07:18 +0100	[thread overview]
Message-ID: <20170206140718.16222-7-mhocko@kernel.org> (raw)
In-Reply-To: <20170206140718.16222-1-mhocko@kernel.org>

From: Michal Hocko <mhocko@suse.com>

kjournald2 is central to the transaction commit processing. As such any
potential allocation from this kernel thread has to be GFP_NOFS. Make
sure to mark the whole kernel thread GFP_NOFS by the memalloc_nofs_save.

Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 fs/jbd2/journal.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 704139625fbe..662531a70ce1 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -206,6 +206,13 @@ static int kjournald2(void *arg)
 	wake_up(&journal->j_wait_done_commit);
 
 	/*
+	 * Make sure that no allocations from this kernel thread will ever recurse
+	 * to the fs layer because we are responsible for the transaction commit
+	 * and any fs involvement might get stuck waiting for the trasn. commit.
+	 */
+	memalloc_nofs_save();
+
+	/*
 	 * And now, wait forever for commit wakeup events.
 	 */
 	write_lock(&journal->j_state_lock);
-- 
2.11.0


WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	<linux-fsdevel@vger.kernel.org>
Cc: <linux-mm@kvack.org>, Dave Chinner <david@fromorbit.com>,
	djwong@kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.cz>,
	Jan Kara <jack@suse.cz>,
	ceph-devel@vger.kernel.org, cluster-devel@redhat.com,
	linux-nfs@vger.kernel.org, logfs@logfs.org,
	linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	reiserfs-devel@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-afs@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: [PATCH 6/6] jbd2: make the whole kjournald2 kthread NOFS safe
Date: Mon,  6 Feb 2017 15:07:18 +0100	[thread overview]
Message-ID: <20170206140718.16222-7-mhocko@kernel.org> (raw)
In-Reply-To: <20170206140718.16222-1-mhocko@kernel.org>

From: Michal Hocko <mhocko@suse.com>

kjournald2 is central to the transaction commit processing. As such any
potential allocation from this kernel thread has to be GFP_NOFS. Make
sure to mark the whole kernel thread GFP_NOFS by the memalloc_nofs_save.

Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 fs/jbd2/journal.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 704139625fbe..662531a70ce1 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -206,6 +206,13 @@ static int kjournald2(void *arg)
 	wake_up(&journal->j_wait_done_commit);
 
 	/*
+	 * Make sure that no allocations from this kernel thread will ever recurse
+	 * to the fs layer because we are responsible for the transaction commit
+	 * and any fs involvement might get stuck waiting for the trasn. commit.
+	 */
+	memalloc_nofs_save();
+
+	/*
 	 * And now, wait forever for commit wakeup events.
 	 */
 	write_lock(&journal->j_state_lock);
-- 
2.11.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>, linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
	djwong@kernel.org, Theodore Ts'o <tytso@mit.edu>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.cz>,
	Jan Kara <jack@suse.cz>,
	ceph-devel@vger.kernel.org, cluster-devel@redhat.com,
	linux-nfs@vger.kernel.org, logfs@logfs.org,
	linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	reiserfs-devel@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-afs@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: [PATCH 6/6] jbd2: make the whole kjournald2 kthread NOFS safe
Date: Mon,  6 Feb 2017 15:07:18 +0100	[thread overview]
Message-ID: <20170206140718.16222-7-mhocko@kernel.org> (raw)
In-Reply-To: <20170206140718.16222-1-mhocko@kernel.org>

From: Michal Hocko <mhocko@suse.com>

kjournald2 is central to the transaction commit processing. As such any
potential allocation from this kernel thread has to be GFP_NOFS. Make
sure to mark the whole kernel thread GFP_NOFS by the memalloc_nofs_save.

Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 fs/jbd2/journal.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 704139625fbe..662531a70ce1 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -206,6 +206,13 @@ static int kjournald2(void *arg)
 	wake_up(&journal->j_wait_done_commit);
 
 	/*
+	 * Make sure that no allocations from this kernel thread will ever recurse
+	 * to the fs layer because we are responsible for the transaction commit
+	 * and any fs involvement might get stuck waiting for the trasn. commit.
+	 */
+	memalloc_nofs_save();
+
+	/*
 	 * And now, wait forever for commit wakeup events.
 	 */
 	write_lock(&journal->j_state_lock);
-- 
2.11.0


WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>, linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
	djwong@kernel.org, Theodore Ts'o <tytso@mit.edu>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.cz>,
	Jan Kara <jack@suse.cz>,
	ceph-devel@vger.kernel.org, cluster-devel@redhat.com,
	linux-nfs@vger.kernel.org, logfs@logfs.org,
	linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	reiserfs-devel@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-afs@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: [PATCH 6/6] jbd2: make the whole kjournald2 kthread NOFS safe
Date: Mon,  6 Feb 2017 15:07:18 +0100	[thread overview]
Message-ID: <20170206140718.16222-7-mhocko@kernel.org> (raw)
In-Reply-To: <20170206140718.16222-1-mhocko@kernel.org>

From: Michal Hocko <mhocko@suse.com>

kjournald2 is central to the transaction commit processing. As such any
potential allocation from this kernel thread has to be GFP_NOFS. Make
sure to mark the whole kernel thread GFP_NOFS by the memalloc_nofs_save.

Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 fs/jbd2/journal.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 704139625fbe..662531a70ce1 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -206,6 +206,13 @@ static int kjournald2(void *arg)
 	wake_up(&journal->j_wait_done_commit);
 
 	/*
+	 * Make sure that no allocations from this kernel thread will ever recurse
+	 * to the fs layer because we are responsible for the transaction commit
+	 * and any fs involvement might get stuck waiting for the trasn. commit.
+	 */
+	memalloc_nofs_save();
+
+	/*
 	 * And now, wait forever for commit wakeup events.
 	 */
 	write_lock(&journal->j_state_lock);
-- 
2.11.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 6/6] jbd2: make the whole kjournald2 kthread NOFS safe
Date: Mon,  6 Feb 2017 15:07:18 +0100	[thread overview]
Message-ID: <20170206140718.16222-7-mhocko@kernel.org> (raw)
In-Reply-To: <20170206140718.16222-1-mhocko@kernel.org>

From: Michal Hocko <mhocko@suse.com>

kjournald2 is central to the transaction commit processing. As such any
potential allocation from this kernel thread has to be GFP_NOFS. Make
sure to mark the whole kernel thread GFP_NOFS by the memalloc_nofs_save.

Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 fs/jbd2/journal.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 704139625fbe..662531a70ce1 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -206,6 +206,13 @@ static int kjournald2(void *arg)
 	wake_up(&journal->j_wait_done_commit);
 
 	/*
+	 * Make sure that no allocations from this kernel thread will ever recurse
+	 * to the fs layer because we are responsible for the transaction commit
+	 * and any fs involvement might get stuck waiting for the trasn. commit.
+	 */
+	memalloc_nofs_save();
+
+	/*
 	 * And now, wait forever for commit wakeup events.
 	 */
 	write_lock(&journal->j_state_lock);
-- 
2.11.0



  parent reply	other threads:[~2017-02-06 14:07 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 14:07 [PATCH 0/6 v4] scope GFP_NOFS api Michal Hocko
2017-02-06 14:07 ` [Cluster-devel] " Michal Hocko
2017-02-06 14:07 ` Michal Hocko
2017-02-06 14:07 ` Michal Hocko
2017-02-06 14:07 ` Michal Hocko
2017-02-06 14:07 ` Michal Hocko
2017-02-06 14:07 ` Michal Hocko
2017-02-06 14:07 ` [PATCH 1/6] lockdep: allow to disable reclaim lockup detection Michal Hocko
2017-02-06 14:07   ` [Cluster-devel] " Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:26   ` Matthew Wilcox
2017-02-06 14:26     ` [Cluster-devel] " Matthew Wilcox
2017-02-06 14:26     ` Matthew Wilcox
2017-02-06 14:34     ` Michal Hocko
2017-02-06 14:34       ` [Cluster-devel] " Michal Hocko
2017-02-06 14:34       ` Michal Hocko
2017-02-06 15:24       ` Matthew Wilcox
2017-02-06 15:24         ` [Cluster-devel] " Matthew Wilcox
2017-02-06 15:24         ` Matthew Wilcox
2017-02-06 15:30         ` Michal Hocko
2017-02-06 15:30           ` [Cluster-devel] " Michal Hocko
2017-02-06 15:30           ` Michal Hocko
2017-02-06 14:07 ` [PATCH 2/6] xfs: abstract PF_FSTRANS to PF_MEMALLOC_NOFS Michal Hocko
2017-02-06 14:07   ` [Cluster-devel] " Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07 ` [PATCH 3/6] mm: introduce memalloc_nofs_{save,restore} API Michal Hocko
2017-02-06 14:07   ` [Cluster-devel] [PATCH 3/6] mm: introduce memalloc_nofs_{save, restore} API Michal Hocko
2017-02-06 14:07   ` [PATCH 3/6] mm: introduce memalloc_nofs_{save,restore} API Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07 ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} instead of memalloc_noio* Michal Hocko
2017-02-06 14:07   ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 15:39   ` Matthew Wilcox
2017-02-06 15:39     ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Matthew Wilcox
2017-02-06 15:39     ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Matthew Wilcox
2017-02-06 17:44     ` Michal Hocko
2017-02-06 17:44       ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Michal Hocko
2017-02-06 17:44       ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Michal Hocko
2017-02-06 18:32       ` Darrick J. Wong
2017-02-06 18:32         ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Darrick J. Wong
2017-02-06 18:32         ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Darrick J. Wong
2017-02-06 18:47         ` Michal Hocko
2017-02-06 18:47           ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Michal Hocko
2017-02-06 18:47           ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Michal Hocko
2017-02-06 19:51           ` Darrick J. Wong
2017-02-06 19:51             ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Darrick J. Wong
2017-02-06 19:51             ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Darrick J. Wong
2017-02-06 21:18             ` Michal Hocko
2017-02-06 21:18               ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Michal Hocko
2017-02-06 21:18               ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Michal Hocko
2017-02-06 22:51           ` Dave Chinner
2017-02-06 22:51             ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Dave Chinner
2017-02-06 22:51             ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Dave Chinner
2017-02-07  7:17             ` Michal Hocko
2017-02-07  7:17               ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} " Michal Hocko
2017-02-07  7:17               ` [PATCH 4/6] xfs: use memalloc_nofs_{save,restore} " Michal Hocko
2017-02-06 14:07 ` [PATCH 5/6] jbd2: mark the transaction context with the scope GFP_NOFS context Michal Hocko
2017-02-06 14:07   ` [Cluster-devel] " Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07 ` Michal Hocko [this message]
2017-02-06 14:07   ` [Cluster-devel] [PATCH 6/6] jbd2: make the whole kjournald2 kthread NOFS safe Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko
2017-02-06 14:07   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206140718.16222-7-mhocko@kernel.org \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=clm@fb.com \
    --cc=cluster-devel@redhat.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=dsterba@suse.cz \
    --cc=jack@suse.cz \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=linux-xfs@vger.kernel.org \
    --cc=logfs@logfs.org \
    --cc=mhocko@suse.com \
    --cc=reiserfs-devel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.