From: Mark Brown <broonie@kernel.org>
To: Matt Flax <flatmax@flatmax.org>
Cc: alsa-devel@alsa-project.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>,
phil@raspberrypi.org, Eric Anholt <eric@anholt.net>,
Florian Meier <florian.meier@koalo.de>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: bcm2835: Increase channels_max to 8
Date: Mon, 6 Feb 2017 16:43:59 +0000 [thread overview]
Message-ID: <20170206164359.vnyxa5iumtslxisy@sirena.org.uk> (raw)
In-Reply-To: <aa6b9cbd-e033-eee6-d7f8-8ba8c8e611ab@flatmax.org>
[-- Attachment #1.1: Type: text/plain, Size: 1368 bytes --]
On Mon, Feb 06, 2017 at 07:37:03AM +1100, Matt Flax wrote:
> On 06/02/17 03:34, Mark Brown wrote:
> > Looking at the driver it may be possible for the hardware to do DSP
> > modes at which point this gets much easier but right now it only has I2S
> > support, I've got a feeling that the other end of the link may actually
> > be running in a DSP mode.
> You've got it !
If you're actually using the device in DSP mode you need to be showing
that in the driver, not claiming that it's I2S.
> I haven't looked into why, but I am getting the correct channel mapping
> under the hood. To me that is a concern of the higher up levels of the ALSA
> driver - it was a pleasant surprise when it worked nicely, because to me it
> indicated a robustly coded system.
If the external device is running in DSP mode it'll work fine.
> My next patch is to allow DSP modes in this I2S driver. I wanted to make
> sure that this got through first however.
This is the wrong way round.
> The majority of these other concerns you mention are controlled at the
> machine driver level.
The driver should be checking for errors, it shouldn't be silently
accepting incorrect configurations - we shouldn't be forcing all the
machine drivers to replicate code for this, or requiring modifications
to machine drivers because a new feature has been added to one of the
drivers it uses.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: bcm2835: Increase channels_max to 8
Date: Mon, 6 Feb 2017 16:43:59 +0000 [thread overview]
Message-ID: <20170206164359.vnyxa5iumtslxisy@sirena.org.uk> (raw)
In-Reply-To: <aa6b9cbd-e033-eee6-d7f8-8ba8c8e611ab@flatmax.org>
On Mon, Feb 06, 2017 at 07:37:03AM +1100, Matt Flax wrote:
> On 06/02/17 03:34, Mark Brown wrote:
> > Looking at the driver it may be possible for the hardware to do DSP
> > modes at which point this gets much easier but right now it only has I2S
> > support, I've got a feeling that the other end of the link may actually
> > be running in a DSP mode.
> You've got it !
If you're actually using the device in DSP mode you need to be showing
that in the driver, not claiming that it's I2S.
> I haven't looked into why, but I am getting the correct channel mapping
> under the hood. To me that is a concern of the higher up levels of the ALSA
> driver - it was a pleasant surprise when it worked nicely, because to me it
> indicated a robustly coded system.
If the external device is running in DSP mode it'll work fine.
> My next patch is to allow DSP modes in this I2S driver. I wanted to make
> sure that this got through first however.
This is the wrong way round.
> The majority of these other concerns you mention are controlled at the
> machine driver level.
The driver should be checking for errors, it shouldn't be silently
accepting incorrect configurations - we shouldn't be forcing all the
machine drivers to replicate code for this, or requiring modifications
to machine drivers because a new feature has been added to one of the
drivers it uses.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170206/c57d4efb/attachment.sig>
next prev parent reply other threads:[~2017-02-06 16:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 23:37 [PATCH] ASoC: bcm2835: Increase channels_max to 8 Matt Flax
2017-02-01 23:37 ` Matt Flax
2017-02-04 15:49 ` Mark Brown
2017-02-04 15:49 ` Mark Brown
2017-02-05 1:26 ` Matt Flax
2017-02-05 1:26 ` [alsa-devel] " Matt Flax
2017-02-05 10:20 ` Florian Kauer
2017-02-05 10:20 ` Florian Kauer
2017-02-05 10:55 ` Matt Flax
2017-02-05 10:55 ` [alsa-devel] " Matt Flax
2017-02-05 16:34 ` Mark Brown
2017-02-05 16:34 ` [alsa-devel] " Mark Brown
2017-02-05 20:37 ` Matt Flax
2017-02-05 20:37 ` [alsa-devel] " Matt Flax
2017-02-05 22:49 ` Matt Flax
2017-02-05 22:49 ` [alsa-devel] " Matt Flax
2017-02-06 16:43 ` Mark Brown [this message]
2017-02-06 16:43 ` Mark Brown
2017-02-06 20:25 ` Matt Flax
2017-02-06 20:25 ` [alsa-devel] " Matt Flax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206164359.vnyxa5iumtslxisy@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=eric@anholt.net \
--cc=flatmax@flatmax.org \
--cc=florian.meier@koalo.de \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=phil@raspberrypi.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.