All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: stefan.bruens@rwth-aachen.de
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications
Date: Tue, 07 Feb 2017 12:58:25 -0500 (EST)	[thread overview]
Message-ID: <20170207.125825.646803866093568777.davem@davemloft.net> (raw)
In-Reply-To: <e854396b8b354f08ab42647417958079@rwthex-w2-b.rwth-ad.de>

From: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Date: Mon, 6 Feb 2017 21:20:33 +0100

>  
>  	/* Validate the protocol  - only support UMTS for now */
> -	if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) {
> +	if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) {
 ...
> +	} else if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS_DS) {
> +		expected_length = SIERRA_NET_LSI_UMTS_DS_STATUS_LEN;

If you are now supporting more protocols, that comment is not correct
any longer.  You therefore need to update it or remove it.

Thanks.

  reply	other threads:[~2017-02-07 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170206202034.10962-1-stefan.bruens@rwth-aachen.de>
2017-02-06 20:20 ` [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications Stefan Brüns
2017-02-07 17:58   ` David Miller [this message]
2017-02-06 20:20 ` [PATCH 2/2] sierra_net: Skip validating irrelevant fields for IDLE LSIs Stefan Brüns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207.125825.646803866093568777.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefan.bruens@rwth-aachen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.