* [PATCH] xfstests-bld: use old key prefix in ext4 encrypt config
@ 2017-02-06 21:42 Eric Biggers
2017-02-07 17:41 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2017-02-06 21:42 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
For the ext4 encrypt config, add the dummy key using the "ext4:" prefix
instead of the "fscrypt:" prefix. This will allow xfstests-bld to test
any old kernels to which the change to make test_dummy_encryption
require a keyring key may get backported. (Of course, it also remains
able to test old kernels to which that change has *not* been
backported.) Using the old / fs-specific key prefix is also consistent
with the xfstests in the "encrypt" group, which use the fs-specific key
prefix to allow the tests to run unmodified on older kernels.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/test-appliance/files/root/fs/ext4/config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/config b/kvm-xfstests/test-appliance/files/root/fs/ext4/config
index 86840e0..9fde22c 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/config
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/config
@@ -46,7 +46,7 @@ function setup_mount_opts()
fi
local key="${mode}${raw}${size}"
keyctl new_session
- echo -n -e "${key}" | keyctl padd logon fscrypt:4242424242424242 @s
+ echo -n -e "${key}" | keyctl padd logon ext4:4242424242424242 @s
fi
}
--
2.11.0.483.g087da7b7c-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests-bld: use old key prefix in ext4 encrypt config
2017-02-06 21:42 [PATCH] xfstests-bld: use old key prefix in ext4 encrypt config Eric Biggers
@ 2017-02-07 17:41 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-02-07 17:41 UTC (permalink / raw)
To: Eric Biggers; +Cc: fstests, Eric Biggers
On Mon, Feb 06, 2017 at 01:42:35PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> For the ext4 encrypt config, add the dummy key using the "ext4:" prefix
> instead of the "fscrypt:" prefix. This will allow xfstests-bld to test
> any old kernels to which the change to make test_dummy_encryption
> require a keyring key may get backported. (Of course, it also remains
> able to test old kernels to which that change has *not* been
> backported.) Using the old / fs-specific key prefix is also consistent
> with the xfstests in the "encrypt" group, which use the fs-specific key
> prefix to allow the tests to run unmodified on older kernels.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-07 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 21:42 [PATCH] xfstests-bld: use old key prefix in ext4 encrypt config Eric Biggers
2017-02-07 17:41 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.