From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH] arm64: dts: Enable ir-spi in the tm2 and tm2e boards
Date: Tue, 7 Feb 2017 23:12:33 +0200 [thread overview]
Message-ID: <20170207211233.ge3fzw5x2fvebpjq@kozik-lap> (raw)
In-Reply-To: <20170207081325.9769-1-andi.shyti@samsung.com>
On Tue, Feb 07, 2017 at 05:13:25PM +0900, Andi Shyti wrote:
> Add the device tree node for the ir-spi driver which enable the
> ir led for remote controlling.
>
> This patch sets first the GPR3[3] gpio line as a regulator-fixed
> for enabling an external regulator which powers the IR LED.
>
> Removes also the default assignment of the GPG3[5] and GPG3[7]
> related to the SPI3 line.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 27 ++++++++++++++++++++--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 098ad557fee3..c61df2318d8b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -106,6 +106,13 @@
> };
> };
>
> + irda_regulator: irda-regulator {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpr3 3 0>;
GPIO_ACTIVE_HIGH
> + regulator-name = "irda_regulator";
> + };
> +
> sound {
> compatible = "samsung,tm2-audio";
> audio-codec = <&wm5110>;
> @@ -1073,8 +1080,6 @@
>
> PIN(INPUT, gpg3-0, DOWN, FAST_SR1);
> PIN(INPUT, gpg3-1, DOWN, FAST_SR1);
> - PIN(INPUT, gpg3-5, DOWN, FAST_SR1);
> - PIN(INPUT, gpg3-7, DOWN, FAST_SR1);
I think gpg3-5 would be missing its configuration. It is not present in
spi3 bus pins. Is it a chip select pin? If you remove the default
configuration, it will still work as input-pull down because no one is
setting different config. Why you need to touch gpg3-5?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Andi Shyti <andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Javier Martinez Canillas
<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andi Shyti <andi-ahk0KpmfxKRAfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH] arm64: dts: Enable ir-spi in the tm2 and tm2e boards
Date: Tue, 7 Feb 2017 23:12:33 +0200 [thread overview]
Message-ID: <20170207211233.ge3fzw5x2fvebpjq@kozik-lap> (raw)
In-Reply-To: <20170207081325.9769-1-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Tue, Feb 07, 2017 at 05:13:25PM +0900, Andi Shyti wrote:
> Add the device tree node for the ir-spi driver which enable the
> ir led for remote controlling.
>
> This patch sets first the GPR3[3] gpio line as a regulator-fixed
> for enabling an external regulator which powers the IR LED.
>
> Removes also the default assignment of the GPG3[5] and GPG3[7]
> related to the SPI3 line.
>
> Signed-off-by: Andi Shyti <andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 27 ++++++++++++++++++++--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 098ad557fee3..c61df2318d8b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -106,6 +106,13 @@
> };
> };
>
> + irda_regulator: irda-regulator {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpr3 3 0>;
GPIO_ACTIVE_HIGH
> + regulator-name = "irda_regulator";
> + };
> +
> sound {
> compatible = "samsung,tm2-audio";
> audio-codec = <&wm5110>;
> @@ -1073,8 +1080,6 @@
>
> PIN(INPUT, gpg3-0, DOWN, FAST_SR1);
> PIN(INPUT, gpg3-1, DOWN, FAST_SR1);
> - PIN(INPUT, gpg3-5, DOWN, FAST_SR1);
> - PIN(INPUT, gpg3-7, DOWN, FAST_SR1);
I think gpg3-5 would be missing its configuration. It is not present in
spi3 bus pins. Is it a chip select pin? If you remove the default
configuration, it will still work as input-pull down because no one is
setting different config. Why you need to touch gpg3-5?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: Enable ir-spi in the tm2 and tm2e boards
Date: Tue, 7 Feb 2017 23:12:33 +0200 [thread overview]
Message-ID: <20170207211233.ge3fzw5x2fvebpjq@kozik-lap> (raw)
In-Reply-To: <20170207081325.9769-1-andi.shyti@samsung.com>
On Tue, Feb 07, 2017 at 05:13:25PM +0900, Andi Shyti wrote:
> Add the device tree node for the ir-spi driver which enable the
> ir led for remote controlling.
>
> This patch sets first the GPR3[3] gpio line as a regulator-fixed
> for enabling an external regulator which powers the IR LED.
>
> Removes also the default assignment of the GPG3[5] and GPG3[7]
> related to the SPI3 line.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 27 ++++++++++++++++++++--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 098ad557fee3..c61df2318d8b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -106,6 +106,13 @@
> };
> };
>
> + irda_regulator: irda-regulator {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpr3 3 0>;
GPIO_ACTIVE_HIGH
> + regulator-name = "irda_regulator";
> + };
> +
> sound {
> compatible = "samsung,tm2-audio";
> audio-codec = <&wm5110>;
> @@ -1073,8 +1080,6 @@
>
> PIN(INPUT, gpg3-0, DOWN, FAST_SR1);
> PIN(INPUT, gpg3-1, DOWN, FAST_SR1);
> - PIN(INPUT, gpg3-5, DOWN, FAST_SR1);
> - PIN(INPUT, gpg3-7, DOWN, FAST_SR1);
I think gpg3-5 would be missing its configuration. It is not present in
spi3 bus pins. Is it a chip select pin? If you remove the default
configuration, it will still work as input-pull down because no one is
setting different config. Why you need to touch gpg3-5?
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-02-07 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170207081338epcas5p23530ff8663c58f8868a0f9dfa2e19f7a@epcas5p2.samsung.com>
2017-02-07 8:13 ` [PATCH] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Andi Shyti
2017-02-07 8:13 ` Andi Shyti
2017-02-07 8:13 ` Andi Shyti
2017-02-07 21:12 ` Krzysztof Kozlowski [this message]
2017-02-07 21:12 ` Krzysztof Kozlowski
2017-02-07 21:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207211233.ge3fzw5x2fvebpjq@kozik-lap \
--to=krzk@kernel.org \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.