* [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
@ 2017-02-08 0:47 Carlos Palminha
2017-02-08 0:58 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Carlos Palminha @ 2017-02-08 0:47 UTC (permalink / raw)
To: devel, linux-kernel; +Cc: Carlos Palminha, gregkh
Fixed the following sparse warnings:
* cast from restricted __le32
* invalid assignment from int to __le32
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/staging/rtl8712/rtl8712_xmit.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
index c4f03a602a2e..67713643c923 100644
--- a/drivers/staging/rtl8712/rtl8712_xmit.c
+++ b/drivers/staging/rtl8712/rtl8712_xmit.c
@@ -561,19 +561,19 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
ptxdesc_mp = &txdesc_mp;
/* offset 8 */
- ptxdesc->txdw2 = cpu_to_le32(ptxdesc_mp->txdw2);
+ ptxdesc->txdw2 = ptxdesc_mp->txdw2;
if (bmcst)
ptxdesc->txdw2 |= cpu_to_le32(BMC);
ptxdesc->txdw2 |= cpu_to_le32(BK);
/* offset 16 */
- ptxdesc->txdw4 = cpu_to_le32(ptxdesc_mp->txdw4);
+ ptxdesc->txdw4 = ptxdesc_mp->txdw4;
/* offset 20 */
- ptxdesc->txdw5 = cpu_to_le32(ptxdesc_mp->txdw5);
+ ptxdesc->txdw5 = ptxdesc_mp->txdw5;
pattrib->pctrl = 0;/* reset to zero; */
}
} else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {
/* offset 4 */
- ptxdesc->txdw1 |= (0x05) & 0x1f;/*CAM_ID(MAC_ID), default=5;*/
+ ptxdesc->txdw1 |= cpu_to_le32((0x05) & 0x1f);/*CAM_ID(MAC_ID), default=5;*/
qsel = (uint)(pattrib->qsel & 0x0000001f);
ptxdesc->txdw1 |= cpu_to_le32((qsel << QSEL_SHT) & 0x00001f00);
ptxdesc->txdw1 |= cpu_to_le32(BIT(16));/* Non-QoS */
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
2017-02-08 0:47 [PATCH] staging: rtl8712: rtl8712: fix sparse warnings Carlos Palminha
@ 2017-02-08 0:58 ` Dan Carpenter
2017-02-08 1:19 ` Carlos Palminha
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2017-02-08 0:58 UTC (permalink / raw)
To: Carlos Palminha; +Cc: devel, linux-kernel, gregkh
On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
> Fixed the following sparse warnings:
> * cast from restricted __le32
> * invalid assignment from int to __le32
>
The changelog doesn't give me any confidence that you understand the
implications of this patch. You silenced the warning but I think you
may be introducing bugs (I haven't done a thourough review).
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
2017-02-08 0:58 ` Dan Carpenter
@ 2017-02-08 1:19 ` Carlos Palminha
2017-02-08 6:09 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Carlos Palminha @ 2017-02-08 1:19 UTC (permalink / raw)
To: Dan Carpenter, Carlos Palminha; +Cc: devel, linux-kernel, gregkh
On 08-02-2017 00:58, Dan Carpenter wrote:
> On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
>> Fixed the following sparse warnings:
>> * cast from restricted __le32
>> * invalid assignment from int to __le32
>>
>
> The changelog doesn't give me any confidence that you understand the
> implications of this patch. You silenced the warning but I think you
> may be introducing bugs (I haven't done a thourough review).
>
> regards,
> dan carpenter
>
true... i was short on words.
will resend v2 with better description.
Regards,
C.Palminha
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
2017-02-08 1:19 ` Carlos Palminha
@ 2017-02-08 6:09 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-02-08 6:09 UTC (permalink / raw)
To: Carlos Palminha; +Cc: devel, gregkh, linux-kernel
On Wed, Feb 08, 2017 at 01:19:39AM +0000, Carlos Palminha wrote:
>
>
> On 08-02-2017 00:58, Dan Carpenter wrote:
> >On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
> >>Fixed the following sparse warnings:
> >>* cast from restricted __le32
> >>* invalid assignment from int to __le32
> >>
> >
> >The changelog doesn't give me any confidence that you understand the
> >implications of this patch. You silenced the warning but I think you
> >may be introducing bugs (I haven't done a thourough review).
> >
> >regards,
> >dan carpenter
> >
> true... i was short on words.
> will resend v2 with better description.
I'm pretty sure the original code is correct and just the sparse
annotations are wrong.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-08 6:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-08 0:47 [PATCH] staging: rtl8712: rtl8712: fix sparse warnings Carlos Palminha
2017-02-08 0:58 ` Dan Carpenter
2017-02-08 1:19 ` Carlos Palminha
2017-02-08 6:09 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.