From: Maxime Ripard <maxime.ripard@free-electrons.com> To: Rob Herring <robh@kernel.org> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@intel.com>, Sean Paul <seanpaul@chromium.org>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Archit Taneja <architt@codeaurora.org>, Jingoo Han <jingoohan1@gmail.com>, Inki Dae <inki.dae@samsung.com>, Joonyoung Shim <jy0922.shim@samsung.com>, Seung-Woo Kim <sw0312.kim@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Javier Martinez Canillas <javier@osg.samsung.com>, Stefan Agner <stefan@agner.ch>, Alison Wang <alison.wang@freescale.com>, Xinliang Liu <z.liuxinliang@hisilicon.com>, Rongrong Zou <zourongrong@gmail.com>, Xinwei Kong <kong.kongxinwei@hisilicon.com>, Chen Feng <puck.chen@hisilicon.com>, Philipp Zabel <p.zabel@pengutronix.de>, CK Hu <ck.hu@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Marek Vasut <marex@denx.de>, Mark Yao <mark.yao@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>, Chen-Yu Tsai <wens@csie.org>, Liviu Dudau <liviu.dudau@arm.com>, Mali DP Maintainers <malidp@foss.arm.com>, Neil Armstrong <narmstrong@baylibre.com>, Carlo Caione <carlo@caione.org>, Kevin Hilman <khilman@baylibre.com>, Rob Clark <robdclark@gmail.com>, Jyri Sarha <jsarha@ti.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Eric Anholt <eric@anholt.net>, Russell King <rmk+kernel@armlinux.org.uk> Subject: Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge Date: Wed, 8 Feb 2017 08:46:32 +0100 [thread overview] Message-ID: <20170208074632.n35dqoz2rz24ncx3@lukather> (raw) In-Reply-To: <20170206173201.wkv5snwhvkrjruwi@rob-hp-laptop> [-- Attachment #1: Type: text/plain, Size: 6105 bytes --] Hi Rob, On Mon, Feb 06, 2017 at 11:32:01AM -0600, Rob Herring wrote: > On Mon, Feb 06, 2017 at 11:03:01AM +0100, Maxime Ripard wrote: > > Hi Rob, > > > > On Fri, Feb 03, 2017 at 09:36:34PM -0600, Rob Herring wrote: > > > Similar to the previous commit, convert drivers open coding OF graph > > > parsing to use drm_of_find_panel_or_bridge instead. > > > > > > This changes some error messages to debug messages (in the graph core). > > > Graph connections are often "no connects" depending on the particular > > > board, so we want to avoid spurious messages. Plus the kernel is not a > > > DT validator. > > > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > > [..] > > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c > > > index f5e86fe7750e..4720725b0fb0 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c > > > @@ -15,6 +15,7 @@ > > > #include <drm/drmP.h> > > > #include <drm/drm_atomic_helper.h> > > > #include <drm/drm_crtc_helper.h> > > > +#include <drm/drm_of.h> > > > #include <drm/drm_panel.h> > > > > > > #include "sun4i_drv.h" > > > @@ -217,12 +218,10 @@ int sun4i_rgb_init(struct drm_device *drm) > > > rgb->drv = drv; > > > encoder = &rgb->encoder; > > > > > > - tcon->panel = sun4i_tcon_find_panel(tcon->dev->of_node); > > > - encoder->bridge = sun4i_tcon_find_bridge(tcon->dev->of_node); > > > - if (IS_ERR(tcon->panel) && IS_ERR(encoder->bridge)) { > > > - dev_info(drm->dev, "No panel or bridge found... RGB output disabled\n"); > > > - return 0; > > > - } > > > + ret = drm_of_find_panel_or_bridge(tcon->dev->of_node, 1, 0, > > > + &tcon->panel, &encoder->bridge); > > > + if (ret) > > > + return ret; > > > > It used to ignore the error if it couldn't find the bridge. This will > > break the probe. > > Well, I got it half right. :) The probe does that, but this needs to > too. > > > > > > > drm_encoder_helper_add(&rgb->encoder, > > > &sun4i_rgb_enc_helper_funcs); > > > @@ -239,7 +238,7 @@ int sun4i_rgb_init(struct drm_device *drm) > > > /* The RGB encoder can only work with the TCON channel 0 */ > > > rgb->encoder.possible_crtcs = BIT(0); > > > > > > - if (!IS_ERR(tcon->panel)) { > > > + if (tcon->panel) { > > > drm_connector_helper_add(&rgb->connector, > > > &sun4i_rgb_con_helper_funcs); > > > ret = drm_connector_init(drm, &rgb->connector, > > > @@ -260,7 +259,7 @@ int sun4i_rgb_init(struct drm_device *drm) > > > } > > > } > > > > > > - if (!IS_ERR(encoder->bridge)) { > > > + if (encoder->bridge) { > > > encoder->bridge->encoder = &rgb->encoder; > > > > > > ret = drm_bridge_attach(drm, encoder->bridge); > > > @@ -268,8 +267,6 @@ int sun4i_rgb_init(struct drm_device *drm) > > > dev_err(drm->dev, "Couldn't attach our bridge\n"); > > > goto err_cleanup_connector; > > > } > > > - } else { > > > - encoder->bridge = NULL; > > > } > > > > > > return 0; > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > index ea2906f87cb9..2e4e365cecf9 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > @@ -15,13 +15,12 @@ > > > #include <drm/drm_crtc.h> > > > #include <drm/drm_crtc_helper.h> > > > #include <drm/drm_modes.h> > > > -#include <drm/drm_panel.h> > > > +#include <drm/drm_of.h> > > > > > > #include <linux/component.h> > > > #include <linux/ioport.h> > > > #include <linux/of_address.h> > > > #include <linux/of_device.h> > > > -#include <linux/of_graph.h> > > > #include <linux/of_irq.h> > > > #include <linux/regmap.h> > > > #include <linux/reset.h> > > > @@ -405,74 +404,6 @@ static int sun4i_tcon_init_regmap(struct device *dev, > > > return 0; > > > } > > > > > > -struct drm_panel *sun4i_tcon_find_panel(struct device_node *node) > > > -{ > > > - struct device_node *port, *remote, *child; > > > - struct device_node *end_node = NULL; > > > - > > > - /* Inputs are listed first, then outputs */ > > > - port = of_graph_get_port_by_id(node, 1); > > > - > > > - /* > > > - * Our first output is the RGB interface where the panel will > > > - * be connected. > > > - */ > > > - for_each_child_of_node(port, child) { > > > - u32 reg; > > > - > > > - of_property_read_u32(child, "reg", ®); > > > - if (reg == 0) > > > - end_node = child; > > > - } > > > - > > > - if (!end_node) { > > > - DRM_DEBUG_DRIVER("Missing panel endpoint\n"); > > > - return ERR_PTR(-ENODEV); > > > - } > > > - > > > - remote = of_graph_get_remote_port_parent(end_node); > > > - if (!remote) { > > > - DRM_DEBUG_DRIVER("Unable to parse remote node\n"); > > > - return ERR_PTR(-EINVAL); > > > - } > > > - > > > - return of_drm_find_panel(remote) ?: ERR_PTR(-EPROBE_DEFER); > > > > And the panel is only one of our endpoints, which is optional, while > > other endpoints are mandatory. This means that we might very well have > > an endpoint that is not a panel or a bridge. In this case, I think > > your function will return an error and will be treated as such, while > > it's really the expected behaviour. > > > > I think it's better to leave this driver alone for now, it's not as > > trivial as it looks, and will require some testing to get things > > right. I'll try to get my head around how to use your new (very > > welcome) helpers. > > Well, certainly it needs testing. But this is one of the easier examples > because you are requesting a specific port/endpoint number. It's the > drivers that just loop over all the endpoints that give me more > problems. Oh, right... I missed that you were giving the port and endpoint numbers.. > Anyway, this is 4.12 material, so I'll make the fix above and want > to leave this in for now. Ok, I'll test it, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com> To: Rob Herring <robh@kernel.org> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@intel.com>, Sean Paul <seanpaul@chromium.org>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Archit Taneja <architt@codeaurora.org>, Jingoo Han <jingoohan1@gmail.com>, Inki Dae <inki.dae@samsung.com>, Joonyoung Shim <jy0922.shim@samsung.com>, Seung-Woo Kim <sw0312.kim@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Javier Martinez Canillas <javier@osg.samsung.com>, Stefan Agner <stefan@agner.ch>, Alison Wang <alison.wang@freescale.com>, Xinliang Liu <z.liuxinliang@hisi> Subject: Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge Date: Wed, 8 Feb 2017 08:46:32 +0100 [thread overview] Message-ID: <20170208074632.n35dqoz2rz24ncx3@lukather> (raw) In-Reply-To: <20170206173201.wkv5snwhvkrjruwi@rob-hp-laptop> [-- Attachment #1: Type: text/plain, Size: 6105 bytes --] Hi Rob, On Mon, Feb 06, 2017 at 11:32:01AM -0600, Rob Herring wrote: > On Mon, Feb 06, 2017 at 11:03:01AM +0100, Maxime Ripard wrote: > > Hi Rob, > > > > On Fri, Feb 03, 2017 at 09:36:34PM -0600, Rob Herring wrote: > > > Similar to the previous commit, convert drivers open coding OF graph > > > parsing to use drm_of_find_panel_or_bridge instead. > > > > > > This changes some error messages to debug messages (in the graph core). > > > Graph connections are often "no connects" depending on the particular > > > board, so we want to avoid spurious messages. Plus the kernel is not a > > > DT validator. > > > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > > [..] > > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c > > > index f5e86fe7750e..4720725b0fb0 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c > > > @@ -15,6 +15,7 @@ > > > #include <drm/drmP.h> > > > #include <drm/drm_atomic_helper.h> > > > #include <drm/drm_crtc_helper.h> > > > +#include <drm/drm_of.h> > > > #include <drm/drm_panel.h> > > > > > > #include "sun4i_drv.h" > > > @@ -217,12 +218,10 @@ int sun4i_rgb_init(struct drm_device *drm) > > > rgb->drv = drv; > > > encoder = &rgb->encoder; > > > > > > - tcon->panel = sun4i_tcon_find_panel(tcon->dev->of_node); > > > - encoder->bridge = sun4i_tcon_find_bridge(tcon->dev->of_node); > > > - if (IS_ERR(tcon->panel) && IS_ERR(encoder->bridge)) { > > > - dev_info(drm->dev, "No panel or bridge found... RGB output disabled\n"); > > > - return 0; > > > - } > > > + ret = drm_of_find_panel_or_bridge(tcon->dev->of_node, 1, 0, > > > + &tcon->panel, &encoder->bridge); > > > + if (ret) > > > + return ret; > > > > It used to ignore the error if it couldn't find the bridge. This will > > break the probe. > > Well, I got it half right. :) The probe does that, but this needs to > too. > > > > > > > drm_encoder_helper_add(&rgb->encoder, > > > &sun4i_rgb_enc_helper_funcs); > > > @@ -239,7 +238,7 @@ int sun4i_rgb_init(struct drm_device *drm) > > > /* The RGB encoder can only work with the TCON channel 0 */ > > > rgb->encoder.possible_crtcs = BIT(0); > > > > > > - if (!IS_ERR(tcon->panel)) { > > > + if (tcon->panel) { > > > drm_connector_helper_add(&rgb->connector, > > > &sun4i_rgb_con_helper_funcs); > > > ret = drm_connector_init(drm, &rgb->connector, > > > @@ -260,7 +259,7 @@ int sun4i_rgb_init(struct drm_device *drm) > > > } > > > } > > > > > > - if (!IS_ERR(encoder->bridge)) { > > > + if (encoder->bridge) { > > > encoder->bridge->encoder = &rgb->encoder; > > > > > > ret = drm_bridge_attach(drm, encoder->bridge); > > > @@ -268,8 +267,6 @@ int sun4i_rgb_init(struct drm_device *drm) > > > dev_err(drm->dev, "Couldn't attach our bridge\n"); > > > goto err_cleanup_connector; > > > } > > > - } else { > > > - encoder->bridge = NULL; > > > } > > > > > > return 0; > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > index ea2906f87cb9..2e4e365cecf9 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > @@ -15,13 +15,12 @@ > > > #include <drm/drm_crtc.h> > > > #include <drm/drm_crtc_helper.h> > > > #include <drm/drm_modes.h> > > > -#include <drm/drm_panel.h> > > > +#include <drm/drm_of.h> > > > > > > #include <linux/component.h> > > > #include <linux/ioport.h> > > > #include <linux/of_address.h> > > > #include <linux/of_device.h> > > > -#include <linux/of_graph.h> > > > #include <linux/of_irq.h> > > > #include <linux/regmap.h> > > > #include <linux/reset.h> > > > @@ -405,74 +404,6 @@ static int sun4i_tcon_init_regmap(struct device *dev, > > > return 0; > > > } > > > > > > -struct drm_panel *sun4i_tcon_find_panel(struct device_node *node) > > > -{ > > > - struct device_node *port, *remote, *child; > > > - struct device_node *end_node = NULL; > > > - > > > - /* Inputs are listed first, then outputs */ > > > - port = of_graph_get_port_by_id(node, 1); > > > - > > > - /* > > > - * Our first output is the RGB interface where the panel will > > > - * be connected. > > > - */ > > > - for_each_child_of_node(port, child) { > > > - u32 reg; > > > - > > > - of_property_read_u32(child, "reg", ®); > > > - if (reg == 0) > > > - end_node = child; > > > - } > > > - > > > - if (!end_node) { > > > - DRM_DEBUG_DRIVER("Missing panel endpoint\n"); > > > - return ERR_PTR(-ENODEV); > > > - } > > > - > > > - remote = of_graph_get_remote_port_parent(end_node); > > > - if (!remote) { > > > - DRM_DEBUG_DRIVER("Unable to parse remote node\n"); > > > - return ERR_PTR(-EINVAL); > > > - } > > > - > > > - return of_drm_find_panel(remote) ?: ERR_PTR(-EPROBE_DEFER); > > > > And the panel is only one of our endpoints, which is optional, while > > other endpoints are mandatory. This means that we might very well have > > an endpoint that is not a panel or a bridge. In this case, I think > > your function will return an error and will be treated as such, while > > it's really the expected behaviour. > > > > I think it's better to leave this driver alone for now, it's not as > > trivial as it looks, and will require some testing to get things > > right. I'll try to get my head around how to use your new (very > > welcome) helpers. > > Well, certainly it needs testing. But this is one of the easier examples > because you are requesting a specific port/endpoint number. It's the > drivers that just loop over all the endpoints that give me more > problems. Oh, right... I missed that you were giving the port and endpoint numbers.. > Anyway, this is 4.12 material, so I'll make the fix above and want > to leave this in for now. Ok, I'll test it, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-02-08 8:38 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-04 3:36 [PATCH 0/5] DRM OF graph clean-up Rob Herring 2017-02-04 3:36 ` Rob Herring 2017-02-04 3:36 ` [PATCH 1/5] of: introduce of_graph_get_remote_node Rob Herring 2017-02-04 3:36 ` Rob Herring 2017-02-04 16:10 ` Vladimir Zapolskiy 2017-02-04 16:10 ` Vladimir Zapolskiy 2017-02-06 8:50 ` Daniel Vetter 2017-02-06 8:50 ` Daniel Vetter 2017-02-06 13:41 ` Rob Herring 2017-02-06 13:41 ` Rob Herring 2017-02-06 10:32 ` Philipp Zabel 2017-02-06 10:32 ` Philipp Zabel 2017-02-06 13:54 ` Rob Herring 2017-02-06 13:54 ` Rob Herring 2017-02-06 14:03 ` Philipp Zabel 2017-02-06 14:03 ` Philipp Zabel 2017-02-04 3:36 ` [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge Rob Herring 2017-02-04 3:36 ` Rob Herring 2017-02-06 10:18 ` Liviu Dudau 2017-02-06 10:18 ` Liviu Dudau 2017-02-06 16:20 ` Rob Herring 2017-02-06 16:20 ` Rob Herring 2017-02-06 10:42 ` Philipp Zabel 2017-02-06 10:42 ` Philipp Zabel 2017-02-06 16:53 ` Rob Herring 2017-02-06 16:53 ` Rob Herring 2017-02-06 17:45 ` Philipp Zabel 2017-02-06 17:45 ` Philipp Zabel 2017-02-10 19:42 ` Frank Rowand 2017-02-10 19:42 ` Frank Rowand 2017-02-04 3:36 ` [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Rob Herring 2017-02-04 3:36 ` Rob Herring 2017-02-06 8:31 ` Jyri Sarha 2017-02-06 8:31 ` Jyri Sarha 2017-02-06 10:17 ` Neil Armstrong 2017-02-06 10:17 ` Neil Armstrong 2017-02-06 10:29 ` Liviu Dudau 2017-02-06 10:29 ` Liviu Dudau 2017-02-06 17:09 ` Rob Herring 2017-02-06 17:09 ` Rob Herring 2017-02-06 17:23 ` Liviu Dudau 2017-02-06 17:23 ` Liviu Dudau 2017-02-06 17:34 ` Russell King - ARM Linux 2017-02-06 17:34 ` Russell King - ARM Linux 2017-02-06 17:55 ` Liviu Dudau 2017-02-06 17:55 ` Liviu Dudau 2017-02-06 18:09 ` Russell King - ARM Linux 2017-02-06 18:09 ` Russell King - ARM Linux 2017-02-06 17:42 ` Rob Herring 2017-02-06 17:42 ` Rob Herring 2017-02-06 10:52 ` Philipp Zabel 2017-02-06 10:52 ` Philipp Zabel 2017-02-06 13:40 ` Rob Herring 2017-02-06 13:40 ` Rob Herring 2017-02-08 11:57 ` Liviu Dudau 2017-02-08 11:57 ` Liviu Dudau 2017-02-08 20:44 ` Eric Anholt 2017-02-08 20:44 ` Eric Anholt 2017-02-04 3:36 ` [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge Rob Herring 2017-02-04 3:36 ` Rob Herring 2017-02-04 20:26 ` Fabio Estevam 2017-02-04 20:26 ` Fabio Estevam 2017-02-05 22:25 ` Rob Herring 2017-02-05 22:25 ` Rob Herring 2017-02-06 0:01 ` Fabio Estevam 2017-02-06 0:01 ` Fabio Estevam 2017-02-06 1:22 ` Fabio Estevam 2017-02-06 1:22 ` Fabio Estevam 2017-02-06 10:03 ` Maxime Ripard 2017-02-06 10:03 ` Maxime Ripard 2017-02-06 17:32 ` Rob Herring 2017-02-06 17:32 ` Rob Herring 2017-02-08 7:46 ` Maxime Ripard [this message] 2017-02-08 7:46 ` Maxime Ripard 2017-02-06 11:07 ` Philipp Zabel 2017-02-06 11:07 ` Philipp Zabel 2017-02-04 3:36 ` [PATCH 5/5] drm: omap: use common OF graph helpers Rob Herring 2017-02-04 3:36 ` Rob Herring 2017-02-04 10:47 ` [PATCH 0/5] DRM OF graph clean-up Russell King - ARM Linux 2017-02-04 10:47 ` Russell King - ARM Linux
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170208074632.n35dqoz2rz24ncx3@lukather \ --to=maxime.ripard@free-electrons.com \ --cc=airlied@linux.ie \ --cc=alison.wang@freescale.com \ --cc=architt@codeaurora.org \ --cc=boris.brezillon@free-electrons.com \ --cc=carlo@caione.org \ --cc=ck.hu@mediatek.com \ --cc=daniel.vetter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=frowand.list@gmail.com \ --cc=heiko@sntech.de \ --cc=inki.dae@samsung.com \ --cc=javier@osg.samsung.com \ --cc=jingoohan1@gmail.com \ --cc=jsarha@ti.com \ --cc=jy0922.shim@samsung.com \ --cc=kgene@kernel.org \ --cc=khilman@baylibre.com \ --cc=kong.kongxinwei@hisilicon.com \ --cc=krzk@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-kernel@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=malidp@foss.arm.com \ --cc=marex@denx.de \ --cc=mark.yao@rock-chips.com \ --cc=matthias.bgg@gmail.com \ --cc=narmstrong@baylibre.com \ --cc=p.zabel@pengutronix.de \ --cc=puck.chen@hisilicon.com \ --cc=rmk+kernel@armlinux.org.uk \ --cc=robdclark@gmail.com \ --cc=robh@kernel.org \ --cc=seanpaul@chromium.org \ --cc=stefan@agner.ch \ --cc=sw0312.kim@samsung.com \ --cc=tomi.valkeinen@ti.com \ --cc=wens@csie.org \ --cc=z.liuxinliang@hisilicon.com \ --cc=zourongrong@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.