All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] input: cros_ec_keyb: Add Tablet Mode switch.
@ 2017-01-27 10:52 Enric Balletbo i Serra
  2017-02-01 17:54 ` Dmitry Torokhov
  0 siblings, 1 reply; 5+ messages in thread
From: Enric Balletbo i Serra @ 2017-01-27 10:52 UTC (permalink / raw)
  To: Dmitry Torokhov, Lee Jones
  Cc: linux-input, linux-kernel, Gwendal Grignou, Enric Balletbo Serra

From: Gwendal Grignou <gwendal@chromium.org>

Add switch to report tablet mode.

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Enric Balletbo Serra <enric.balletbo@collabora.com>
---

I should be included this patch in the following patch series but I missed the
patch and found later. Though it can be applied separetely.

 - [PATCH 1/2] mfd: cros-ec: Update cros_ec_commands.h for buttons and switches
 - [PATCH 2/2] input: cros_ec_keyb: Add non-matrix buttons and switches

 drivers/input/keyboard/cros_ec_keyb.c | 5 +++++
 include/linux/mfd/cros_ec_commands.h  | 1 +
 2 files changed, 6 insertions(+)

diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index ad74ebc..604c7ad 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -111,6 +111,11 @@ static const struct cros_ec_bs_map cros_ec_keyb_bs[] = {
 		.bit		= EC_MKBP_LID_OPEN,
 		.inverted	= true,
 	},
+	{
+		.ev_type	= EV_SW,
+		.code		= SW_TABLET_MODE,
+		.bit		= EC_MKBP_TABLET_MODE,
+	},
 };
 
 /*
diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
index a01dde4..e793e9f 100644
--- a/include/linux/mfd/cros_ec_commands.h
+++ b/include/linux/mfd/cros_ec_commands.h
@@ -2094,6 +2094,7 @@ struct ec_response_get_next_event {
 
 /* Switches */
 #define EC_MKBP_LID_OPEN	0
+#define EC_MKBP_TABLET_MODE	1
 
 /*****************************************************************************/
 /* Temperature sensor commands */
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] input: cros_ec_keyb: Add Tablet Mode switch.
  2017-01-27 10:52 [PATCH] input: cros_ec_keyb: Add Tablet Mode switch Enric Balletbo i Serra
@ 2017-02-01 17:54 ` Dmitry Torokhov
  2017-02-08 11:39   ` [GIT PULL] Immutable branch between MFD and Input due for the v4.11 merge window Lee Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2017-02-01 17:54 UTC (permalink / raw)
  To: Lee Jones
  Cc: linux-input, linux-kernel, Gwendal Grignou, Enric Balletbo i Serra

On Fri, Jan 27, 2017 at 11:52:35AM +0100, Enric Balletbo i Serra wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
> 
> Add switch to report tablet mode.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Enric Balletbo Serra <enric.balletbo@collabora.com>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Lee, can you please take it as well?

> ---
> 
> I should be included this patch in the following patch series but I missed the
> patch and found later. Though it can be applied separetely.
> 
>  - [PATCH 1/2] mfd: cros-ec: Update cros_ec_commands.h for buttons and switches
>  - [PATCH 2/2] input: cros_ec_keyb: Add non-matrix buttons and switches
> 
>  drivers/input/keyboard/cros_ec_keyb.c | 5 +++++
>  include/linux/mfd/cros_ec_commands.h  | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index ad74ebc..604c7ad 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -111,6 +111,11 @@ static const struct cros_ec_bs_map cros_ec_keyb_bs[] = {
>  		.bit		= EC_MKBP_LID_OPEN,
>  		.inverted	= true,
>  	},
> +	{
> +		.ev_type	= EV_SW,
> +		.code		= SW_TABLET_MODE,
> +		.bit		= EC_MKBP_TABLET_MODE,
> +	},
>  };
>  
>  /*
> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
> index a01dde4..e793e9f 100644
> --- a/include/linux/mfd/cros_ec_commands.h
> +++ b/include/linux/mfd/cros_ec_commands.h
> @@ -2094,6 +2094,7 @@ struct ec_response_get_next_event {
>  
>  /* Switches */
>  #define EC_MKBP_LID_OPEN	0
> +#define EC_MKBP_TABLET_MODE	1
>  
>  /*****************************************************************************/
>  /* Temperature sensor commands */
> -- 
> 2.9.3
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [GIT PULL] Immutable branch between MFD and Input due for the v4.11 merge window
  2017-02-01 17:54 ` Dmitry Torokhov
@ 2017-02-08 11:39   ` Lee Jones
  2017-02-10  9:18     ` Enric Balletbo i Serra
  0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2017-02-08 11:39 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: linux-input, linux-kernel, Gwendal Grignou, Enric Balletbo i Serra

Dmitry,

> Lee, can you please take it as well?

The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

  Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-input-v4.11

for you to fetch changes up to cdd7950e7aa4a4d0d8ba71e3967aae6d25d09b03:

  input: cros_ec_keyb: Add non-matrix buttons and switches (2017-02-08 11:36:23 +0000)

----------------------------------------------------------------
Immutable branch between MFD and Input due for the v4.11 merge window

----------------------------------------------------------------
Douglas Anderson (2):
      mfd: cros-ec: Update cros_ec_commands.h for buttons and switches
      input: cros_ec_keyb: Add non-matrix buttons and switches

 drivers/input/keyboard/cros_ec_keyb.c | 447 ++++++++++++++++++++++++++++++----
 include/linux/mfd/cros_ec_commands.h  |  73 +++++-
 2 files changed, 473 insertions(+), 47 deletions(-)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [GIT PULL] Immutable branch between MFD and Input due for the v4.11 merge window
  2017-02-08 11:39   ` [GIT PULL] Immutable branch between MFD and Input due for the v4.11 merge window Lee Jones
@ 2017-02-10  9:18     ` Enric Balletbo i Serra
  2017-02-13  9:28       ` [GIT PULL] Subsequent immutable " Lee Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Enric Balletbo i Serra @ 2017-02-10  9:18 UTC (permalink / raw)
  To: Lee Jones, Dmitry Torokhov; +Cc: linux-input, linux-kernel, Gwendal Grignou

Lee,

On 08/02/17 12:39, Lee Jones wrote:
> Dmitry,
> 
>> Lee, can you please take it as well?
> 
> The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:
> 
>   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-input-v4.11
> 
> for you to fetch changes up to cdd7950e7aa4a4d0d8ba71e3967aae6d25d09b03:
> 
>   input: cros_ec_keyb: Add non-matrix buttons and switches (2017-02-08 11:36:23 +0000)
> 
> ----------------------------------------------------------------
> Immutable branch between MFD and Input due for the v4.11 merge window
> 
> ----------------------------------------------------------------
> Douglas Anderson (2):
>       mfd: cros-ec: Update cros_ec_commands.h for buttons and switches
>       input: cros_ec_keyb: Add non-matrix buttons and switches
> 

I see the above patches merged but not

 [PATCH] input: cros_ec_keyb: Add Tablet Mode switch.

Dmitry acked the patch and asked you if you can take patch. Is it possible for you include the patch? 


>  drivers/input/keyboard/cros_ec_keyb.c | 447 ++++++++++++++++++++++++++++++----
>  include/linux/mfd/cros_ec_commands.h  |  73 +++++-
>  2 files changed, 473 insertions(+), 47 deletions(-)
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [GIT PULL] Subsequent immutable branch between MFD and Input due for the v4.11 merge window
  2017-02-10  9:18     ` Enric Balletbo i Serra
@ 2017-02-13  9:28       ` Lee Jones
  0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2017-02-13  9:28 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: Dmitry Torokhov, linux-input, linux-kernel, Gwendal Grignou

Dmitry,

Enjoy!

The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

  Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-input-v4.11-1

for you to fetch changes up to 6ccc3a33810e8ec09936fa990c13370d9f61606f:

  input: cros_ec_keyb: Add Tablet Mode switch (2017-02-13 09:25:19 +0000)

----------------------------------------------------------------
Subsequent immutable branch between MFD and Input due for the v4.11 merge window

----------------------------------------------------------------
Douglas Anderson (2):
      mfd: cros-ec: Update cros_ec_commands.h for buttons and switches
      input: cros_ec_keyb: Add non-matrix buttons and switches

Gwendal Grignou (1):
      input: cros_ec_keyb: Add Tablet Mode switch

 drivers/input/keyboard/cros_ec_keyb.c | 452 ++++++++++++++++++++++++++++++----
 include/linux/mfd/cros_ec_commands.h  |  74 +++++-
 2 files changed, 479 insertions(+), 47 deletions(-)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-13  9:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-27 10:52 [PATCH] input: cros_ec_keyb: Add Tablet Mode switch Enric Balletbo i Serra
2017-02-01 17:54 ` Dmitry Torokhov
2017-02-08 11:39   ` [GIT PULL] Immutable branch between MFD and Input due for the v4.11 merge window Lee Jones
2017-02-10  9:18     ` Enric Balletbo i Serra
2017-02-13  9:28       ` [GIT PULL] Subsequent immutable " Lee Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.