* [PATCH iproute2/net-next repost] tc: flower: Update documentation to indicate ARP takes IPv4 prefixes
@ 2017-02-08 12:01 Simon Horman
2017-02-08 19:39 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2017-02-08 12:01 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Jiri Pirko, Dinan Gunawardena, netdev, oss-drivers, Simon Horman
Unlike other PREFIXes documented in the usage for tc flower, which accept
both IPv4 and IPv6 prefixes, arp_sip and arp_tip only accepts IPv4
prefixes.
Signed-off-by: Simon Horman <simon.horman@netronome.com>
---
* Repost after breaking out of a larger patchset
---
man/man8/tc-flower.8 | 8 ++++----
tc/f_flower.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8
index 2bdd2effd882..b1bef8b7637a 100644
--- a/man/man8/tc-flower.8
+++ b/man/man8/tc-flower.8
@@ -36,7 +36,7 @@ flower \- flow based traffic control filter
.BR dst_port " | " src_port " } "
.IR port_number " } | { "
.BR arp_tip " | " arp_sip " } "
-.IR PREFIX " | "
+.IR IPV4_PREFIX " | "
.BR arp_op " { " request " | " reply " | "
.IR OP " } | { "
.BR arp_tha " | " arp_sha " } "
@@ -139,11 +139,11 @@ Match on ICMP type or code. Only available for
.BR ip_proto " values " icmp " and " icmpv6
which have to be specified in beforehand.
.TP
-.BI arp_tip " PREFIX"
+.BI arp_tip " IPV4_PREFIX"
.TQ
-.BI arp_sip " PREFIX"
+.BI arp_sip " IPV4_PREFIX"
Match on ARP or RARP sender or target IP address.
-.I PREFIX
+.I IPV4_PREFIX
must be a valid IPv4 address optionally followed by a slash and the prefix
length. If the prefix is missing, \fBtc\fR assumes a full-length host
match.
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 403100c92af0..7cb2cd45a783 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -59,8 +59,8 @@ static void explain(void)
" src_port PORT-NUMBER |\n"
" type ICMP-TYPE |\n"
" code ICMP-CODE |\n"
- " arp_tip PREFIX |\n"
- " arp_sip PREFIX |\n"
+ " arp_tip IPV4-PREFIX |\n"
+ " arp_sip IPV4-PREFIX |\n"
" arp_op [ request | reply | OP ] |\n"
" arp_tha MASKED-LLADDR |\n"
" arp_sha MASKED-LLADDR |\n"
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2/net-next repost] tc: flower: Update documentation to indicate ARP takes IPv4 prefixes
2017-02-08 12:01 [PATCH iproute2/net-next repost] tc: flower: Update documentation to indicate ARP takes IPv4 prefixes Simon Horman
@ 2017-02-08 19:39 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-02-08 19:39 UTC (permalink / raw)
To: Simon Horman; +Cc: Jiri Pirko, Dinan Gunawardena, netdev, oss-drivers
On Wed, 8 Feb 2017 13:01:04 +0100
Simon Horman <simon.horman@netronome.com> wrote:
> Unlike other PREFIXes documented in the usage for tc flower, which accept
> both IPv4 and IPv6 prefixes, arp_sip and arp_tip only accepts IPv4
> prefixes.
>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
>
Applied to net-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-08 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-08 12:01 [PATCH iproute2/net-next repost] tc: flower: Update documentation to indicate ARP takes IPv4 prefixes Simon Horman
2017-02-08 19:39 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.