All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Shannon Nelson <shannon.nelson@oracle.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic
Date: Wed, 8 Feb 2017 07:59:47 -0800	[thread overview]
Message-ID: <20170208155947.GE30741@oracle.com> (raw)
In-Reply-To: <1486505582-76823-7-git-send-email-shannon.nelson@oracle.com>

On (02/07/17 14:12), Shannon Nelson wrote:
> +
> +	/* we don't expect any other bits */
> +	BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY |
> +				  LDC_EVENT_RESET |
> +				  LDC_EVENT_UP));
> +
> +	/* RESET takes precedent over any other event */
> +	if (port->rx_event & LDC_EVENT_RESET) { 
                  :
>  		port->rx_event = 0;
>  		return 0;
>  	}
> +	if (port->rx_event & LDC_EVENT_UP) {
> +		vio_link_state_change(vio, LDC_EVENT_UP);
> +		port->rx_event = 0;
> +		return 0;
> +	}
>  
>  	err = 0;
>  	tx_wakeup = 0;

IIRC there were timing-related situations where you can get woken up with
both UP and DATA_READY, and if my reading of your patch is 
correct, we would ignore the DATA_READY, and return, right?

--Sowmini

WARNING: multiple messages have this Message-ID (diff)
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Shannon Nelson <shannon.nelson@oracle.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic
Date: Wed, 08 Feb 2017 15:59:47 +0000	[thread overview]
Message-ID: <20170208155947.GE30741@oracle.com> (raw)
In-Reply-To: <1486505582-76823-7-git-send-email-shannon.nelson@oracle.com>

On (02/07/17 14:12), Shannon Nelson wrote:
> +
> +	/* we don't expect any other bits */
> +	BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY |
> +				  LDC_EVENT_RESET |
> +				  LDC_EVENT_UP));
> +
> +	/* RESET takes precedent over any other event */
> +	if (port->rx_event & LDC_EVENT_RESET) { 
                  :
>  		port->rx_event = 0;
>  		return 0;
>  	}
> +	if (port->rx_event & LDC_EVENT_UP) {
> +		vio_link_state_change(vio, LDC_EVENT_UP);
> +		port->rx_event = 0;
> +		return 0;
> +	}
>  
>  	err = 0;
>  	tx_wakeup = 0;

IIRC there were timing-related situations where you can get woken up with
both UP and DATA_READY, and if my reading of your patch is 
correct, we would ignore the DATA_READY, and return, right?

--Sowmini



  reply	other threads:[~2017-02-08 16:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 22:12 [PATCH v2 net-next 0/9] sunvnet driver updates Shannon Nelson
2017-02-07 22:12 ` Shannon Nelson
2017-02-07 22:12 ` [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson
2017-02-07 22:12   ` Shannon Nelson
2017-02-08 19:29   ` David Miller
2017-02-08 19:29     ` David Miller
2017-02-08 21:50     ` Shannon Nelson
2017-02-08 21:50       ` Shannon Nelson
2017-02-07 22:12 ` [PATCH v2 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson
2017-02-07 22:12   ` Shannon Nelson
2017-02-07 22:12 ` [PATCH v2 net-next 3/9] sunvnet: update version and version printing Shannon Nelson
2017-02-07 22:12   ` Shannon Nelson
2017-02-07 22:12 ` [PATCH v2 net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson
2017-02-07 22:12   ` Shannon Nelson
2017-02-07 22:12 ` [PATCH v2 net-next 5/9] sunvnet: add memory barrier before check for tx enable Shannon Nelson
2017-02-07 22:12   ` Shannon Nelson
2017-02-07 22:12 ` [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson
2017-02-07 22:12   ` Shannon Nelson
2017-02-08 15:59   ` Sowmini Varadhan [this message]
2017-02-08 15:59     ` Sowmini Varadhan
2017-02-08 16:28     ` Shannon Nelson
2017-02-08 16:28       ` Shannon Nelson
2017-02-08 16:34       ` Sowmini Varadhan
2017-02-08 16:34         ` Sowmini Varadhan
2017-02-07 22:13 ` [PATCH v2 net-next 7/9] sunvnet: remove extra rcu_read_unlocks Shannon Nelson
2017-02-07 22:13   ` Shannon Nelson
2017-02-07 22:13 ` [PATCH v2 net-next 8/9] ldmvsw: update and simplify version string Shannon Nelson
2017-02-07 22:13   ` Shannon Nelson
2017-02-07 22:13 ` [PATCH v2 net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson
2017-02-07 22:13   ` Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208155947.GE30741@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shannon.nelson@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.