From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
List Linux RDMA Mailing
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux NFS Mailing List
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 1/7] svcrdma: Another sendto chunk list parsing update
Date: Wed, 8 Feb 2017 11:57:00 -0500 [thread overview]
Message-ID: <20170208165700.GB16064@fieldses.org> (raw)
In-Reply-To: <C65F013C-84A2-456D-A0C0-04444D3C4D58-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Tue, Feb 07, 2017 at 03:30:58PM -0500, Chuck Lever wrote:
>
> > On Feb 7, 2017, at 2:42 PM, Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
> >
> >> /* Prepare the SGE for the RPCRDMA Header */
> >> ctxt->sge[0].lkey = rdma->sc_pd->local_dma_lkey;
> >> - ctxt->sge[0].length = svc_rdma_xdr_get_reply_hdr_len(rdma_resp);
> >> + ctxt->sge[0].length =
> >> + svc_rdma_xdr_get_reply_hdr_len((__be32 *)rdma_resp);
> >
> > That case is pretty ugly, but given that it'll go away soon it's
> > probably fine for now.
>
> Yes, the type cast will be replaced.
>
>
> > Otherwise this look good:
> >
> > Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
>
> Bruce, I assume you will pick up the extra Reviewed-by tags
> if I don't have to send another version of this series.
Yep, will do.
Thanks to you and Christoph.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
List Linux RDMA Mailing <linux-rdma@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] svcrdma: Another sendto chunk list parsing update
Date: Wed, 8 Feb 2017 11:57:00 -0500 [thread overview]
Message-ID: <20170208165700.GB16064@fieldses.org> (raw)
In-Reply-To: <C65F013C-84A2-456D-A0C0-04444D3C4D58@oracle.com>
On Tue, Feb 07, 2017 at 03:30:58PM -0500, Chuck Lever wrote:
>
> > On Feb 7, 2017, at 2:42 PM, Christoph Hellwig <hch@infradead.org> wrote:
> >
> >> /* Prepare the SGE for the RPCRDMA Header */
> >> ctxt->sge[0].lkey = rdma->sc_pd->local_dma_lkey;
> >> - ctxt->sge[0].length = svc_rdma_xdr_get_reply_hdr_len(rdma_resp);
> >> + ctxt->sge[0].length =
> >> + svc_rdma_xdr_get_reply_hdr_len((__be32 *)rdma_resp);
> >
> > That case is pretty ugly, but given that it'll go away soon it's
> > probably fine for now.
>
> Yes, the type cast will be replaced.
>
>
> > Otherwise this look good:
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Bruce, I assume you will pick up the extra Reviewed-by tags
> if I don't have to send another version of this series.
Yep, will do.
Thanks to you and Christoph.
--b.
next prev parent reply other threads:[~2017-02-08 16:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 16:58 [PATCH v3 0/7] Server-side NFS/RDMA changes for v4.11 Chuck Lever
2017-02-07 16:58 ` Chuck Lever
[not found] ` <20170207165131.14422.47088.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-07 16:58 ` [PATCH v3 1/7] svcrdma: Another sendto chunk list parsing update Chuck Lever
2017-02-07 16:58 ` Chuck Lever
[not found] ` <20170207165815.14422.77348.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-07 19:42 ` Christoph Hellwig
2017-02-07 19:42 ` Christoph Hellwig
[not found] ` <20170207194252.GA28088-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-07 20:30 ` Chuck Lever
2017-02-07 20:30 ` Chuck Lever
[not found] ` <C65F013C-84A2-456D-A0C0-04444D3C4D58-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-02-08 16:57 ` J. Bruce Fields [this message]
2017-02-08 16:57 ` J. Bruce Fields
2017-02-07 16:58 ` [PATCH v3 2/7] svcrdma: Clean up RPC-over-RDMA Reply header encoder Chuck Lever
2017-02-07 16:58 ` Chuck Lever
[not found] ` <20170207165823.14422.78711.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-07 17:20 ` Christoph Hellwig
2017-02-07 17:20 ` Christoph Hellwig
2017-02-07 16:58 ` [PATCH v3 3/7] svcrdma: Clean up RPC-over-RDMA Call header decoder Chuck Lever
2017-02-07 16:58 ` Chuck Lever
2017-02-07 16:58 ` [PATCH v3 4/7] svcrdma: Clean up backchannel send header encoding Chuck Lever
2017-02-07 16:58 ` Chuck Lever
2017-02-07 16:58 ` [PATCH v3 5/7] svcrdma: Remove unused sc_dto_q field Chuck Lever
2017-02-07 16:58 ` Chuck Lever
2017-02-07 16:58 ` [PATCH v3 6/7] svcrdma: Combine list fields in struct svc_rdma_op_ctxt Chuck Lever
2017-02-07 16:58 ` Chuck Lever
2017-02-07 16:59 ` [PATCH v3 7/7] svcrdma: Poll CQs in "workqueue" mode Chuck Lever
2017-02-07 16:59 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208165700.GB16064@fieldses.org \
--to=bfields-uc3wqj2krung9huczpvpmw@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.