* [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests
@ 2017-02-09 7:25 Fathi Boudra
2017-02-09 13:56 ` Bruce Ashfield
2017-03-14 7:17 ` Fathi Boudra
0 siblings, 2 replies; 6+ messages in thread
From: Fathi Boudra @ 2017-02-09 7:25 UTC (permalink / raw)
To: meta-virtualization; +Cc: bruce.ashfield, koen.kooi
Regular users don't need lxc, docker-registry and rt-tests on the target.
These tools aren't even needed or provide additional features when running
docker at runtime. They also increase the size of the image uneccessarily.
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
recipes-containers/docker/docker_git.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
index c208a02..81fd4d4 100644
--- a/recipes-containers/docker/docker_git.bb
+++ b/recipes-containers/docker/docker_git.bb
@@ -61,8 +61,8 @@ RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
"
RDEPENDS_${PN} += "containerd runc"
-RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
-RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
+RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
+RSUGGESTS_${PN} = "lxc docker-registry rt-tests"
DOCKER_PKG="github.com/docker/docker"
do_configure[noexec] = "1"
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests
2017-02-09 7:25 [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests Fathi Boudra
@ 2017-02-09 13:56 ` Bruce Ashfield
2017-02-09 14:52 ` Fathi Boudra
2017-03-14 7:17 ` Fathi Boudra
1 sibling, 1 reply; 6+ messages in thread
From: Bruce Ashfield @ 2017-02-09 13:56 UTC (permalink / raw)
To: Fathi Boudra, meta-virtualization; +Cc: koen.kooi
On 2017-02-09 02:25 AM, Fathi Boudra wrote:
> Regular users don't need lxc, docker-registry and rt-tests on the target.
> These tools aren't even needed or provide additional features when running
> docker at runtime. They also increase the size of the image uneccessarily.
They can also just inhibit the installation of rrecommends (which is
what I do).
But yes, I'm ok with making sure that these aren't slipping into more
builds than necessary.
Bruce
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> recipes-containers/docker/docker_git.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
> index c208a02..81fd4d4 100644
> --- a/recipes-containers/docker/docker_git.bb
> +++ b/recipes-containers/docker/docker_git.bb
> @@ -61,8 +61,8 @@ RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
> ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
> "
> RDEPENDS_${PN} += "containerd runc"
> -RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
> -RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
> +RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
> +RSUGGESTS_${PN} = "lxc docker-registry rt-tests"
> DOCKER_PKG="github.com/docker/docker"
>
> do_configure[noexec] = "1"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests
2017-02-09 13:56 ` Bruce Ashfield
@ 2017-02-09 14:52 ` Fathi Boudra
2017-02-09 14:52 ` Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: Fathi Boudra @ 2017-02-09 14:52 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: meta-virtualization, Koen Kooi
On 9 February 2017 at 15:56, Bruce Ashfield
<bruce.ashfield@windriver.com> wrote:
> On 2017-02-09 02:25 AM, Fathi Boudra wrote:
>>
>> Regular users don't need lxc, docker-registry and rt-tests on the target.
>> These tools aren't even needed or provide additional features when running
>> docker at runtime. They also increase the size of the image uneccessarily.
>
>
> They can also just inhibit the installation of rrecommends (which is
> what I do).
>
> But yes, I'm ok with making sure that these aren't slipping into more
> builds than necessary.
yes, that's what I thought too but I think it's worth fixing to avoid
everybody using docker to fallback using BAD_RECOMMENDATIONS,
NO_RECOMMENDATIONS or PACKAGE_EXCLUDE.
> Bruce
>
>
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>> ---
>> recipes-containers/docker/docker_git.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-containers/docker/docker_git.bb
>> b/recipes-containers/docker/docker_git.bb
>> index c208a02..81fd4d4 100644
>> --- a/recipes-containers/docker/docker_git.bb
>> +++ b/recipes-containers/docker/docker_git.bb
>> @@ -61,8 +61,8 @@ RDEPENDS_${PN} = "curl aufs-util git util-linux iptables
>> \
>>
>> ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
>> "
>> RDEPENDS_${PN} += "containerd runc"
>> -RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
>> -RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
>> +RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
>> +RSUGGESTS_${PN} = "lxc docker-registry rt-tests"
>> DOCKER_PKG="github.com/docker/docker"
>>
>> do_configure[noexec] = "1"
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests
2017-02-09 14:52 ` Fathi Boudra
@ 2017-02-09 14:52 ` Bruce Ashfield
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2017-02-09 14:52 UTC (permalink / raw)
To: Fathi Boudra; +Cc: meta-virtualization, Koen Kooi
On 2017-02-09 09:52 AM, Fathi Boudra wrote:
> On 9 February 2017 at 15:56, Bruce Ashfield
> <bruce.ashfield@windriver.com> wrote:
>> On 2017-02-09 02:25 AM, Fathi Boudra wrote:
>>>
>>> Regular users don't need lxc, docker-registry and rt-tests on the target.
>>> These tools aren't even needed or provide additional features when running
>>> docker at runtime. They also increase the size of the image uneccessarily.
>>
>>
>> They can also just inhibit the installation of rrecommends (which is
>> what I do).
>>
>> But yes, I'm ok with making sure that these aren't slipping into more
>> builds than necessary.
>
> yes, that's what I thought too but I think it's worth fixing to avoid
> everybody using docker to fallback using BAD_RECOMMENDATIONS,
> NO_RECOMMENDATIONS or PACKAGE_EXCLUDE.
Agreed. It isn't obvious why lxc appears on the target when you
just want docker :D
This is now merged.
Bruce
>
>> Bruce
>>
>>
>>>
>>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>>> ---
>>> recipes-containers/docker/docker_git.bb | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/recipes-containers/docker/docker_git.bb
>>> b/recipes-containers/docker/docker_git.bb
>>> index c208a02..81fd4d4 100644
>>> --- a/recipes-containers/docker/docker_git.bb
>>> +++ b/recipes-containers/docker/docker_git.bb
>>> @@ -61,8 +61,8 @@ RDEPENDS_${PN} = "curl aufs-util git util-linux iptables
>>> \
>>>
>>> ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
>>> "
>>> RDEPENDS_${PN} += "containerd runc"
>>> -RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
>>> -RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
>>> +RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
>>> +RSUGGESTS_${PN} = "lxc docker-registry rt-tests"
>>> DOCKER_PKG="github.com/docker/docker"
>>>
>>> do_configure[noexec] = "1"
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests
2017-02-09 7:25 [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests Fathi Boudra
2017-02-09 13:56 ` Bruce Ashfield
@ 2017-03-14 7:17 ` Fathi Boudra
2017-03-14 12:07 ` Bruce Ashfield
1 sibling, 1 reply; 6+ messages in thread
From: Fathi Boudra @ 2017-03-14 7:17 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: meta-virtualization
Bruce, can you cherry-pick this patch in Morty branch?
or do you prefer I send a patch for the branch?
On 9 February 2017 at 09:25, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> Regular users don't need lxc, docker-registry and rt-tests on the target.
> These tools aren't even needed or provide additional features when running
> docker at runtime. They also increase the size of the image uneccessarily.
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> recipes-containers/docker/docker_git.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
> index c208a02..81fd4d4 100644
> --- a/recipes-containers/docker/docker_git.bb
> +++ b/recipes-containers/docker/docker_git.bb
> @@ -61,8 +61,8 @@ RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
> ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
> "
> RDEPENDS_${PN} += "containerd runc"
> -RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
> -RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
> +RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
> +RSUGGESTS_${PN} = "lxc docker-registry rt-tests"
> DOCKER_PKG="github.com/docker/docker"
>
> do_configure[noexec] = "1"
> --
> 2.11.0
>
Cheers,
Fathi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests
2017-03-14 7:17 ` Fathi Boudra
@ 2017-03-14 12:07 ` Bruce Ashfield
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2017-03-14 12:07 UTC (permalink / raw)
To: Fathi Boudra; +Cc: meta-virtualization
On 2017-03-14 3:17 AM, Fathi Boudra wrote:
> Bruce, can you cherry-pick this patch in Morty branch?
> or do you prefer I send a patch for the branch?
No need for a patch, this is definitely good enough!
They cherry pick and push is now done for morty.
Cheers,
Bruce
>
> On 9 February 2017 at 09:25, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> Regular users don't need lxc, docker-registry and rt-tests on the target.
>> These tools aren't even needed or provide additional features when running
>> docker at runtime. They also increase the size of the image uneccessarily.
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>> ---
>> recipes-containers/docker/docker_git.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
>> index c208a02..81fd4d4 100644
>> --- a/recipes-containers/docker/docker_git.bb
>> +++ b/recipes-containers/docker/docker_git.bb
>> @@ -61,8 +61,8 @@ RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
>> ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
>> "
>> RDEPENDS_${PN} += "containerd runc"
>> -RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
>> -RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
>> +RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
>> +RSUGGESTS_${PN} = "lxc docker-registry rt-tests"
>> DOCKER_PKG="github.com/docker/docker"
>>
>> do_configure[noexec] = "1"
>> --
>> 2.11.0
>>
>
> Cheers,
> Fathi
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-14 12:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 7:25 [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests Fathi Boudra
2017-02-09 13:56 ` Bruce Ashfield
2017-02-09 14:52 ` Fathi Boudra
2017-02-09 14:52 ` Bruce Ashfield
2017-03-14 7:17 ` Fathi Boudra
2017-03-14 12:07 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.