All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
@ 2017-02-09  6:13 ` Yisheng Xie
  0 siblings, 0 replies; 6+ messages in thread
From: Yisheng Xie @ 2017-02-09  6:13 UTC (permalink / raw)
  To: akpm
  Cc: linux-mm, linux-kernel, minchan, sergey.senozhatsky, ngupta, guohanjun

The class index and fullness group are not encoded in (first)page->mapping
any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
structure"). Instead, they are store in struct zspage. Just delete this
unneeded comment.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Hanjun Guo <guohanjun@huawei.com>
---
v2:
 * just delete the comment for it is no need anymore, suggested by Sergey.

 mm/zsmalloc.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9cc3c0b..08c1a84 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -268,10 +268,6 @@ struct zs_pool {
 #endif
 };
 
-/*
- * A zspage's class index and fullness group
- * are encoded in its (first)page->mapping
- */
 #define FULLNESS_BITS	2
 #define CLASS_BITS	8
 #define ISOLATED_BITS	3
-- 
1.7.12.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
@ 2017-02-09  6:13 ` Yisheng Xie
  0 siblings, 0 replies; 6+ messages in thread
From: Yisheng Xie @ 2017-02-09  6:13 UTC (permalink / raw)
  To: akpm
  Cc: linux-mm, linux-kernel, minchan, sergey.senozhatsky, ngupta, guohanjun

The class index and fullness group are not encoded in (first)page->mapping
any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
structure"). Instead, they are store in struct zspage. Just delete this
unneeded comment.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Hanjun Guo <guohanjun@huawei.com>
---
v2:
 * just delete the comment for it is no need anymore, suggested by Sergey.

 mm/zsmalloc.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9cc3c0b..08c1a84 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -268,10 +268,6 @@ struct zs_pool {
 #endif
 };
 
-/*
- * A zspage's class index and fullness group
- * are encoded in its (first)page->mapping
- */
 #define FULLNESS_BITS	2
 #define CLASS_BITS	8
 #define ISOLATED_BITS	3
-- 
1.7.12.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
  2017-02-09  6:13 ` Yisheng Xie
@ 2017-02-09  7:05   ` Sergey Senozhatsky
  -1 siblings, 0 replies; 6+ messages in thread
From: Sergey Senozhatsky @ 2017-02-09  7:05 UTC (permalink / raw)
  To: Yisheng Xie
  Cc: akpm, linux-mm, linux-kernel, minchan, sergey.senozhatsky,
	ngupta, guohanjun

On (02/09/17 14:13), Yisheng Xie wrote:
> The class index and fullness group are not encoded in (first)page->mapping
> any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> structure"). Instead, they are store in struct zspage. Just delete this
> unneeded comment.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Hanjun Guo <guohanjun@huawei.com>
> ---
> v2:
>  * just delete the comment for it is no need anymore, suggested by Sergey.

thanks for the patch.

my "suggestion" was just a side note, nothing more. I'm fine with the
"fix the comment" patch that Andrew has added to mmotm.
we need Minchan's opinion on this, until he speaks out let's have V1
("fix the comment") applied.

	-ss

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
@ 2017-02-09  7:05   ` Sergey Senozhatsky
  0 siblings, 0 replies; 6+ messages in thread
From: Sergey Senozhatsky @ 2017-02-09  7:05 UTC (permalink / raw)
  To: Yisheng Xie
  Cc: akpm, linux-mm, linux-kernel, minchan, sergey.senozhatsky,
	ngupta, guohanjun

On (02/09/17 14:13), Yisheng Xie wrote:
> The class index and fullness group are not encoded in (first)page->mapping
> any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> structure"). Instead, they are store in struct zspage. Just delete this
> unneeded comment.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Hanjun Guo <guohanjun@huawei.com>
> ---
> v2:
>  * just delete the comment for it is no need anymore, suggested by Sergey.

thanks for the patch.

my "suggestion" was just a side note, nothing more. I'm fine with the
"fix the comment" patch that Andrew has added to mmotm.
we need Minchan's opinion on this, until he speaks out let's have V1
("fix the comment") applied.

	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
  2017-02-09  7:05   ` Sergey Senozhatsky
@ 2017-02-09  8:09     ` Minchan Kim
  -1 siblings, 0 replies; 6+ messages in thread
From: Minchan Kim @ 2017-02-09  8:09 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Yisheng Xie, akpm, linux-mm, linux-kernel, sergey.senozhatsky,
	ngupta, guohanjun

On Thu, Feb 09, 2017 at 04:05:43PM +0900, Sergey Senozhatsky wrote:
> On (02/09/17 14:13), Yisheng Xie wrote:
> > The class index and fullness group are not encoded in (first)page->mapping
> > any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> > structure"). Instead, they are store in struct zspage. Just delete this
> > unneeded comment.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: Nitin Gupta <ngupta@vflare.org>
> > Cc: Hanjun Guo <guohanjun@huawei.com>
Acked-by: Minchan Kim <minchan@kernel.org>

> > ---
> > v2:
> >  * just delete the comment for it is no need anymore, suggested by Sergey.
> 
> thanks for the patch.
> 
> my "suggestion" was just a side note, nothing more. I'm fine with the
> "fix the comment" patch that Andrew has added to mmotm.
> we need Minchan's opinion on this, until he speaks out let's have V1
> ("fix the comment") applied.

I agree on Sergey's opinion.

Andrew,
Please drop previous patch and replace it with this.

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
@ 2017-02-09  8:09     ` Minchan Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Minchan Kim @ 2017-02-09  8:09 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Yisheng Xie, akpm, linux-mm, linux-kernel, sergey.senozhatsky,
	ngupta, guohanjun

On Thu, Feb 09, 2017 at 04:05:43PM +0900, Sergey Senozhatsky wrote:
> On (02/09/17 14:13), Yisheng Xie wrote:
> > The class index and fullness group are not encoded in (first)page->mapping
> > any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> > structure"). Instead, they are store in struct zspage. Just delete this
> > unneeded comment.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: Nitin Gupta <ngupta@vflare.org>
> > Cc: Hanjun Guo <guohanjun@huawei.com>
Acked-by: Minchan Kim <minchan@kernel.org>

> > ---
> > v2:
> >  * just delete the comment for it is no need anymore, suggested by Sergey.
> 
> thanks for the patch.
> 
> my "suggestion" was just a side note, nothing more. I'm fine with the
> "fix the comment" patch that Andrew has added to mmotm.
> we need Minchan's opinion on this, until he speaks out let's have V1
> ("fix the comment") applied.

I agree on Sergey's opinion.

Andrew,
Please drop previous patch and replace it with this.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-09  8:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09  6:13 [PATCH v2] mm/zsmalloc: fix comment in zsmalloc Yisheng Xie
2017-02-09  6:13 ` Yisheng Xie
2017-02-09  7:05 ` Sergey Senozhatsky
2017-02-09  7:05   ` Sergey Senozhatsky
2017-02-09  8:09   ` Minchan Kim
2017-02-09  8:09     ` Minchan Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.