All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alban <albeu@free.fr>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Alban <albeu@free.fr>, <linux-kernel@vger.kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH 1/4] reset: ath79: make it explicitly non-modular
Date: Thu, 9 Feb 2017 10:03:34 +0100	[thread overview]
Message-ID: <20170209100334.462049d5@avionic-0020> (raw)
In-Reply-To: <20170208001847.9887-2-paul.gortmaker@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Tue, 7 Feb 2017 19:18:44 -0500
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/reset/Kconfig:config RESET_ATH79
> drivers/reset/Kconfig:  bool "AR71xx Reset Driver" if COMPILE_TEST
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Alban Bedel <albeu@free.fr>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Alban Bedel <albeu@free.fr>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-02-09  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08  0:18 [PATCH 0/4] reset: de-modularize the remaining reset drivers Paul Gortmaker
2017-02-08  0:18 ` Paul Gortmaker
2017-02-08  0:18 ` [PATCH 1/4] reset: ath79: make it explicitly non-modular Paul Gortmaker
2017-02-09  9:03   ` Alban [this message]
2017-02-08  0:18 ` [PATCH 2/4] reset: pistachio: " Paul Gortmaker
2017-02-08  0:18 ` [PATCH 3/4] reset: meson: " Paul Gortmaker
2017-02-08  0:18   ` Paul Gortmaker
2017-02-08  8:43   ` Neil Armstrong
2017-02-08  8:43     ` Neil Armstrong
2017-02-08  0:18 ` [PATCH 4/4] reset: oxnas: " Paul Gortmaker
2017-02-08  8:44   ` Neil Armstrong
2017-02-08 10:43 ` [PATCH 0/4] reset: de-modularize the remaining reset drivers Philipp Zabel
2017-02-08 10:43   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209100334.462049d5@avionic-0020 \
    --to=albeu@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.