* [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update
@ 2017-02-09 14:17 Ivan Khoronzhuk
2017-02-10 18:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Khoronzhuk @ 2017-02-09 14:17 UTC (permalink / raw)
To: w-kwok2, m-karicheri2, netdev; +Cc: linux-kernel, Ivan Khoronzhuk
No need to update jiffies in txq->trans_start twice and only for tx 0,
it's supposed to be done in netdev_start_xmit() and per tx queue.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net-next/master
drivers/net/ethernet/ti/netcp_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index ebab1473..7c7ae08 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -1316,8 +1316,6 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
if (ret)
goto drop;
- netif_trans_update(ndev);
-
/* Check Tx pool count & stop subqueue if needed */
desc_count = knav_pool_count(netcp->tx_pool);
if (desc_count < netcp->tx_pause_threshold) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update
2017-02-09 14:17 [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update Ivan Khoronzhuk
@ 2017-02-10 18:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-10 18:53 UTC (permalink / raw)
To: ivan.khoronzhuk; +Cc: w-kwok2, m-karicheri2, netdev, linux-kernel
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Thu, 9 Feb 2017 16:17:40 +0200
> No need to update jiffies in txq->trans_start twice and only for tx 0,
> it's supposed to be done in netdev_start_xmit() and per tx queue.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> Based on net-next/master
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-10 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 14:17 [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update Ivan Khoronzhuk
2017-02-10 18:53 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.