All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND v7 0/1] usb: xhci: plat: Enable runtime PM
@ 2017-02-10 14:56 Robert Foss
  2017-02-10 14:56 ` [PATCH RESEND v7 1/1] usb: xhci: plat: Enable async suspend/resume Robert Foss
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2017-02-10 14:56 UTC (permalink / raw)
  To: mathias.nyman, gregkh, linux-usb, linux-kernel, Julius Werner,
	Andrew Bresticker, Felipe Balbi, Brian Norris, Baolin Wang
  Cc: Robert Foss


This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.

Changes since v1:
- Added Signed-off-by: Robert Foss <robert.foss@collabora.com>
- Added proper metadata tags to series

Changes since v2:
- Added missing changelog to cover-letter
- Added error checking to pm_runtime_get_sync() calls

Changes since v3:
- Decrement usage_counter for failed pm_runtime_get*() calls

Changes since v4:
- Added missing brackets

Changes since v5:
- Switched out atomic_dec() calls with pm_runtime_put() calls

Changes since v6:
- Rebased on v4.10-rc3
- Dropped "usb: xhci: plat: Enable async suspend/resume" since it is superseded by
  https://lkml.org/lkml/2016/12/13/32


Andrew Bresticker (1):
  usb: xhci: plat: Enable async suspend/resume

 drivers/usb/host/xhci-plat.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.11.0.453.g787f75f05

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH RESEND v7 1/1] usb: xhci: plat: Enable async suspend/resume
  2017-02-10 14:56 [PATCH RESEND v7 0/1] usb: xhci: plat: Enable runtime PM Robert Foss
@ 2017-02-10 14:56 ` Robert Foss
  2017-02-20  2:50   ` Baolin Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2017-02-10 14:56 UTC (permalink / raw)
  To: mathias.nyman, gregkh, linux-usb, linux-kernel, Julius Werner,
	Andrew Bresticker, Felipe Balbi, Brian Norris, Baolin Wang
  Cc: Robert Foss

From: Andrew Bresticker <abrestic@chromium.org>

USB host controllers can take a significant amount of time to suspend
and resume, adding several hundred miliseconds to the kernel resume
time. Since the XHCI controller has no outside dependencies (other than
clocks, which are suspended late/resumed early), allow it to suspend and
resume asynchronously.

Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Tested-by: Andrew Bresticker <abrestic@chromium.org>
Tested-by: Robert Foss <robert.foss@collabora.com>
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
 drivers/usb/host/xhci-plat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 3cf8e120c620..4d6741a0d8f8 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -257,6 +257,7 @@ static int xhci_plat_probe(struct platform_device *pdev)
 
 	pm_runtime_set_active(&pdev->dev);
 	pm_runtime_enable(&pdev->dev);
+	device_enable_async_suspend(&pdev->dev);
 
 	return 0;
 
-- 
2.11.0.453.g787f75f05

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND v7 1/1] usb: xhci: plat: Enable async suspend/resume
  2017-02-10 14:56 ` [PATCH RESEND v7 1/1] usb: xhci: plat: Enable async suspend/resume Robert Foss
@ 2017-02-20  2:50   ` Baolin Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2017-02-20  2:50 UTC (permalink / raw)
  To: Robert Foss
  Cc: Mathias Nyman, Greg KH, USB, LKML, Julius Werner,
	Andrew Bresticker, Felipe Balbi, Brian Norris

On 10 February 2017 at 22:56, Robert Foss <robert.foss@collabora.com> wrote:
> From: Andrew Bresticker <abrestic@chromium.org>
>
> USB host controllers can take a significant amount of time to suspend
> and resume, adding several hundred miliseconds to the kernel resume
> time. Since the XHCI controller has no outside dependencies (other than
> clocks, which are suspended late/resumed early), allow it to suspend and
> resume asynchronously.
>
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> Tested-by: Andrew Bresticker <abrestic@chromium.org>
> Tested-by: Robert Foss <robert.foss@collabora.com>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
>  drivers/usb/host/xhci-plat.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 3cf8e120c620..4d6741a0d8f8 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -257,6 +257,7 @@ static int xhci_plat_probe(struct platform_device *pdev)
>
>         pm_runtime_set_active(&pdev->dev);
>         pm_runtime_enable(&pdev->dev);
> +       device_enable_async_suspend(&pdev->dev);
>
>         return 0;
>
> --
> 2.11.0.453.g787f75f05
>

Reviewed-by: Baolin Wang <baolin.wang@linaro.org>

-- 
Baolin.wang
Best Regards

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-20  2:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 14:56 [PATCH RESEND v7 0/1] usb: xhci: plat: Enable runtime PM Robert Foss
2017-02-10 14:56 ` [PATCH RESEND v7 1/1] usb: xhci: plat: Enable async suspend/resume Robert Foss
2017-02-20  2:50   ` Baolin Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.