* [PATCH] btrfs: remove unused ulist members
@ 2017-02-09 15:47 David Sterba
2017-02-10 0:56 ` Qu Wenruo
2017-02-10 15:19 ` Liu Bo
0 siblings, 2 replies; 3+ messages in thread
From: David Sterba @ 2017-02-09 15:47 UTC (permalink / raw)
To: linux-btrfs; +Cc: David Sterba
Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8)
removed some debugging code but left the structure defintions.
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/ulist.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/btrfs/ulist.h b/fs/btrfs/ulist.h
index a01a2c45825f..007b22fff3f9 100644
--- a/fs/btrfs/ulist.h
+++ b/fs/btrfs/ulist.h
@@ -19,9 +19,6 @@
*
*/
struct ulist_iterator {
-#ifdef CONFIG_BTRFS_DEBUG
- int i;
-#endif
struct list_head *cur_list; /* hint to start search */
};
@@ -32,10 +29,6 @@ struct ulist_node {
u64 val; /* value to store */
u64 aux; /* auxiliary value saved along with the val */
-#ifdef CONFIG_BTRFS_DEBUG
- int seqnum; /* sequence number this node is added */
-#endif
-
struct list_head list; /* used to link node */
struct rb_node rb_node; /* used to speed up search */
};
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unused ulist members
2017-02-09 15:47 [PATCH] btrfs: remove unused ulist members David Sterba
@ 2017-02-10 0:56 ` Qu Wenruo
2017-02-10 15:19 ` Liu Bo
1 sibling, 0 replies; 3+ messages in thread
From: Qu Wenruo @ 2017-02-10 0:56 UTC (permalink / raw)
To: David Sterba, linux-btrfs
At 02/09/2017 11:47 PM, David Sterba wrote:
> Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8)
> removed some debugging code but left the structure defintions.
>
> Signed-off-by: David Sterba <dsterba@suse.com>
Thanks for deleting that, I forgot to remove the member in structure.
Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Thanks,
Qu
> ---
> fs/btrfs/ulist.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/btrfs/ulist.h b/fs/btrfs/ulist.h
> index a01a2c45825f..007b22fff3f9 100644
> --- a/fs/btrfs/ulist.h
> +++ b/fs/btrfs/ulist.h
> @@ -19,9 +19,6 @@
> *
> */
> struct ulist_iterator {
> -#ifdef CONFIG_BTRFS_DEBUG
> - int i;
> -#endif
> struct list_head *cur_list; /* hint to start search */
> };
>
> @@ -32,10 +29,6 @@ struct ulist_node {
> u64 val; /* value to store */
> u64 aux; /* auxiliary value saved along with the val */
>
> -#ifdef CONFIG_BTRFS_DEBUG
> - int seqnum; /* sequence number this node is added */
> -#endif
> -
> struct list_head list; /* used to link node */
> struct rb_node rb_node; /* used to speed up search */
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unused ulist members
2017-02-09 15:47 [PATCH] btrfs: remove unused ulist members David Sterba
2017-02-10 0:56 ` Qu Wenruo
@ 2017-02-10 15:19 ` Liu Bo
1 sibling, 0 replies; 3+ messages in thread
From: Liu Bo @ 2017-02-10 15:19 UTC (permalink / raw)
To: David Sterba; +Cc: linux-btrfs
On Thu, Feb 09, 2017 at 04:47:43PM +0100, David Sterba wrote:
> Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8)
> removed some debugging code but left the structure defintions.
>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
> fs/btrfs/ulist.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/btrfs/ulist.h b/fs/btrfs/ulist.h
> index a01a2c45825f..007b22fff3f9 100644
> --- a/fs/btrfs/ulist.h
> +++ b/fs/btrfs/ulist.h
> @@ -19,9 +19,6 @@
> *
> */
> struct ulist_iterator {
> -#ifdef CONFIG_BTRFS_DEBUG
> - int i;
> -#endif
> struct list_head *cur_list; /* hint to start search */
> };
>
> @@ -32,10 +29,6 @@ struct ulist_node {
> u64 val; /* value to store */
> u64 aux; /* auxiliary value saved along with the val */
>
> -#ifdef CONFIG_BTRFS_DEBUG
> - int seqnum; /* sequence number this node is added */
> -#endif
> -
> struct list_head list; /* used to link node */
> struct rb_node rb_node; /* used to speed up search */
> };
> --
> 2.10.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-10 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 15:47 [PATCH] btrfs: remove unused ulist members David Sterba
2017-02-10 0:56 ` Qu Wenruo
2017-02-10 15:19 ` Liu Bo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.